public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Sandiford <richard.sandiford@arm.com>
To: Joey Ye <joey.ye.cc@gmail.com>
Cc: "Bin.Cheng" <amker.cheng@gmail.com>,
	 gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH AArch64]Fix test failure for pr84682-2.c
Date: Thu, 30 Aug 2018 12:24:00 -0000	[thread overview]
Message-ID: <87lg8om49r.fsf@arm.com> (raw)
In-Reply-To: <CAL0py25m3UVXz6VH4wCA+3EZjp+2+uasxKH=8z+=Ugfg5onMTA@mail.gmail.com>	(Joey Ye's message of "Thu, 30 Aug 2018 11:20:56 +0100")

Joey Ye <joey.ye.cc@gmail.com> writes:
> Hi Bin & Richard,
>
> It is not as simple as keeping the assertion, which still fails even
> with the change in reorg.c. The testing result is as following:
>
> I. With Bin's patch version 2 (removing the assertion in aarch64.c and
> adding the check in reorg.c): pr84682-2.c passes
>
> II. With Richard's suggestion to keep the assertion in aarch64, but
> adding the check in reorg.c: pr84682-2.c fails
>
> Apparently there is a different path that reaches the assertion.

Yeah, looks like we also need to make constrain_operands check
address_operand for 'p' (which I think it should do irrespective
of "strict", since in general we can only reload an operand as
a pointer if the original value has the right form for an address).

Thanks,
Richard

  parent reply	other threads:[~2018-08-30 12:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-16 11:43 Bin Cheng
2018-03-16 11:53 ` Kyrill Tkachov
2018-03-17  9:20   ` Richard Sandiford
2018-03-22 11:11     ` Bin.Cheng
2018-04-24 15:14       ` Bin.Cheng
2018-05-16  8:37       ` Kyrill Tkachov
2018-08-29 15:50         ` Joey Ye
2018-08-29 18:47           ` Richard Sandiford
2018-08-30  1:02             ` Bin.Cheng
2018-08-30 10:21               ` Joey Ye
2018-08-30 10:28                 ` Joey Ye
2018-08-30 12:24                 ` Richard Sandiford [this message]
2018-12-12 11:29                   ` Richard Earnshaw (lists)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lg8om49r.fsf@arm.com \
    --to=richard.sandiford@arm.com \
    --cc=amker.cheng@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=joey.ye.cc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).