From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107739 invoked by alias); 14 Mar 2018 09:13:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 107715 invoked by uid 89); 14 Mar 2018 09:13:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wm0-f42.google.com Received: from mail-wm0-f42.google.com (HELO mail-wm0-f42.google.com) (74.125.82.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 14 Mar 2018 09:13:48 +0000 Received: by mail-wm0-f42.google.com with SMTP id t6so2541219wmt.5 for ; Wed, 14 Mar 2018 02:13:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:mail-followup-to:cc:subject:references :date:in-reply-to:message-id:user-agent:mime-version; bh=/oc44o0g5U2HSO0TLNoe3KC2RoAU4XxQPsf7pCCQTLo=; b=OMFIX/fajerX0O3rLCFfeSTs7CAJebOPy3YwIx8vzH3mDcBEjer5hr6SiIbqpz7bwh ExxVdW+eO51KCa3smnhyf5HtaWJ31/2hyERO5SN/UKkyvBoWvQHgW3iXxZ/ujGmV/E0C t25RMpBubvy0i+et/rvcnW335YlKwKLxd3joqb1k6B8XBPZEN/32nRAqbC78Z25e3qCC dPaAKl0Z646lIkdl7FSq7Ck3hTkInZEBpfyMM9J7uBtBtilYr2hfOaR64t+o4Zwpcjcl a7KeJ1YMeYFuVGy8Ipm+tzJnA6OVQ/ZqamrU/89TH7tCTvZWRr09OwL/P3wulUq2Dwrk jDrQ== X-Gm-Message-State: AElRT7FSwBJN/L5yUdloyqPRCrbh5areO84FjmL6jDin3XrabvmlgTqo 0Zbc4pC2Jah/elirSVkrlRkwtA== X-Google-Smtp-Source: AG47ELvy5c6YIOTvXdOqPQe+1iCmHa3coOxEJxwBxFjKTE2L8xLFdz3oOsH0Rb9vx5+y2oLby2qEgw== X-Received: by 10.28.61.65 with SMTP id k62mr1067057wma.140.1521018826867; Wed, 14 Mar 2018 02:13:46 -0700 (PDT) Received: from localhost ([217.140.96.141]) by smtp.gmail.com with ESMTPSA id 41sm2013556wrc.33.2018.03.14.02.13.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Mar 2018 02:13:45 -0700 (PDT) From: Richard Sandiford To: Christophe Lyon Mail-Followup-To: Christophe Lyon ,gcc Patches , Richard Earnshaw , James Greenhalgh , Marcus Shawcroft , richard.sandiford@linaro.org Cc: gcc Patches , Richard Earnshaw , James Greenhalgh , Marcus Shawcroft Subject: Re: [AArch64] Add SVE mul_highpart patterns References: <874lmry4c1.fsf@linaro.org> Date: Wed, 14 Mar 2018 09:51:00 -0000 In-Reply-To: (Christophe Lyon's message of "Wed, 14 Mar 2018 09:32:40 +0100") Message-ID: <87lgev9fzr.fsf@linaro.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-03/txt/msg00642.txt.bz2 Christophe Lyon writes: > On 8 February 2018 at 14:54, Richard Sandiford > wrote: >> Index: gcc/testsuite/gcc.target/aarch64/sve/mul_highpart_1_run.c >> =================================================================== >> --- /dev/null 2018-02-08 11:17:10.862716283 +0000 >> +++ gcc/testsuite/gcc.target/aarch64/sve/mul_highpart_1_run.c 2018-02-08 13:51:56.253511883 +0000 >> @@ -0,0 +1,29 @@ >> +/* { dg-do run } */ > You forgot to include an effective target to prevent trying to run on > non-SVE capable HW. Oops, sorry about that. I had the fix in the tree I use for non-SVE testing but forgot to update the commit tree. Applied as below. > I suppose check_effective_target_aarch64_sve_hw would work, but I 'm > not sure it's sufficient to prevent from compiling the test with old > binutils non supporting sve: maybe you also need to add > aarch64_asm_sve_ok as in the other testcase? It should be OK. aarch64_sve_hw is supposed to imply aarch64_asm_sve_ok, since it needs to both assemble and run SVE code. Thanks, Richard 2018-03-14 Richard Sandiford gcc/testsuite/ * gcc.target/aarch64/sve/mul_highpart_1_run.c: Restrict to aarch64_sve_hw. Index: gcc/testsuite/gcc.target/aarch64/sve/mul_highpart_1_run.c =================================================================== --- gcc/testsuite/gcc.target/aarch64/sve/mul_highpart_1_run.c 2018-03-13 15:11:55.402370138 +0000 +++ gcc/testsuite/gcc.target/aarch64/sve/mul_highpart_1_run.c 2018-03-14 09:06:36.946848641 +0000 @@ -1,4 +1,4 @@ -/* { dg-do run } */ +/* { dg-do run { target aarch64_sve_hw } } */ /* { dg-options "-O2 -ftree-vectorize -fno-vect-cost-model --save-temps" } */ #include "mul_highpart_1.c"