Re: [gomp4] OpenACC reduction tests

[Thomas Schwinge <thomas@codesourcery.com>]

[-- Attachment #1: Type: text/plain, Size: 2053 bytes --]

Hi!

On Wed, 23 Sep 2015 09:56:44 +0200, I wrote:
> On Fri, 18 Sep 2015 10:11:25 +0200, I wrote:
> > On Fri, 17 Jul 2015 11:13:59 -0700, Cesar Philippidis <cesar@codesourcery.com> wrote:
> > > This patch updates the libgomp OpenACC reduction test cases [...]

> > Given the following
> > -Wuninitialized/-Wmaybe-uninitialized warnings (for -O1, for example),
> > maybe there's some initialization of (internal) variables missing?
> > (These user-visible warnings about compiler internals need to be
> > addressed regardless.)  Would you please have a look at that?
> > 
> >     source-gcc/libgomp/testsuite/libgomp.oacc-fortran/reduction-5.f90: In function 'redsub_combined_._omp_fn.0':
> >     source-gcc/libgomp/testsuite/libgomp.oacc-fortran/reduction-5.f90:73:0: warning: '<anonymous>' is used uninitialized in this function [-Wuninitialized]
> >        !$acc loop reduction(+:sum) gang worker vector
> >     ^
> >     source-gcc/libgomp/testsuite/libgomp.oacc-fortran/reduction-5.f90: In function 'redsub_vector_._omp_fn.1':
> >     source-gcc/libgomp/testsuite/libgomp.oacc-fortran/reduction-5.f90:60:0: warning: '<anonymous>' is used uninitialized in this function [-Wuninitialized]
> >        !$acc loop reduction(+:sum) vector
> >     ^
> >     source-gcc/libgomp/testsuite/libgomp.oacc-fortran/reduction-5.f90: In function 'redsub_worker_._omp_fn.2':
> >     source-gcc/libgomp/testsuite/libgomp.oacc-fortran/reduction-5.f90:47:0: warning: '<anonymous>' is used uninitialized in this function [-Wuninitialized]
> >        !$acc loop reduction(+:sum) worker
> >     ^
> >     source-gcc/libgomp/testsuite/libgomp.oacc-fortran/reduction-5.f90: In function 'redsub_gang_._omp_fn.3':
> >     source-gcc/libgomp/testsuite/libgomp.oacc-fortran/reduction-5.f90:34:0: warning: 'sum.43' may be used uninitialized in this function [-Wmaybe-uninitialized]
> >        !$acc loop reduction(+:sum) gang
> >     ^

I didn't see anyone explicitly claim to have fixed that; however, the
warnings are gone.


Grüße
 Thomas

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]