From: Thomas Schwinge <thomas@codesourcery.com>
To: Jan Hubicka <hubicka@ucw.cz>
Cc: <gcc-patches@gcc.gnu.org>, <dimhen@gmail.com>
Subject: Re: Turn DECL_SECTION_NAME into string
Date: Tue, 17 Jun 2014 06:40:00 -0000 [thread overview]
Message-ID: <87lhswhwdf.fsf@kepler.schwinge.homeip.net> (raw)
In-Reply-To: <20140612043325.GA6864@kam.mff.cuni.cz>
[-- Attachment #1: Type: text/plain, Size: 1563 bytes --]
Hi!
On Thu, 12 Jun 2014 06:33:25 +0200, Jan Hubicka <hubicka@ucw.cz> wrote:
> this lenghtly patch makes the legwork to put section names out of tree representation.
> Originally they were STRING_CST. I ended up implementing on-side reference counted
> string voclabulary that is done in bit baroque way to be GGC and PCH safe (uff).
As reported in <https://gcc.gnu.org/PR61508>, this causes a build failure
with --enable-checking=fold:
/home/dimhen/src/gcc_current/gcc/fold-const.c: In function 'void fold_checksum_tree(const_tree, md5_ctx*, hash_table<pointer_hash<tree_node>)':
/home/dimhen/src/gcc_current/gcc/fold-const.c:14863:55: error: cannot convert 'const char*' to 'const_tree {aka const tree_node*}' for argument '1' to 'void fold_checksum_tree(const_tree, md5_ctx*, hash_table<pointer_hash<tree_node> >)'
fold_checksum_tree (DECL_SECTION_NAME (expr), ctx, ht);
From light testing the following seems to get around this -- is it the
appropriate fix?
diff --git gcc/fold-const.c gcc/fold-const.c
index 24daaa3..978b854 100644
--- gcc/fold-const.c
+++ gcc/fold-const.c
@@ -14859,8 +14859,6 @@ fold_checksum_tree (const_tree expr, struct md5_ctx *ctx,
fold_checksum_tree (DECL_ABSTRACT_ORIGIN (expr), ctx, ht);
fold_checksum_tree (DECL_ATTRIBUTES (expr), ctx, ht);
}
- if (CODE_CONTAINS_STRUCT (TREE_CODE (expr), TS_DECL_WITH_VIS))
- fold_checksum_tree (DECL_SECTION_NAME (expr), ctx, ht);
if (CODE_CONTAINS_STRUCT (TREE_CODE (expr), TS_DECL_NON_COMMON))
{
Grüße,
Thomas
[-- Attachment #2: Type: application/pgp-signature, Size: 472 bytes --]
next prev parent reply other threads:[~2014-06-17 6:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 4:33 Jan Hubicka
2014-06-12 7:52 ` Richard Biener
2014-06-12 8:13 ` Jan Hubicka
2014-06-17 6:40 ` Thomas Schwinge [this message]
2014-06-17 8:19 ` Richard Biener
2014-06-25 1:12 ` [BUILDROBOT] v850 fallout (was: Turn DECL_SECTION_NAME into string) Jan-Benedict Glaw
2014-06-25 5:18 ` Jan Hubicka
2014-06-25 9:21 ` [BUILDROBOT] v850 fallout Nicholas Clifton
2014-06-25 1:16 ` [BUILDROBOT] xtensa fallout (was: Turn DECL_SECTION_NAME into string) Jan-Benedict Glaw
2014-06-25 5:20 ` Jan Hubicka
2014-06-25 15:56 ` augustine.sterling
2014-07-04 21:11 ` Jan-Benedict Glaw
2014-07-10 14:41 ` augustine.sterling
2014-06-25 1:23 ` [BUILDROBOT] frv " Jan-Benedict Glaw
2014-06-25 5:23 ` Jan Hubicka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lhswhwdf.fsf@kepler.schwinge.homeip.net \
--to=thomas@codesourcery.com \
--cc=dimhen@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).