From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 366E23858D28 for ; Fri, 31 Mar 2023 18:45:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 366E23858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org References: <20230314002354.367655-1-sam@gentoo.org> <20230314002354.367655-2-sam@gentoo.org> User-agent: mu4e 1.8.14; emacs 29.0.60 From: Sam James To: Kito Cheng Cc: "juzhe.zhong@rivai.ai" , gcc-patches , palmer , andrew , Jim Wilson , Jeff Law Subject: Re: [PATCH v4 2/2] gcc: Drop obsolete INCLUDE_PTHREAD_H (ping) Date: Fri, 31 Mar 2023 19:44:38 +0100 In-reply-to: Message-ID: <87mt3syd2y.fsf@gentoo.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Kito Cheng writes: > It's not the RISC-V part, so this requires a global maintainer there I th= ink? > Someone able to look at the system.h bit? It should be trivial, there's no uses left and it was added purely for a bug like this in the past (see commit message). > On Tue, Mar 14, 2023 at 8:28=E2=80=AFAM juzhe.zhong@rivai.ai > wrote: >> >> Thank you for fixing this. I am not familiar with this. >> This generator code (genrvv-type-indexer.cc) is written by @kito. >> >> Kito ? Can you take a look at this? >> >> >> juzhe.zhong@rivai.ai >> >> From: Sam James >> Date: 2023-03-14 08:23 >> To: gcc-patches >> CC: Kito Cheng; Palmer Dabbelt; Andrew Waterman; Jim Wilson; Ju-Zhe Zhon= g; Sam James >> Subject: [PATCH v4 2/2] gcc: Drop obsolete INCLUDE_PTHREAD_H >> This is no longer used since 0a62889c7a155f8ed971860d68870dc9c46bb004, so >> let's clean it up. >> >> gcc/ChangeLog: >> * system.h: Drop unused INCLUDE_PTHREAD_H. >> >> Signed-off-by: Sam James >> --- >> gcc/system.h | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/gcc/system.h b/gcc/system.h >> index cf45db3f97e..3fdad7abf1e 100644 >> --- a/gcc/system.h >> +++ b/gcc/system.h >> @@ -761,10 +761,6 @@ extern int vsnprintf (char *, size_t, const char *,= va_list); >> #endif >> #endif >> -#ifdef INCLUDE_PTHREAD_H >> -#include >> -#endif >> - >> #ifdef INCLUDE_ISL >> #ifdef HAVE_isl >> #include >> -- >> 2.40.0 >> >> --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iOUEARYKAI0WIQQlpruI3Zt2TGtVQcJzhAn1IN+RkAUCZCcqRV8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0MjVB NkJCODhERDlCNzY0QzZCNTU0MUMyNzM4NDA5RjUyMERGOTE5MA8cc2FtQGdlbnRv by5vcmcACgkQc4QJ9SDfkZCnZAEAymuQfGLcHg+1HW/OTclXB5yGh5ogKUpOABOu qZ3nViUA+QGY+rhWce9DjSL+gEZQqtAgT2rCHWL1Uq5c9/hnjzcD =vhaX -----END PGP SIGNATURE----- --=-=-=--