From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 9E55A3858C62 for ; Thu, 19 Jan 2023 09:59:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9E55A3858C62 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30ILnVqV005253; Thu, 19 Jan 2023 09:59:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=references : from : to : cc : subject : in-reply-to : date : message-id : content-type : mime-version; s=corp-2022-7-12; bh=83mZlqg7zdShoP91//ElZ6ucw7cJPXKAw1HuM5Ij96c=; b=H7UYTVn24qbpt3DdsDtscHGoagJH9Wdm7QawUpF+xjoLUpsGBcgHMlw+A26KSeKX9BnM 0lFB0evbpsfq15u/sxt3Lkl4spXCovnbU8R+Y04o6ZvPbGoVlk+Hel0t0UtKhpgJosHO xb7ZTEXfYIz2CXMldbuBnymZfwcEyVyvOjGRpQPomelpwmrHDfuJOe1pqQaNePiR15AN YW86QwwH7AYMJGMvmBplp8s7010OHCd2MN9xF18nnFLy2g0EO2wrS7gTmiQ/B05ajNUp rQ2pflBFPQEjO0FRqFjT/AunsHo8MetVd3am7m/EEHUpN8VejWleetMHwtDQbiRwD2lU Zg== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3n3k011shy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 19 Jan 2023 09:59:51 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 30J9kvw8039594; Thu, 19 Jan 2023 09:59:50 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2109.outbound.protection.outlook.com [104.47.70.109]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3n6r2u5fk8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 19 Jan 2023 09:59:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mEOUImjPGcR8jonTJMkhPv6HwE0XjIQnLWXIFr16dltTd5bo5tQdjrSRyznIF42gAgqlcbhSvz8oBg9KYwsew2aM/gfQx+VSTN7o224NirJUov5Svgq+sn6Pl63UvNJreAmipa6BCiQhig8IHfO/+HVLQeUbyR5zqjBaYFFSi+zVYNYXJ6WuWNtPnwen04oPnoYrGjy/S8xWgf6uL9Ats2gz6kuheN8w/S1StSQ0YTN9tMk2jMvMEp5cOeBdE3Z/2fc98CJ9jYKNFwJbBzOSrJgsM3DW3gxpvfC9hI4fNZ0fgDuFGLh0pvs0prSDByAcjTlwGe8iqrFqs05J93qwkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=83mZlqg7zdShoP91//ElZ6ucw7cJPXKAw1HuM5Ij96c=; b=UdZZGDdFIM93V8fKpfQ3oSpN8UDqdru49sQqAAr5/hg8LPT4HufdeSC9+BKLnb6M+/QiqrJrvSibV//eNyeSkFPyqhB3zap5GkHTCDaEprjAxQq/YymMjnZJvgbRyftQKzJy7i3GKv67UF/ZsHG332TsB20WTwG7oNnT74f8POE+5RLAptfg95jlMtkZGPzxAk/PODpU8NV1TvIldPPpblkXdQjUVAVaSOD6l2ntcuBfQp+/hv/hSbETjqMFYZ9QlKPVwY7p/pBE0en6woeXpozTH1Mzz2qyyR0CPJ41w1N3ydh10r4Jq/ScPHdxL6Iz5jpdFl3T9EKsqU2hxvPgRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=83mZlqg7zdShoP91//ElZ6ucw7cJPXKAw1HuM5Ij96c=; b=eNQMuka0uS3uRe6G3+FmDZ1nXzIj7/OUiLh/ducufP107sNmkI9aCvjD6TZ3gHoh2tEXBGjibRgFO3jmeYrw7AZ59SjvyCn2IqekAhatotu9INDsjvbSDm/yeWlhRMpfeIo8UArOojPxxhaIOAG/XALVpWTRxtuKIbG7s5aeJcY= Received: from BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) by CH0PR10MB5290.namprd10.prod.outlook.com (2603:10b6:610:dc::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13; Thu, 19 Jan 2023 09:59:48 +0000 Received: from BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::2b7a:b98b:e12:b750]) by BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::2b7a:b98b:e12:b750%7]) with mapi id 15.20.6002.012; Thu, 19 Jan 2023 09:59:48 +0000 References: <20221202175225.2780-1-cupertino.miranda@oracle.com> <20221202175225.2780-2-cupertino.miranda@oracle.com> <87wn5qzd6l.fsf@oracle.com> User-agent: mu4e 1.4.15; emacs 28.1 From: Cupertino Miranda To: Jeff Law Cc: Richard Biener , jose.marchesi@oracle.com, gcc-patches@gcc.gnu.org Subject: Re: [PATCH 1/2] select .rodata for const volatile variables. In-reply-to: <87wn5qzd6l.fsf@oracle.com> Date: Thu, 19 Jan 2023 09:59:42 +0000 Message-ID: <87mt6eyhdd.fsf@oracle.com> Content-Type: text/plain X-ClientProxiedBy: AM0PR06CA0136.eurprd06.prod.outlook.com (2603:10a6:208:ab::41) To BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN6PR1001MB2340:EE_|CH0PR10MB5290:EE_ X-MS-Office365-Filtering-Correlation-Id: a6848881-36aa-41eb-eb9e-08dafa03e647 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IidrX/R9JGf+DDCgUF6lCcq99IJeSfkBf1hcsVFiytCAN5natUX4h94vVDcd+rei34wgiP3ysgMzVVysJHOcvEQ4FIqZmdnSn+1M80gYvqYJZBn7s0CbYDhaFVb3zFI2PUQwCEd1DUGq4iPY3V87hfadEF7OPuqfYoRe2aYXQXPbP927zNpMIMFjY6BReREicBFqkGFIVEKG2+rRe4Iz4XPi0nc/dZ1+KymNOpbj/jM1RoZcC2esLvw1Nk+UBt2s8qIGn6HH5R6UhniMdiHuSjIPaJFs9RsQOe48r6LU7hJQNBKBMpzo7Y1ve4zNX+M5stJO8orjoTLayulOOUQUsNp/yDJmrBThEcxcNJz1qyIAHNwYwmZJozk0fbHS6YPt2QbwyW1ROI7NweaKDyiHRC3+Mn27frZYYj+mN1Cbr7atWCO6PY9vpzzkuaCRRpQUzWoE4PzQm4+iKeq7iO+/7O1vR99bOnepMuxG1s88o82zNAbV8j0JcF7/VaIPBMfSkS0388wKawN0U0MpnJi+A0qiv3icEVQPzFb2oc/4GQd4Yw8b7duvFosULA4W+u1KskrL68K3QIth4fnulSToAfoVMuXM8x2+wa2PlKX031jd3ksZRqGGy7/cZA1YKaDX4OyxlriqaXXH6Ni3q2qU6Wa/j1PTE/tQXY3sNa6wp1uW1lzyITsUZOl7dM3KMct1 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR1001MB2340.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(346002)(39860400002)(376002)(396003)(451199015)(478600001)(66946007)(4326008)(36756003)(66476007)(86362001)(6916009)(6486002)(186003)(8676002)(2616005)(66556008)(2906002)(38100700002)(6512007)(316002)(83380400001)(44832011)(6666004)(8936002)(41300700001)(5660300002)(6506007)(53546011)(142923001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BYQADgfeCH3ok4IY2/x96fn7PTzhmqkA6qa69+KZae1Z/6qmNTaFIu20c765?= =?us-ascii?Q?DlKouiJaDl4vBlOY2Zhjvbw4AZugLWkS3kecy9gxJ8YE0uP2ipIGXRXwx1mC?= =?us-ascii?Q?zmb/p3MVUeJ9Ldo2WqVefXzWoLS2Hjg0JJK/K0b6uDGQ8QpPKP8uuf9SQvsq?= =?us-ascii?Q?5SDeTHPWnCxkRgTvVLZ1nmDJuMbiYK4+luly9sXR8vjRDT/sLGEFvMW7/zrh?= =?us-ascii?Q?JOISHRbezRrAX55rYAIwU1WMpsv6S8qMkEWFnMNY97fNIo6zPN2TUrSlDOEG?= =?us-ascii?Q?oJRUoKpWrEoijMMyrCjK3feevS1nwSgaNWf/o2kvGuTsqK3O41ZRFnljlJvE?= =?us-ascii?Q?qwHhaJam4i3jEPC0gblaXmQ1SBfJdVH6+jlXpZD49qCceTDDZU53/BLHXY2U?= =?us-ascii?Q?Ihcr8xdLk4EXhQ+Jp9Oh3E6qWjYImrvjvwPMf1BtSR4fcZ59NyFPvV/foIxj?= =?us-ascii?Q?+cchjxuYeZ9uziBuIdDRzGAYlUT6yxoIHFuMWjGjBqWCmAxQXSRQpaJNVD0h?= =?us-ascii?Q?2gAuvZqmPim6thKG5grQaq58UpkPPp1jiekslqycGITQq3y2PabnK9q+B0bB?= =?us-ascii?Q?5GtRqF+EFTmyHHMnjhJ5/OYbcKISMEHj1DqpA0/1C4fYWdCTS1UeSwy7qKXp?= =?us-ascii?Q?PFv0xaewScnindW6jAgPQYLOCUYKO0WDWmLKsLQ98M5WoStDVCw5fNeiTzOY?= =?us-ascii?Q?vjo4ijj1IyhgyxsohMCD+Jyz9UQzt9nu2Xf20b/nLcLJny1skiJ2il0KHpUR?= =?us-ascii?Q?R6RQbLXQD+9wF+NgISrlti3FWff2jpQiLnH9DoltEkOSdr7Kg8LskNN9OEEu?= =?us-ascii?Q?PAAvTneQm979+JqBofykidTVmFE+J7Zf4xAGzybBNli4jgDoCYuo4LkLCEzJ?= =?us-ascii?Q?fGyEpcmrnbfYrNiqtQgGmy4KfVoJrXTWze+Rgin4OcUr6kHIc91Lu9D/lnf8?= =?us-ascii?Q?j0EWm60SMDVdtILgzG+ez5AHfvQs5c8jC9IdOhXhidUJEx+bsdoXBm0kxxA5?= =?us-ascii?Q?9KmHAA+QeEw7VNh6MNAM770jCSVIWGPj+Sm/0ZT60B1n40sGlj5jIwDlyzVT?= =?us-ascii?Q?PvzZ4ztFxMvM8tZXlpZnzCp9a4hFFbHG2lIx+NTzXt/XbUX7jLHeUPuK6yZl?= =?us-ascii?Q?74n6WcmM8mGsNRjwz/yyqhhC5c+2oFt66nGOeq8CbPukocWOs6Om+HCydu2j?= =?us-ascii?Q?4coyKUXtuTgjkxJ2ykqVVWTom95CEIYbdzIYP9HlJxB9OIHnO2oF9KWlQPLk?= =?us-ascii?Q?Inl1tX8BhEnGKUZngeQIis+XayzbYZggYXXUI0SaoRv2993z8fXRJLVgFRke?= =?us-ascii?Q?LANsQqwhP+54ZLou8tmXIplR6DDgMuO/IztIeG7TIfCj7iF0GIleD3qeRWvB?= =?us-ascii?Q?j1S1KLEu7pwvZEFqliD6DcqHhw0SDFiFJAVQlxqtApjVhRNilDz8cc7MChDQ?= =?us-ascii?Q?/j6l6LYfRSCtJdKP1cYdZUMfwhIwC3PJQwavFxJifq7VZ1XGKYLO2Rs0JEfe?= =?us-ascii?Q?N8J7WlGM30EBWi/BOXv5PcZcd79feOOl6ofCMxJxhP8HCpUaw6QlwEGggplL?= =?us-ascii?Q?J7EwKvS6OoBwQSlj/sNwdXTptQbhxMhylffG0JHykpyo0UC9J7ntlprQHhVU?= =?us-ascii?Q?/ga0OcNDiEly9TS4Gm5VK9Y=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: XGWCyJAKk540U8RCOCctSviyu/7gsLNzUbukR9w84B5aeHDjnnKunDG7tdx2byIWFL7MPcwlgrQSKkbdrSrIeJkx7UvSO4kfYU/O9P/M98diWgdovO5IpO4M+NlcLuBBqWydoV8AtKc/11/FNrRF3x1075miXWWyL52gtvQMIHpBIk3df7SVkBbmeQIzer5d4QAzRTy5Wj3OYpdv/NmBVTGb2rL4jc+yFC6cPQKcRVBl3BUSzHbMSDuusq5Q6HfDSQYJppoZP5GxpdgwIuQ6CWiZZnA3Cvsro0hRjw3tOoDwcER+wew+ZAzpyLibaCdIuQU435gtfjqAw/fzi11GzWPq0E6JGvgPeQPQh3Q8TH9twEnLzN+uTDeOf5vW6BuUHn4CPWiVG9/ke31XBJ/9FWPNB16qdtgG/BZQJsrtFhntiGWWehmZCDMInjsW795nEeSyz+zI+bYa5X9z65zBLXUk0MgrHHQYXKjIxwIf+EQObidVvg5Ww5LJ4kYtnyTUTJaLcg10wzjPHCjMy7V980/bQMtx+S6k3/wWOA18N6D6ZskhYTlVc8S/q/TwAcxnJRbrQdk8p05V8AgWyWIdgfG9zLfWDqEUdipa0U359tjaW1gU4X7cXLlcRVJcBSvTwIuGMqffrsnLQBWW3+drP/NcunnxC2LifD9j2DztEPGD/W99sKn9SyQ6J0Ef70GnsNCpEwDcjpRwRbxe1MUnQ6d1bLfpLIeWDKPlVYEx5LeClXWvatFv2PDu9PBIImbx/v0hQt71/nMFyep9nmAxaQ== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: a6848881-36aa-41eb-eb9e-08dafa03e647 X-MS-Exchange-CrossTenant-AuthSource: BN6PR1001MB2340.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2023 09:59:48.5102 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: P4U1C1EXF/Vna4Ex5XObTvGzqfl+HRDkvZHxeAuR16lc/NxytML/2C0qmp5f1xzY3gBobsGCoVVQH3fn8BwoYifGhUWfAdHBakdgjVfIc38= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5290 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-19_07,2023-01-18_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0 phishscore=0 suspectscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301190080 X-Proofpoint-GUID: _Y7cjZ-7sZ7Sl3siHZWXvhid8qfVe8s7 X-Proofpoint-ORIG-GUID: _Y7cjZ-7sZ7Sl3siHZWXvhid8qfVe8s7 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jeff, Kindly calling your attention to this thread. Regards, Cupertino Cupertino Miranda via Gcc-patches writes: > Richard Biener writes: > >> On Mon, Dec 5, 2022 at 7:07 PM Jeff Law via Gcc-patches >> wrote: >>> >>> >>> >>> On 12/2/22 10:52, Cupertino Miranda via Gcc-patches wrote: >>> > Changed target code to select .rodata section for 'const volatile' >>> > defined variables. >>> > This change is in the context of the bugzilla #170181. >>> > >>> > gcc/ChangeLog: >>> > >>> > v850.c(v850_select_section): Changed function. >>> I'm not sure this is safe/correct. ISTM that you need to look at the >>> underlying TREE_TYPE to check for const-volatile rather than >>> TREE_SIDE_EFFECTS. >> >> Just to quote tree.h: >> >> /* In any expression, decl, or constant, nonzero means it has side effects or >> reevaluation of the whole expression could produce a different value. >> This is set if any subexpression is a function call, a side effect or a >> reference to a volatile variable. In a ..._DECL, this is set only if the >> declaration said `volatile'. This will never be set for a constant. */ >> #define TREE_SIDE_EFFECTS(NODE) \ >> (NON_TYPE_CHECK (NODE)->base.side_effects_flag) >> >> so if exp is a decl then that's the volatile check. >> > > Thank you Richard for the review. > Jeff: Can you please let me know if Richard comments reply to your > concerns? > > Cupertino > >>> Of secondary importance is the ChangeLog. Just saying "Changed >>> function" provides no real information. Something like this would be >>> better: >>> >>> * config/v850/v850.c (v850_select_section): Put const volatile >>> objects into read-only sections. >>> >>> >>> Jeff >>> >>> >>> >>> >>> > --- >>> > gcc/config/v850/v850.cc | 1 - >>> > 1 file changed, 1 deletion(-) >>> > >>> > diff --git a/gcc/config/v850/v850.cc b/gcc/config/v850/v850.cc >>> > index c7d432990ab..e66893fede4 100644 >>> > --- a/gcc/config/v850/v850.cc >>> > +++ b/gcc/config/v850/v850.cc >>> > @@ -2865,7 +2865,6 @@ v850_select_section (tree exp, >>> > { >>> > int is_const; >>> > if (!TREE_READONLY (exp) >>> > - || TREE_SIDE_EFFECTS (exp) >>> > || !DECL_INITIAL (exp) >>> > || (DECL_INITIAL (exp) != error_mark_node >>> > && !TREE_CONSTANT (DECL_INITIAL (exp))))