From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id E9AE33858C2D for ; Mon, 2 Jan 2023 10:43:29 +0000 (GMT) Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3020P0kO005461; Mon, 2 Jan 2023 10:43:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=references : from : to : cc : subject : in-reply-to : date : message-id : content-type : mime-version; s=corp-2022-7-12; bh=rtlFnwx7T69lvaQEVJELyR1eqfJCYsYmO9Q5C79dSQM=; b=aBqO9yP9dPrf8lmjE4VzpMruYxWhMxg4tazzAJwzRYaTnSotYonbFq2ifh0O0UNMce+W VR4aBirKqPrRfDteoyKYhRC9A+zu4Ct/sLyApu79JKiDoTXizzLVXGDePXKtubGUlb8T ElhfsIDqN941LElwEAi4r7uglKwvDmlUiLm8NaLPgFVcF6scj/BGU+m6i2wxavFsmJ/X F9tp3NEdIzYpniU6X1+Qd/5vpogzvmT/HCV+FQyA1ik1WnlqMDoUOKp97ay6jZVkurcQ orS/MrAyBQrPdFHRCBdxWGU9Ro1KVCf0L4FRvmU7NR4sknDeNTOYe3h5UQIb267AiamA aQ== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3mtd4c272w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 02 Jan 2023 10:43:29 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 3028E8lm020092; Mon, 2 Jan 2023 10:43:28 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2103.outbound.protection.outlook.com [104.47.58.103]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3mtbh3n5uf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 02 Jan 2023 10:43:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LSNaDVdnrFiAZmwbps6tvwDf1NSaaEgje2EwZ9X39pdlETQzV+kg4OE/YJ+EkD0NAwvFUx1utsX0prMnUFNoQnZvj936Sb79n6f9XIX1ejV0GYW6ifhSuI9nHQOc8u+EilGNzHyUKz2NNd/P/S8JKY8fiaEkuWYcZ8y7WfOCmtgMNvyAJZ9a7OJBqa4BoH9pTDydzQmwnffptMnumUGVipGrkP5EAA7mVb+R2TURMS6oqvN7VmCe775xT5QueSSqdyHaAuWgiYZhRcBRZ7/1NNWZN+etxDTJBgm+Shp6xdopt306273IIDT3AjonbqbtRtf9fj3zVy6kPR+i5+epkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rtlFnwx7T69lvaQEVJELyR1eqfJCYsYmO9Q5C79dSQM=; b=EPrmRbl9uGpasCmk+qi1Al/7a5PaHOCTYlx4V853wQQnZwBTjsyCWcLr+o5MlvXpXUBsic3ZerQhw/xPKypeEzapSBajXS9zUvDdPdPv6u0AL+PNOL+xJQRQs7jRmoY2372GmT8GRMLCYFHJNpgBIs49UKswHda88fZ97nwNbPItNaNXxpbC1r92xuR/gj8NID8ZnN8tkIeSiFaesd10Pm7IULKfxjrJb5RrNgsHiIjSdjjihQpYNH2TPMn0qfS6ytEMZqdNkejM4OaNNgDPcNzrC5gq2ZYpQRgwS/IdXWkQDi0aNyJHqTAsHuHr/hx0fGt0P1TA7NyNPWckvJtJzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rtlFnwx7T69lvaQEVJELyR1eqfJCYsYmO9Q5C79dSQM=; b=dOxN4FrEFCxXvf0mBjz5UD/2iClmrFYEjVDuhjRS+jzOUneYi9YTBFYyKdtUcgS8eqcG6bUg0MpMoSIlV3mxjkG7JsPqWKvc1r0dGMz6i2BhseZw5/qVg1618egI/HGiMLsubXiuAetep5oBk3n54/NYplKHHKA/ZhzhJdkko4U= Received: from BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) by DS7PR10MB5949.namprd10.prod.outlook.com (2603:10b6:8:86::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Mon, 2 Jan 2023 10:43:26 +0000 Received: from BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::8681:5931:e558:2638]) by BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::8681:5931:e558:2638%7]) with mapi id 15.20.5944.019; Mon, 2 Jan 2023 10:43:26 +0000 References: <20221202175225.2780-1-cupertino.miranda@oracle.com> <20221202175225.2780-3-cupertino.miranda@oracle.com> <795fde7f-5bde-d1a5-e790-b15774effd1c@gmail.com> <875yen5ib4.fsf@oracle.com> <87len92cu5.fsf@oracle.com> <87wn6jz743.fsf@oracle.com> User-agent: mu4e 1.4.15; emacs 28.1 From: Cupertino Miranda To: Cupertino Miranda Cc: Jeff Law , jose.marchesi@oracle.com, gcc-patches@gcc.gnu.org Subject: Re: [PING] Re: [PATCH 2/2] Corrected pr25521.c target matching. In-reply-to: <87wn6jz743.fsf@oracle.com> Date: Mon, 02 Jan 2023 10:43:21 +0000 Message-ID: <87mt71nrna.fsf@oracle.com> Content-Type: text/plain X-ClientProxiedBy: LO4P123CA0663.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:316::10) To BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN6PR1001MB2340:EE_|DS7PR10MB5949:EE_ X-MS-Office365-Filtering-Correlation-Id: d53461c8-55ee-45e4-214b-08daecae2ded X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZLOwBR1TBb0Px7lMPTFOujm69tFZZqzDbMTl0WQkw2LUUtHnJ7ErkhRptCD5uLPBz7aO4CwExvOumjPvcp/buQqAhE8LCqaBMDsE6jGnOvSTC8QOG5vE8leKdXQggO7PrHKfCX/6mnbqSVVH9BYg+9yPcyKBmPgzAXzjc5DQ+cGn224YXuJNr6QOHeeePLAZQFzZ4uHi6bRW1KRPEoLtFcSRxn6BbE63VrBF1WFMiGCzsZG15/p1X+EmeO64G97bSRy5+gvga28o7DGd7FzZITXasP8Q8y3OFGbf09Agh3vTAiwbXu7Lus+QAzGtavNHTlZy1ToE9HWWs59fjnV1WDiB800o5utIup3aktaNdmJ5eXYFvLP87krIhjwpLdxqtVX6mqX5Xv95eWQl98mSU2cnScVOG5odGwvuz0i5a1tJUzQiQ1i1fHDqb/RR1vpz50IwGTRA2lxN8QpNaP52dgyYdA+GZMyw/0uUE6MnIPByjwzdS+yMZ3idYxM05h0qPxhE/gYoIOk3Dc5z1/ow5uk0u7BD6FmNmfNw3q2NWVfGHqMI1PVQmJSV0oD/rXwb0nhFWhRwPc/0fsvla3sLKXTDpUDVzvxZ0d8u6q+LE3tJgwy9W1ORGXqN5hEQOps4Ns5GB6B4dTF4U+UjyOxEKN6v1bZKtpP3OI6Gv+Gr9cH9AsLBgKvXf9VBhLweA7M8 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR1001MB2340.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(376002)(136003)(396003)(366004)(39860400002)(451199015)(186003)(6512007)(83380400001)(2616005)(44832011)(86362001)(36756003)(38100700002)(66556008)(316002)(2906002)(37006003)(6862004)(4326008)(66946007)(41300700001)(8936002)(5660300002)(8676002)(66476007)(478600001)(6666004)(6486002)(53546011)(6200100001)(6506007)(22166006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nsa9xxmKABhj+0HODOuyX6188LDXBYKZvYwieI+nCk7rPcrMbR6RvfAjS0l7?= =?us-ascii?Q?pCt1B5QAqvEycIdQlHyJ2GeUAan5rW4sIewQWyjLyUxFjvJPyJ9FcGBdxWke?= =?us-ascii?Q?7zLOLGRzlzqMVtlddhWsb+1B9mz6jtzmOGqmvquHQHn93OdGr+tr56y+s98v?= =?us-ascii?Q?fs9EUN1ucMgiPdlleUlaoOnutZwY8+z4LJLCSNoRpofGJB05gx+U6TwFXMcD?= =?us-ascii?Q?XrZE1JpBuEEN60vwhlu7BYfJrPidX+a7uhKg9uVXHvzh8rkXP9regqzonqIZ?= =?us-ascii?Q?gf7VbazHbHvkyGRgEHIfH2ReVN5q0YgChmX+IFdqNlDxOyoRMnsMLQdoly74?= =?us-ascii?Q?U2rAE+gVOxDx3LHlv+4G09ZzJSYkS9UPNo/CTS8sQHD+ZLlR9NRg/3TTvaYW?= =?us-ascii?Q?X6kV/kBLHusnIpKjGANFZHzek6hkwwv9u084jUA+dBKqOarPlRRWYEjppP1a?= =?us-ascii?Q?/Uh9sZznLhEtUj/H51Yh/u1rvGAWZgqQU2H/9l2rnCnhZrgwnMF6E+BvCMD0?= =?us-ascii?Q?jQyPSuJ9+cKizUv+vSDSzMxKolN6fbSk4otEHRAoGzb0I04P6FUHa91IfTEh?= =?us-ascii?Q?PSHqs0hHe8OlU0xp+ugtF9v2MKJIPmYt/lbGMg1GVosrGWDtQf13c/BQCX5q?= =?us-ascii?Q?AhhaFEZkJ14ZePsCMuiQaTQPBW2ebQAAdbSbuurb7A/qGoeX5c43DAaeg20H?= =?us-ascii?Q?Af71A5W+MIpxjpBwDseLque9naiSQ1jOckCrxZz2v4pEcK7mfSrTWDjzp0i3?= =?us-ascii?Q?11J/yhAYgwJhsNvU+7TlWamd/1v0e7LO96amXp/JlC5vng1rFkTO92xWPIZC?= =?us-ascii?Q?77iIhyroY8+Me8coDZFZ2zfrEH5AJ50gwQaVoawL0vJqWuQqTLflsfoJEI12?= =?us-ascii?Q?F434kp1skWq090nkj8xuv8L2skinJzeigV7+KKAFXrCl6CnKD+9NAl1/Jieq?= =?us-ascii?Q?gaS62nCNAflb8BsoZovDZGs15PLoMVERlbtAiHEGUF/IBb/f6M+3UJs3rkrh?= =?us-ascii?Q?pk4QtLvZBv3onSKgqHKaEZv4xfVhpupNRCtlod/tuigX9V6+qwmeH1sstHJY?= =?us-ascii?Q?pukr6eL8+n8Fm+LLASdZprHAH0y7/WEzGCTuRq5etR376CTZGduXaVMwI6LH?= =?us-ascii?Q?DYbtBSzAVUyKgIRKztH99OvMDIBwpJcUf40dLGoi/mzrlAjix8LHHwUcuYbK?= =?us-ascii?Q?wzVtAIAw72eLDRsdSn2D0Ork/D/BGHDJ6Dx6LbQ826euVylfF512paMyW4Y6?= =?us-ascii?Q?hRmSPkiqwvdc/KoGC/QpIpq4segxBs3yx+WjWQJusBlznsoPUTbByGJTq8HY?= =?us-ascii?Q?ZCdW4OXQNm4qTiQ4x99gCKfMZLt+t0/jNAlubHQJnA8iX8/KHTloK9keidL5?= =?us-ascii?Q?AEYYQgIRgyoGgRApl3nbXxZIi+JBZnQx0KCKi1TsMqoYTDczjXrkGPJIMHpI?= =?us-ascii?Q?E2aq/h5q4pZni1Kx0AtoODo1gE36wjktfEco0xPpEJmasladTYIaotTFD0+y?= =?us-ascii?Q?YZ0t8aowIVPpm0n68eDGCwUBeRPPfAsWUFaW4/JRc6qzadM7KsKc5nvzta3z?= =?us-ascii?Q?l2ZqgYSYyNNNROOZNiIqJeZ7d93/e1GywpYSazxYaZ2sXvxACkK9A4ATAmrk?= =?us-ascii?Q?O0dvSWKfL9ZnAb6TlRGRvig=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: d53461c8-55ee-45e4-214b-08daecae2ded X-MS-Exchange-CrossTenant-AuthSource: BN6PR1001MB2340.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jan 2023 10:43:26.7045 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iiWveOwF9Pn92ytJDDC58jCGa2nlQ57OSYX3zZyVzn5GqFAVmQZVZTTAy9uoLFh24/InXA2Jf/n72FuCXgrYRSFe6f8IvX9U5uidWE45YmQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5949 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-02_06,2022-12-30_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 suspectscore=0 malwarescore=0 mlxscore=0 spamscore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301020097 X-Proofpoint-GUID: U_fqqwCjNI5sBaXjvyd1POgODllZw4cg X-Proofpoint-ORIG-GUID: U_fqqwCjNI5sBaXjvyd1POgODllZw4cg X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: PING PING Cupertino Miranda writes: > Cupertino Miranda via Gcc-patches writes: > >> gentle ping >> >> Cupertino Miranda writes: >> >>>> On 12/2/22 10:52, Cupertino Miranda via Gcc-patches wrote: >>>>> This commit is a follow up of bugzilla #107181. >>>>> The commit /a0aafbc/ changed the default implementation of the >>>>> SELECT_SECTION hook in order to match clang/llvm behaviour w.r.t the >>>>> placement of `const volatile' objects. >>>>> However, the following targets use target-specific selection functions >>>>> and they choke on the testcase pr25521.c: >>>>> *rx - target sets its const variables as '.section C,"a",@progbits'. >>>> That's presumably a constant section. We should instead twiddle the test to >>>> recognize that section. >>> >>> Although @progbits is indeed a constant section, I believe it is >>> more interesting to detect if the `rx' starts selecting more >>> standard sections instead of the current @progbits. >>> That was the reason why I opted to XFAIL instead of PASSing it. >>> Can I keep it as such ? >>> >>>> >>>>> *powerpc - its 32bit version is eager to allocate globals in .sdata >>>>> sections. >>>>> Normally, one can expect for the variable to be allocated in .srodata, >>>>> however, in case of powerpc-*-* or powerpc64-*-* (with -m32) >>>>> 'targetm.have_srodata_section == false' and the code in >>>>> categorize_decl_for_section(varasm.cc), forces it to allocate in .sdata. >>>>> /* If the target uses small data sections, select it. */ >>>>> else if (targetm.in_small_data_p (decl)) >>>>> { >>>>> if (ret == SECCAT_BSS) >>>>> ret = SECCAT_SBSS; >>>>> else if targetm.have_srodata_section && ret == SECCAT_RODATA) >>>>> ret = SECCAT_SRODATA; >>>>> else >>>>> ret = SECCAT_SDATA; >>>>> } >>>> I'd just skip the test for 32bit ppc. There should be suitable effective-target >>>> tests you can use. >>>> >>>> jeff