From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 83FF13858294 for ; Fri, 5 Aug 2022 15:44:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 83FF13858294 Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 275FYG0b019827 for ; Fri, 5 Aug 2022 15:44:26 GMT Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3hmw6tr4ww-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 05 Aug 2022 15:44:26 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 275FQdCq000972 for ; Fri, 5 Aug 2022 15:44:25 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2168.outbound.protection.outlook.com [104.47.58.168]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3hp57ub51s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 05 Aug 2022 15:44:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bP/bTT0XSMMlKzKdHGkTYA8OZcVqMJFr65p/S6I99jV2lps/x5iLsAk+5aWQWK3Bez1Y1jWT78Gl5S+FV6dARUJ3tLpjraWkNSdUEtn0p+S7GHtQTNgCpkf7ynSCEQkgaRiiAD68wTQ0NNQvXxwtlob7F4gygI7wTYpTbJdF1X7YV8nOrDVnYagUgcCvYtd514liuWxx74kBHUJ7ZYdlXu3tRj8rmdi632oa6oTaWgN6yIQRwTf4nbBz4FeYGAk0dgKZnvlHIBiyl4AjNoC8+WNV1qNraKd/UZBO7HlruUVncU7GjWwGYvGbeNToWofMZc6iyMqkl2U03nnUh9IkNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+7G8W/YMgGoPdTRsEpLY6oV+dna8RHaUIttwxbhvCfg=; b=SswRz0Qf4EL/13mKwXIyDUzRWHOXxjbpEedTquVMXcqu6T5QZT3RNCIneOCmFJjEgqI6CmHqFgFLNylBzzS23bN0Zx3udsOspt8Guqq8AGRPMKqAJzEsxSWASKxIMrDcTOXWz5XwrEWO+a41cJYR672WG8RcRmfcl3g5KMMFi6A+FlcRiaD8Kk1jV+/bQ8YUgSNKBqFlwT2pVJx5X+IhJmofIw2AGsxZGSfHTLV9Z1L3g4O0MQoEcZShst+HfjrkqdVzlQEp36AD0jdoT2upf/RTHWQ8xBzgI1SftwMnFNlyEZG9bG94Hp1bf0oMPm7rovhpSSkB3AmWMSjFN5eiIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by DM6PR10MB3355.namprd10.prod.outlook.com (2603:10b6:5:1aa::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.14; Fri, 5 Aug 2022 15:44:23 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::b5ee:262a:b151:2fdd]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::b5ee:262a:b151:2fdd%4]) with mapi id 15.20.5504.016; Fri, 5 Aug 2022 15:44:23 +0000 From: "Jose E. Marchesi" To: gcc-patches@gcc.gnu.org Subject: [PATCH] Add warning options -W[no-]compare-distinct-pointer-types Date: Fri, 05 Aug 2022 17:44:16 +0200 Message-ID: <87mtciu23z.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO2P265CA0090.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::30) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: db6f6692-0093-49fa-f2e0-08da76f95e74 X-MS-TrafficTypeDiagnostic: DM6PR10MB3355:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 55ARekLCj1QTXGcFlaawF/NuOziArlKz/m6GR/P20up7MgD1CLRkEsriTBJeYz1Rv9UlB6KodIbqLVVbAOyZoPEXZdvlO/03NCJa8cpXsf1GXsvvCqoGETHBEi8bHv3cUfAS56C5CMYDrjtokj1KpcNqa4S85BBNh+qY833my/YWGfxJfKNLZ9l116G+M/8F9iwdGwBhMRaLg/qgQktmKxWNFt/Ely25GCoacla3vH60b78Z1Netq3W4epWuxS7F/2trrUaSDMoAyUvnXIOnFjGh5/soTIpWTsxBVRs/KFOwf+TLJvUyTM5n+Cw9SsRymxb3bNJBBTOExsWe3OsYXaiADOyID4ke9xFni7n5g7qcNo6tnrfSyhyyyjgNypBOeAbwJ9HLGaVNkKk8kzv82I+MSyLMIVxP4LWRUTJZwc33QgF0/5sYlzGrqn2MjNALSHvwdcpmw9WNobqGfz6UNTJD1iExycRhLJEqJkLrZOwTKkWonFvGflrKwdCMU4E01p0Ck59L6yd1ekCIj4q9gf8vLIBHM5JXCm9CEv0DwpJqF+qm5dL4DuXi+FkQsarWfEgMY+OssdsJxgDtdvtj3fnH0U5eLAfOCcKtpgX/1T7I0bbpYX10xZXD2jymUrRdydIbqp+qGHFJV7jP/cUyy0xPBaZ+sjle68Q7pNiblmaFWGOsIhy9H59DGlWShvvMrKEflAMqksxD0Wgq8tjqHGPtX+lhijZx42K0D+ghfv67JmaA9udnd2K77IY4CcCNwQ/q7GQljOC2eVIVwm/xAAx9be1SHrJKMHmG8pwzV5oqkWmOajMA9g7KAIk60GCw X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR10MB2888.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(136003)(39860400002)(396003)(346002)(366004)(376002)(83380400001)(38350700002)(38100700002)(316002)(6916009)(5660300002)(66946007)(66556008)(66476007)(8936002)(6512007)(8676002)(2906002)(26005)(52116002)(186003)(6666004)(2616005)(6506007)(41300700001)(6486002)(478600001)(36756003)(86362001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aVdYWVRpVHpCbjRkVTdiSmMxbllzaldzT3lQQjZHNGtWQmNseldJdmdXMit6?= =?utf-8?B?V0c1OGhZQWtMclN2cFpvK1N5c0R3MjRXdGZwcURxak8xRGI4RUJZd2FVc2tO?= =?utf-8?B?cW5hTzJvV0EvNEdnK3FPVjNqbXFuRGh2TnRuR0Jta0o3VDlVb1pYTTY5ekU4?= =?utf-8?B?cDJnY0JmT1RiN0FZTDNhUmxoZ0JvNGJmTUNBc2kxbXl5bFBwM2ZheHNUcjFh?= =?utf-8?B?RTN6NHRSemUrRHI2VDNNSVd4aHBSemRTeVdaOGxVZnpGeUZpSTVKTDNNRjk1?= =?utf-8?B?enRhRFFpdlQvczNaUEd4K3BHWW5ESUUxaE9FUzFQVzA5Qm9ZQ0dPRjFiRVhl?= =?utf-8?B?U2g2QWxweG1SYjFxTFBKZk1xejhRTkJacjhCV3VubzJXSFlsZCtnWlRnWEkw?= =?utf-8?B?TjhhY2JRT3RudlhMbVpjcFVmMktDV2RxNUtLOEtveGI3WUFDQVV2ZGVoODNm?= =?utf-8?B?YnJXeGRNR3RJZVBCNVE3eTBjTzZrZ1VKU0tuZXBtL1JoU3UrenZGY0M4Yzln?= =?utf-8?B?UG9tdzEybThOYlNJaWI3Z05VclV4RW5sM3VYM1ZpU1ZOSE53MFF5SWFZZzVt?= =?utf-8?B?QW5KUTdjYVdGVHpxU2tZYTVoR3VjS2RIWTMxd2pnMWNXT0Q1RHZaMFcveSsv?= =?utf-8?B?VVlDanh5citQNUx6TGRvMldoNVJRNlJSL05wT2o0QlhsUWtIQ1N1dW5aYnNr?= =?utf-8?B?WDZnanEvcjJZOEthMVI5aEZkTDhZVFEwSTJTdmw3cVBiclp1WjRMTG1ZRW9l?= =?utf-8?B?STZwR0E0YlZvYnM2VnZnK2VIK3d1ZjczRlg0bk84M001L0xKczdYMXdMZFMx?= =?utf-8?B?L045RGJsTWtzUW1MNzdlNC85Y05iK2FuSmt0VUlKT1g5SjRCeWhKdVFDbzB3?= =?utf-8?B?dm9uVjRoekxPZXNmbDdObVVSYnp3KzhkeWQ2TktJdUpTU1AxdjhCZGJWS0Ux?= =?utf-8?B?RitVTngwTmsvRGwwYXo1Qi9la3NSVHZYeENHY1hKR1FKZVRTV0I3Y1ZkUncz?= =?utf-8?B?ZitxWXUxTWQvaW9PZXdlK0UraDNtb0hnUnJvc2RWUEllY2lMRXZIQ2QxcFow?= =?utf-8?B?TEVJdHlTOVpPSWpYaWNRQTNQd3BBWVJhWFYxZTk5UVdZYkFwYWFqcHBMR1BV?= =?utf-8?B?TEFYeGRRSHNNWUFPMzVBK1dmOUoyMjFydkVJNXpvdWlhbHVmNVhwbjF5LzU3?= =?utf-8?B?c1pRbXJCT0dRV3BKVUFtUFZ1MTR3d1RKNE1MZDQ5bnoydHcxcmhSNHJmS3Ur?= =?utf-8?B?QWhvZ0x1SzdmNG1sOWs0YVpkTVFJOVFNRWt5Q3F2eUk1NXJGRHdKWGpUamwz?= =?utf-8?B?UjRqdzVZOW1GczJ6b29OMENBNWJobmVWcVN2b3FQcFdTVVcxRW93ZENhVEZD?= =?utf-8?B?Tko3SWsvNzBDb3I0U1QzSFMwMU1IcVA1SHIxTXVLN0pCRGRpczlEL1U3TW5G?= =?utf-8?B?TXBJL3R0ZzBpSFg2d0lhQ0ZDYjQydUV1VkNIdUF5VURyd1VKNHJkWkowWjIr?= =?utf-8?B?eUkyWEpocWtWbEtMaGJvK1FVYlNiQ3M4MXdCOWZCRm5KTFhBS2UxZmZRUnVV?= =?utf-8?B?U3pwSkpHT2tiWm05WjB6VWU2NW90SGtyT2dkVXpCRHNvbExpK0hqaUNpU1V4?= =?utf-8?B?QytBNUlURmNWV2JwYURSQW53bVlsaXVvazcyRlMxTEczOEp5TGp3UFlEdi9E?= =?utf-8?B?NGxENGxEbnNITlNyd0k4V1BZb29QNzlETjI1ZjhkenlxMTRyOHlKdGpQdkVu?= =?utf-8?B?Rm9xQm5QZUJuUjg0Y3VrcHA0dHRnVGp5ZEpQeXhTZ2VJbm44WWlJZXpTU1B0?= =?utf-8?B?L2pxd3N0MmgxUGlHY095Qmt5U0lkaGltS1VxSlBqM25oRzMwZk95R0c5TkQz?= =?utf-8?B?REpLVmMrL0ZlREVnTXBwOGMxVWtXUW5Zem9sVTFmUTd0YXM0Y0Q4cUh3L0lW?= =?utf-8?B?ZDhXWmVadmVXN0RWWlJ0cHpKTUI4cEU3bkdYQ1phclBpZDk1NnMxRkU1SGhN?= =?utf-8?B?WE92RklmRkVpMXdzU0pUaEV6dk53VFZjbVNWc2JOZHVHTW1aaGNWOGtkZjJ5?= =?utf-8?B?Y1hRK1lxTjJ6Y2VKY0pnM0xLc01lU1czeS8xUUxWeVRFcjZLd1k0YlB5cU1Z?= =?utf-8?B?ak8yZTdNNlI5WU1QSlc2QjRHT0dRRi9GY2ZDMjYzZllLdW9UQkhPVnhydmk3?= =?utf-8?B?YUE9PQ==?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: db6f6692-0093-49fa-f2e0-08da76f95e74 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2022 15:44:23.2815 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: j+soFZCsCIImEvg9VnclJ9YgYClguk97Bajyp0GKXX9EVPVOFiEvoqoch8vPMWCucL7U5W381tCER3r6gLSZUGtGL9PS76LVDs5TACn33Xc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB3355 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-05_07,2022-08-05_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999 adultscore=0 spamscore=0 bulkscore=0 suspectscore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2208050077 X-Proofpoint-GUID: OqcXfdDSM-cKn7RsAR-CeUjrm77rn7rv X-Proofpoint-ORIG-GUID: OqcXfdDSM-cKn7RsAR-CeUjrm77rn7rv X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Aug 2022 15:44:29 -0000 GCC emits pedwarns unconditionally when comparing pointers of different types, for example: int xdp_context (struct xdp_md *xdp) { void *data =3D (void *)(long)xdp->data; __u32 *metadata =3D (void *)(long)xdp->data_meta; __u32 ret; if (metadata + 1 > data) return 0; return 1; } /home/jemarch/foo.c: In function =E2=80=98xdp_context=E2=80=99: /home/jemarch/foo.c:15:20: warning: comparison of distinct pointer types = lacks a cast 15 | if (metadata + 1 > data) | ^ LLVM supports an option -W[no-]compare-distinct-pointer-types that can be used in order to enable or disable the emission of such warnings. It is enabled by default. This patch adds the same options to GCC. Documentation and testsuite updated included. Regtested in x86_64-linu-gnu. No regressions observed. gcc/ChangeLog: PR c/106537 * doc/invoke.texi (Option Summary): Mention -Wcompare-distinct-pointer-types under `Warning Options'. (Warning Options): Document -Wcompare-distinct-pointer-types. gcc/c-family/ChangeLog: PR c/106537 * c.opt (Wcompare-distinct-pointer-types): New option. gcc/c/ChangeLog: PR c/106537 * c-typeck.cc (build_binary_op): Warning on comparing distinct pointer types only when -Wcompare-distinct-pointer-types. gcc/testsuite/ChangeLog: PR c/106537 * gcc.c-torture/compile/pr106537-1.c: New test. * gcc.c-torture/compile/pr106537-2.c: Likewise. * gcc.c-torture/compile/pr106537-3.c: Likewise. --- gcc/c-family/c.opt | 4 ++++ gcc/c/c-typeck.cc | 8 +++++--- gcc/doc/invoke.texi | 6 ++++++ gcc/testsuite/gcc.c-torture/compile/pr106537-1.c | 23 ++++++++++++++++++++= +++ gcc/testsuite/gcc.c-torture/compile/pr106537-2.c | 21 ++++++++++++++++++++= + gcc/testsuite/gcc.c-torture/compile/pr106537-3.c | 21 ++++++++++++++++++++= + 6 files changed, 80 insertions(+), 3 deletions(-) create mode 100644 gcc/testsuite/gcc.c-torture/compile/pr106537-1.c create mode 100644 gcc/testsuite/gcc.c-torture/compile/pr106537-2.c create mode 100644 gcc/testsuite/gcc.c-torture/compile/pr106537-3.c diff --git a/gcc/c-family/c.opt b/gcc/c-family/c.opt index 44e1a60ce24..54e08e83eb2 100644 --- a/gcc/c-family/c.opt +++ b/gcc/c-family/c.opt @@ -1844,6 +1844,10 @@ Winvalid-imported-macros C++ ObjC++ Var(warn_imported_macros) Warning Warn about macros that have conflicting header units definitions. =20 +Wcompare-distinct-pointer-types +C C++ Var(warn_compare_distinct_pointer_types) Warning Init(1) +Warn if pointers of distinct types are compared without a cast. + flang-info-include-translate C++ Var(note_include_translate_yes) Note #include directives translated to import declarations. diff --git a/gcc/c/c-typeck.cc b/gcc/c/c-typeck.cc index 8514488b7a5..40a66530586 100644 --- a/gcc/c/c-typeck.cc +++ b/gcc/c/c-typeck.cc @@ -12397,7 +12397,8 @@ build_binary_op (location_t location, enum tree_cod= e code, } else /* Avoid warning about the volatile ObjC EH puts on decls. */ - if (!objc_ok) + if (!objc_ok + && warn_compare_distinct_pointer_types) pedwarn (location, 0, "comparison of distinct pointer types lacks a cast"); =20 @@ -12517,8 +12518,9 @@ build_binary_op (location_t location, enum tree_cod= e code, int qual =3D ENCODE_QUAL_ADDR_SPACE (as_common); result_type =3D build_pointer_type (build_qualified_type (void_type_node, qual)); - pedwarn (location, 0, - "comparison of distinct pointer types lacks a cast"); + if (warn_compare_distinct_pointer_types) + pedwarn (location, 0, + "comparison of distinct pointer types lacks a cas= t"); } } else if (code0 =3D=3D POINTER_TYPE && null_pointer_constant_p (orig_= op1)) diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index 863580b3710..a4a594a336d 100644 --- a/gcc/doc/invoke.texi +++ b/gcc/doc/invoke.texi @@ -341,6 +341,7 @@ Objective-C and Objective-C++ Dialects}. -Wcast-align -Wcast-align=3Dstrict -Wcast-function-type -Wcast-qual @g= ol -Wchar-subscripts @gol -Wclobbered -Wcomment @gol +-Wcompare-distinct-pointer-types @gol -Wconversion -Wno-coverage-mismatch -Wno-cpp @gol -Wdangling-else -Wdangling-pointer -Wdangling-pointer=3D@var{n} @gol -Wdate-time @gol @@ -8629,6 +8630,11 @@ programs. Warn for variables that might be changed by @code{longjmp} or @code{vfork}. This warning is also enabled by @option{-Wextra}. =20 +@item -Wcompare-distinct-pointer-types +@opindex Wcompare-distinct-pointer-types +Warn if pointers of distinct types are compared without a cast. This +warning is enabled by default. + @item -Wconversion @opindex Wconversion @opindex Wno-conversion diff --git a/gcc/testsuite/gcc.c-torture/compile/pr106537-1.c b/gcc/testsui= te/gcc.c-torture/compile/pr106537-1.c new file mode 100644 index 00000000000..56c8deeb4fe --- /dev/null +++ b/gcc/testsuite/gcc.c-torture/compile/pr106537-1.c @@ -0,0 +1,23 @@ +/* { dg-do compile } + { dg-options "" } + This testcase checks that warn_compare_distinct_pointer_types is enable= d by + default. */ + +typedef int __u32; + +struct xdp_md +{ + char *data; + char *data_meta; +}; + +int xdp_context (struct xdp_md *xdp) +{ + void *data =3D (void *)(long)xdp->data; + __u32 *metadata =3D (void *)(long)xdp->data_meta; + __u32 ret; + + if (metadata + 1 > data) /* { dg-warning "comparison of distinct pointer= types" } */ + return 0; + return 1; +} diff --git a/gcc/testsuite/gcc.c-torture/compile/pr106537-2.c b/gcc/testsui= te/gcc.c-torture/compile/pr106537-2.c new file mode 100644 index 00000000000..7a9b2aec0b8 --- /dev/null +++ b/gcc/testsuite/gcc.c-torture/compile/pr106537-2.c @@ -0,0 +1,21 @@ +/* { dg-do compile } */ +/* { dg-options "-Wcompare-distinct-pointer-types" } */ + +typedef int __u32; + +struct xdp_md +{ + char *data; + char *data_meta; +}; + +int xdp_context (struct xdp_md *xdp) +{ + void *data =3D (void *)(long)xdp->data; + __u32 *metadata =3D (void *)(long)xdp->data_meta; + __u32 ret; + + if (metadata + 1 > data) /* { dg-warning "comparison of distinct pointer= types" } */ + return 0; + return 1; +} diff --git a/gcc/testsuite/gcc.c-torture/compile/pr106537-3.c b/gcc/testsui= te/gcc.c-torture/compile/pr106537-3.c new file mode 100644 index 00000000000..dc5dd46e3cb --- /dev/null +++ b/gcc/testsuite/gcc.c-torture/compile/pr106537-3.c @@ -0,0 +1,21 @@ +/* { dg-do compile } */ +/* { dg-options "-Wno-compare-distinct-pointer-types" } */ + +typedef int __u32; + +struct xdp_md +{ + char *data; + char *data_meta; +}; + +int xdp_context (struct xdp_md *xdp) +{ + void *data =3D (void *)(long)xdp->data; + __u32 *metadata =3D (void *)(long)xdp->data_meta; + __u32 ret; + + if (metadata + 1 > data) /* There shouldn't be a warning here. */ + return 0; + return 1; +} --=20 2.11.0