From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 8617F383B7B4 for ; Fri, 27 May 2022 19:16:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8617F383B7B4 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.91,256,1647331200"; d="scan'208";a="76346664" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa3.mentor.iphmx.com with ESMTP; 27 May 2022 11:16:34 -0800 IronPort-SDR: n90/s+ctkzAoJ7Lnet0dwsgtWMQSKq41YkkwQov2+stgE1Gjyfw09kCtDM43cjWVN474GlyoxU U0PmDk4IENRtbztDuA3tNix36sJMAjii4YCmehM4wQA0xZtSP7oPFz6vyGG9QN8L1+Ndpay09I oDRe4DKVf5co7ENkCnhAIEfNOibra/NqUMAdRNaIwyEw8Gji6CnLqgs2tAZw9D7i7DZstKTeoG 0gLh2ay+sQzUknlFx13FcVmt6I3J1CPWZ3BInWvww7OA5kmDH5hrAVtfcLdmxmJynEhG99dJ0w Nh4= From: Thomas Schwinge To: Andrew Stubbs CC: , Richard Earnshaw Subject: Re: [committed] amdgcn: Remove LLVM 9 assembler/linker support In-Reply-To: <76a30f1f-661e-7c6f-9ba0-ab68a11dde15@codesourcery.com> References: <76a30f1f-661e-7c6f-9ba0-ab68a11dde15@codesourcery.com> User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/27.1 (x86_64-pc-linux-gnu) Date: Fri, 27 May 2022 21:16:22 +0200 Message-ID: <87mtf2rdkp.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-06.mgc.mentorg.com (139.181.222.6) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 May 2022 19:16:44 -0000 Hi Andrew! On 2022-05-24T16:27:52+0100, Andrew Stubbs wrote: > I've committed this patch to set the minimum required LLVM version, for > the assembler and linker, to 13.0.1. An upgrade from LLVM 9 is a > prerequisite for the gfx90a support, and 13.0.1 is now the oldest > version not known to have compatibility issues. > > The patch removes all the obsolete feature detection tests from > configure and adds a new version test. Likewise the version dependencies > in the backend are removed. I've not otherwise reviewed your commit r13-742-g8086230e7ac619c0b0eeb6e15df7975ac214725f "amdgcn: Remove LLVM 9 assembler/linker support", but happened to notice that your commit also removed the ARM-target 'HAVE_GAS_ARM_EXTENDED_ARCH' -- is that intentional; I suppose not? That had been added by Richard Earnshaw in commit r12-3725-g4e7a92c0ff3871d955ca8fb133f869b216d7224d "arm: pass architecture extensions to assembler if supported". > --- a/gcc/config.in > +++ b/gcc/config.in > -/* Define if your Arm assembler permits context-specific feature extensi= ons. > - */ > -#ifndef USED_FOR_TARGET > -#undef HAVE_GAS_ARM_EXTENDED_ARCH > -#endif > - > - > --- a/gcc/configure > +++ b/gcc/configure > case "$target" in > amdgcn-* | gcn-*) > [...] > ;; > - arm*) > - { $as_echo "$as_me:${as_lineno-$LINENO}: checking assembler for asse= mbler for arm accepts context-specific architecture extensions" >&5 > -$as_echo_n "checking assembler for assembler for arm accepts context-spe= cific architecture extensions... " >&6; } > -if ${gcc_cv_as_arm_option_extensions+:} false; then : > - $as_echo_n "(cached) " >&6 > -else > - gcc_cv_as_arm_option_extensions=3Dno > - if test x$gcc_cv_as !=3D x; then > - $as_echo '.text > - .thumb > - .syntax unified > - vmov.f32 s0, s1' > conftest.s > - if { ac_try=3D'$gcc_cv_as $gcc_cv_as_flags -march=3Darmv8.1-m.main+m= ve -o conftest.o conftest.s >&5' > - { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5 > - (eval $ac_try) 2>&5 > - ac_status=3D$? > - $as_echo "$as_me:${as_lineno-$LINENO}: \$? =3D $ac_status" >&5 > - test $ac_status =3D 0; }; } > - then > - gcc_cv_as_arm_option_extensions=3Dyes > - else > - echo "configure: failed program was" >&5 > - cat conftest.s >&5 > - fi > - rm -f conftest.o conftest.s > - fi > -fi > -{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $gcc_cv_as_arm_option_e= xtensions" >&5 > -$as_echo "$gcc_cv_as_arm_option_extensions" >&6; } > -if test $gcc_cv_as_arm_option_extensions =3D yes; then > - > -$as_echo "#define HAVE_GAS_ARM_EXTENDED_ARCH 1" >>confdefs.h > - > -fi > - > esac > --- a/gcc/configure.ac > +++ b/gcc/configure.ac > case "$target" in > amdgcn-* | gcn-*) > [...] > ;; > - arm*) > - gcc_GAS_CHECK_FEATURE([assembler for arm accepts context-specific ar= chitecture extensions], > - gcc_cv_as_arm_option_extensions, > - [-march=3Darmv8.1-m.main+mve], > - [.text > - .thumb > - .syntax unified > - vmov.f32 s0, s1],, > - [AC_DEFINE(HAVE_GAS_ARM_EXTENDED_ARCH, 1, > - [Define if your Arm assembler permits context-specific feature ex= tensions.])]) > esac Gr=C3=BC=C3=9Fe Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955