Re: [Patch] libgomp: Fix on_device_arch.c aux-file handling [PR99555]

[Thomas Schwinge <thomas@codesourcery.com>]

Hi!

On 2021-03-26T16:22:20+0100, Jakub Jelinek <jakub@redhat.com> wrote:
> On Fri, Mar 26, 2021 at 04:19:56PM +0100, Tobias Burnus wrote:
>> On 26.03.21 15:46, Jakub Jelinek via Gcc-patches wrote:
>> > On Fri, Mar 26, 2021 at 03:42:22PM +0100, Tobias Burnus wrote:
>> > > How about the following patch? It moves the aux function to libgomp.c-c++-common/on_device_arch.c
>> > > and #includes it in the new wrapper files libgomp.{c,fortran}/on_device_arch.c.
>> > > (Based on the observation that #include with relative paths always works,
>> > > while dg-additional-sources may not, depending how the testsuite it run.) [...]

I didn't know that 'dg-additional-sources' had such issues.

>> > For C/C++, why do we call it on_device_arch.c at all?  Can't be just
>> > on_device_arch.h that is #included in each test instead of additional
>> > sources?  If we don't like inlining, just use noinline attribute, but I
>> > don't see why inlining would hurt.
>> > For Fortran, sure, we can't include it, so let's add
>> > libgomp.fortran/on_device_arch.c that #includes that header.

No strong opinion on my side -- I simply did the same for C/C++/Fortran.

>> OK?
>
> LGTM, but please give Thomas a chance to chime in.

ACK, thanks.


And, I hope you did appreciate that I used OpenMP 'declare variant' for
this.  :-)


Grüße
 Thomas
-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 München Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Frank Thürauf