From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id BF764385BF9D for ; Mon, 29 Mar 2021 09:10:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BF764385BF9D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Thomas_Schwinge@mentor.com IronPort-SDR: Au7lP65/HZCQHBxXfxIzjf6JXMuEjrIAOKN+xp0JCuUGrjtgZl4YBR0cpreiylKN5VucoRzEZf QegDr2eDpu0rqolDmkztVbo0nAK5JcjKFwn5PL7Gb8zqMlwfhH7HFpqRZYAYNDVXw1ASbtojuN 9D69Sz7W+0F0gGLWvIraTmLddzlcAuTtcsksqqk4uOJlgroJv9OymAAu0qO6KmNBcLv/Pp1J2z hy6eCkC29cOA2Z/jCJDLnDRNXV7w0vny/x2LUAS+Dj81Bkw64SCH1xcUQc/q9nGc4qe7k2vbdv 5Fs= X-IronPort-AV: E=Sophos;i="5.81,287,1610438400"; d="scan'208";a="59569414" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa2.mentor.iphmx.com with ESMTP; 29 Mar 2021 01:10:05 -0800 IronPort-SDR: OJXM06BU0KfqBaKquOI3ibuyxhknfCDMMBpfjQ9V+Eu/f0PpoUR22BCOcLht/3GX9qgOguzEpN 9KpGdRQCzPs0zp7dtwzlkoIlkHPHbJu2Z8dBQYz56d/EjAekayHaSTMDS1+I/h9RNKP91uNVDe JDcNlDD/+aq9rB7OGhikd+LYKmuYAwegnI/vON5NTiYb76FtMWsHLLZUewe28aqpMyrfkTIkyo t0FOCXOsa30mf2C67yNTHU4qozRWHy/KQMoZ3p8OrhFoRqHXGPLZ215gf3FwNKNVyQDD4avxTr 5+0= From: Thomas Schwinge To: Jakub Jelinek , Tobias Burnus CC: Subject: Re: [Patch] libgomp: Fix on_device_arch.c aux-file handling [PR99555] In-Reply-To: <20210326152220.GV1179226@tucnak> References: <20210129150317.GN4020736@tucnak> <0aca6daf-356a-7b03-c007-e33c35114356@codesourcery.com> <20210223215238.GU4020736@tucnak> <87zgz9zl7c.fsf@euler.schwinge.homeip.net> <874kgzzbjs.fsf@euler.schwinge.homeip.net> <143deda2-a0d7-784e-8eb7-f40e2176bb62@codesourcery.com> <20210326144620.GU1179226@tucnak> <490229f4-02da-955a-052f-b7f35393e555@mentor.com> <20210326152220.GV1179226@tucnak> User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/27.1 (x86_64-pc-linux-gnu) Date: Mon, 29 Mar 2021 11:09:51 +0200 Message-ID: <87mtum497k.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-02.mgc.mentorg.com (139.181.222.2) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Mar 2021 09:10:08 -0000 Hi! On 2021-03-26T16:22:20+0100, Jakub Jelinek wrote: > On Fri, Mar 26, 2021 at 04:19:56PM +0100, Tobias Burnus wrote: >> On 26.03.21 15:46, Jakub Jelinek via Gcc-patches wrote: >> > On Fri, Mar 26, 2021 at 03:42:22PM +0100, Tobias Burnus wrote: >> > > How about the following patch? It moves the aux function to libgomp.= c-c++-common/on_device_arch.c >> > > and #includes it in the new wrapper files libgomp.{c,fortran}/on_dev= ice_arch.c. >> > > (Based on the observation that #include with relative paths always w= orks, >> > > while dg-additional-sources may not, depending how the testsuite it = run.) [...] I didn't know that 'dg-additional-sources' had such issues. >> > For C/C++, why do we call it on_device_arch.c at all? Can't be just >> > on_device_arch.h that is #included in each test instead of additional >> > sources? If we don't like inlining, just use noinline attribute, but = I >> > don't see why inlining would hurt. >> > For Fortran, sure, we can't include it, so let's add >> > libgomp.fortran/on_device_arch.c that #includes that header. No strong opinion on my side -- I simply did the same for C/C++/Fortran. >> OK? > > LGTM, but please give Thomas a chance to chime in. ACK, thanks. And, I hope you did appreciate that I used OpenMP 'declare variant' for this. :-) Gr=C3=BC=C3=9Fe Thomas ----------------- Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 M=C3=BCnchen R= egistergericht M=C3=BCnchen HRB 106955, Gesch=C3=A4ftsf=C3=BChrer: Thomas H= eurung, Frank Th=C3=BCrauf