From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41297 invoked by alias); 23 Sep 2015 14:16:20 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 41083 invoked by uid 89); 23 Sep 2015 14:16:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Sep 2015 14:16:17 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1ZekqE-0000en-0K from Thomas_Schwinge@mentor.com for gcc-patches@gcc.gnu.org; Wed, 23 Sep 2015 07:16:14 -0700 Received: from feldtkeller.schwinge.homeip.net (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.224.2; Wed, 23 Sep 2015 15:16:12 +0100 From: Thomas Schwinge To: Nathan Sidwell CC: Cesar Philippidis , GCC Patches Subject: Re: [gomp4] lock/unlock internal fn In-Reply-To: <56029DD3.7020703@codesourcery.com> References: <55D23648.5000600@acm.org> <874milzdsb.fsf@kepler.schwinge.homeip.net> <56029DD3.7020703@codesourcery.com> User-Agent: Notmuch/0.9-125-g4686d11 (http://notmuchmail.org) Emacs/24.5.1 (i586-pc-linux-gnu) Date: Wed, 23 Sep 2015 14:49:00 -0000 Message-ID: <87mvwdxlug.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-SW-Source: 2015-09/txt/msg01755.txt.bz2 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 1516 Hi Nathan! On Wed, 23 Sep 2015 08:40:51 -0400, Nathan Sidwell wrote: > On 09/23/15 05:27, Thomas Schwinge wrote: > > On Mon, 17 Aug 2015 15:30:16 -0400, Nathan Sidwell wro= te: > >> I've committed this patch to add a new pair of internal functions. Th= ese will > >> be used in implementing reductions. > >> > >> They'll be emitted around reduction finalization, and implement the lo= cking > >> required for the general case of combining reduction values. They may= be > >> transformed in the oacc_xform pass, and the default behaviour is to de= lete them, > >> if there is no RTL expander. For PTX we delete them if they are at th= e vector > >> level. > >> > >> This avoids needing machine-specific builtins to expand to, and thus s= hould > >> result in less backend code duplication. > > > > With the __builtin_nvptx_lock and __builtin_nvptx_unlock builtins > > removed, should the gcc.target/nvptx/spinlock-1.c and > > gcc.target/nvptx/spinlock-2.c test cases then be removed, too, or should > > these be re-written differently? >=20 > confused. I don't think I remoced those locks. Certainly didn't intend = to, and=20 > I would have expected massive test fails if I had. You didn't remove the functionality, but you did remove the __builtin_nvptx_lock and __builtin_nvptx_unlock builtins (which the two test cases were written for), replacing them with GOACC_LOCK/GOACC_UNLOCK internal functions, nvptx_expand_oacc_lock_unlock. Gr=C3=BC=C3=9Fe, Thomas --=-=-= Content-Type: application/pgp-signature; name="signature.asc" Content-length: 472 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJWArQnAAoJEK3/DN1sMFFtO8cH/RG6Yo/4/8nuCoyrkbE1WexP QUWYW7YJ3k6tq94ZBEJD8g4dhmw30Y7ef//p8tu1CrcVxotT7MONRZwX6jGWhpuj aimLSw5Oq7apqbfi0lNCyLqbRZDksQ9j/TRqreghrN0xCYyt8A6i65YyMPp7bjGw 7tr4ElzYERhEAKMh6dMO/LM1MiOqnaZ2F5umOX8VObIqptIl+Ty5H5aY46wrexVR zZjpP9d0Gt1bdoNzgZ93n9f6fqSk/10Wkc+8n+t2/uWTy/5mxZKJtQI5sqR0U74M jy+CkAB87CTSbLiIGhp8D9efgP1HTwLclj4i+RiMgj1w1eOgywCtd49RkWBWsJE= =gAVb -----END PGP SIGNATURE----- --=-=-=--