From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124234 invoked by alias); 17 Sep 2015 19:32:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 124219 invoked by uid 89); 17 Sep 2015 19:32:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (207.82.80.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 Sep 2015 19:31:58 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-36-7wagl7C8So64fXTE5uZHDw-1; Thu, 17 Sep 2015 20:31:54 +0100 Received: from localhost ([10.1.2.79]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 17 Sep 2015 20:31:53 +0100 From: Richard Sandiford To: Michael Collison Mail-Followup-To: Michael Collison ,gcc Patches , richard.sandiford@arm.com Cc: gcc Patches Subject: Re: [PATCH, PR 57195] Allow mode iterators inside angle brackets References: <55DC37D4.9050900@linaro.org> <8737yq5zpx.fsf@e105548-lin.cambridge.arm.com> <55F0C66F.8010205@linaro.org> <874mix2vky.fsf@e105548-lin.cambridge.arm.com> <55FA0072.3060006@linaro.org> Date: Thu, 17 Sep 2015 19:42:00 -0000 In-Reply-To: <55FA0072.3060006@linaro.org> (Michael Collison's message of "Thu, 17 Sep 2015 00:51:14 +0100") Message-ID: <87mvwk266u.fsf@e105548-lin.cambridge.arm.com> User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-MC-Unique: 7wagl7C8So64fXTE5uZHDw-1 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2015-09/txt/msg01338.txt.bz2 Michael Collison writes: > On 09/14/2015 02:34 AM, Richard Sandiford wrote: >> Michael Collison writes: >>> Here is a modified patch that takes your comments into account. Breaking >>> on depth =3D=3D 0 with '>' does not work due to the code looking for wh= itespace. >> What goes wrong? Just to make sure we're talking about the same thing, >> I meant that in: >> >> (match_operand:FOO> ... >> >> the name should be "FOO" and you should get an error on ">" when parsing >> the text after the name, just like you would for: >> >> (match_operand:FOO] ... > > When I try breaking on '>' with a nesting depth of 0 all examples of=20 > fail. I meant break when depth =3D=3D 0 before the decrement that's associated with '>'. I think that problem would only occur if you broke _after_ decrementing the depth. >> It's not a big deal though, so... >> >>> 2015-08-25 Michael Collison >>> >>> PR other/57195 >>> * read-md.c (read_name): Allow mode iterators inside angle >>> brackets in rtl expressions. >> OK, thanks. > Meaning okay to check the patch in? Yeah, it's OK to check in. Richard