From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61334 invoked by alias); 30 Apr 2015 06:54:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 61241 invoked by uid 89); 30 Apr 2015 06:54:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-out.m-online.net Received: from mail-out.m-online.net (HELO mail-out.m-online.net) (212.18.0.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Thu, 30 Apr 2015 06:54:10 +0000 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3lcnW23sfDz3hhVm; Thu, 30 Apr 2015 08:54:06 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3lcnW21Mh8zvh2b; Thu, 30 Apr 2015 08:54:06 +0200 (CEST) Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id Bftm3PPohNYN; Thu, 30 Apr 2015 08:54:05 +0200 (CEST) X-Auth-Info: djTJi7PDCxmRW2OUJvgAHVSc2CuplxdfZSnVBe5ZtSvQQG9rBuUPIt7QzT6A2CX4 Received: from igel.home (ppp-93-104-94-204.dynamic.mnet-online.de [93.104.94.204]) by mail.mnet-online.de (Postfix) with ESMTPA; Thu, 30 Apr 2015 08:54:05 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 351502C00B2; Thu, 30 Apr 2015 08:54:05 +0200 (CEST) From: Andreas Schwab To: Trevor Saunders Cc: Jeff Law , tbsaunde+gcc@tbsaunde.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS References: <1430114140-15817-1-git-send-email-tbsaunde+gcc@tbsaunde.org> <1430114140-15817-4-git-send-email-tbsaunde+gcc@tbsaunde.org> <87oam7nmck.fsf@igel.home> <20150429212811.GA17482@tsaunders-iceball.corp.tor1.mozilla.com> <87383iob0i.fsf@igel.home> <5541548F.40608@redhat.com> <20150429222548.GB17482@tsaunders-iceball.corp.tor1.mozilla.com> <55415B46.5020801@redhat.com> <20150430001316.GC17482@tsaunders-iceball.corp.tor1.mozilla.com> <20150430021055.GD17482@tsaunders-iceball.corp.tor1.mozilla.com> X-Yow: Well, I'm on the right planet---everyone looks like me!!! Date: Thu, 30 Apr 2015 07:13:00 -0000 In-Reply-To: <20150430021055.GD17482@tsaunders-iceball.corp.tor1.mozilla.com> (Trevor Saunders's message of "Wed, 29 Apr 2015 22:10:55 -0400") Message-ID: <87mw1qhzsi.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2015-04/txt/msg01969.txt.bz2 Trevor Saunders writes: >> diff --git a/libobjc/encoding.c b/libobjc/encoding.c >> index 7333908..20ace46 100644 >> --- a/libobjc/encoding.c >> +++ b/libobjc/encoding.c >> @@ -1167,7 +1167,7 @@ objc_layout_structure_next_member (struct objc_struct_layout *layout) >> /* Record must have at least as much alignment as any field. >> Otherwise, the alignment of the field within the record >> is meaningless. */ >> -#ifndef PCC_BITFIELD_TYPE_MATTERS >> +#if !PCC_BITFIELD_TYPE_MATTERS With `#define PCC_BITFIELD_TYPE_MATTERS true' this expands to `#if !true' which evaluates to 1 since true isn't a defined identifier? Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."