[PATCH][ARM] PR/65711: Don't pass '-dynamic-linker' when '-shared' is used

[PATCH][ARM] PR/65711: Don't pass '-dynamic-linker' when '-shared' is used

[Ludovic Courtès]

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

As discussed at <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65711>.

Patch is for both 4.8 and 4.9 (possibly 5.1 too, I haven’t checked.)

Tested on armhf-linux-gnu (armv7.)

gcc/
2015-04-23  Ludovic Courtès  <ludo@gnu.org>

	PR 65711
	* config/arm/linux-elf.h (LINUX_TARGET_LINK_SPEC): Move
	'-dynamic-linker' within %{!shared: ...}.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 458 bytes --]

--- gcc-4.8.4/gcc/config/arm/linux-elf.h	2015-04-08 20:31:20.376900478 +0200
+++ gcc-4.8.4/gcc/config/arm/linux-elf.h	2015-04-08 20:31:36.437014437 +0200
@@ -65,7 +65,7 @@
    %{symbolic:-Bsymbolic} \
    %{!static: \
      %{rdynamic:-export-dynamic} \
-     -dynamic-linker " GNU_USER_DYNAMIC_LINKER "} \
+     %{!shared:-dynamic-linker " GNU_USER_DYNAMIC_LINKER "}} \
    -X \
    %{mbig-endian:-EB} %{mlittle-endian:-EL}" \
    SUBTARGET_EXTRA_LINK_SPEC

Re: [PATCH][ARM] PR/65711: Don't pass '-dynamic-linker' when '-shared' is used

[Ramana Radhakrishnan]

On Thu, Apr 23, 2015 at 9:29 AM, Ludovic Courtès <ludo@gnu.org> wrote:
> As discussed at <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65711>.
>
> Patch is for both 4.8 and 4.9 (possibly 5.1 too, I haven’t checked.)
>

OK for trunk. This is also ok for all release branches if no
objections in 24 hours.

Sorry about the delayed review.

regards
Ramana

> Tested on armhf-linux-gnu (armv7.)
>
> gcc/
> 2015-04-23  Ludovic Courtès  <ludo@gnu.org>
>
>         PR 65711
>         * config/arm/linux-elf.h (LINUX_TARGET_LINK_SPEC): Move
>         '-dynamic-linker' within %{!shared: ...}.
>

Re: [PATCH][ARM] PR/65711: Don't pass '-dynamic-linker' when '-shared' is used

[Ludovic Courtès]

Ramana Radhakrishnan <ramana.gcc@googlemail.com> skribis:

> On Thu, Apr 23, 2015 at 9:29 AM, Ludovic Courtès <ludo@gnu.org> wrote:
>> As discussed at <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65711>.
>>
>> Patch is for both 4.8 and 4.9 (possibly 5.1 too, I haven’t checked.)
>>
>
> OK for trunk. This is also ok for all release branches if no
> objections in 24 hours.

OK, thank you.

I haven’t applied for write-after-approval so perhaps you should commit
it yourself?

Ludo’.

Re: [PATCH][ARM] PR/65711: Don't pass '-dynamic-linker' when '-shared' is used

[Richard Biener]

On Mon, May 18, 2015 at 9:09 PM, Ludovic Courtès <ludo@gnu.org> wrote:
> Ramana Radhakrishnan <ramana.gcc@googlemail.com> skribis:
>
>> On Thu, Apr 23, 2015 at 9:29 AM, Ludovic Courtès <ludo@gnu.org> wrote:
>>> As discussed at <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65711>.
>>>
>>> Patch is for both 4.8 and 4.9 (possibly 5.1 too, I haven’t checked.)
>>>
>>
>> OK for trunk. This is also ok for all release branches if no
>> objections in 24 hours.
>
> OK, thank you.
>
> I haven’t applied for write-after-approval so perhaps you should commit
> it yourself?

So you just committed to the already closed 4.8 branch.  Please always
check gcc.gnu.org/ for branch status.

Richard.

> Ludo’.

Re: [PATCH][ARM] PR/65711: Don't pass '-dynamic-linker' when '-shared' is used

[Ludovic Courtès]

Richard Biener <richard.guenther@gmail.com> skribis:

> On Mon, May 18, 2015 at 9:09 PM, Ludovic Courtès <ludo@gnu.org> wrote:
>> Ramana Radhakrishnan <ramana.gcc@googlemail.com> skribis:
>>
>>> On Thu, Apr 23, 2015 at 9:29 AM, Ludovic Courtès <ludo@gnu.org> wrote:
>>>> As discussed at <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65711>.
>>>>
>>>> Patch is for both 4.8 and 4.9 (possibly 5.1 too, I haven’t checked.)
>>>>
>>>
>>> OK for trunk. This is also ok for all release branches if no
>>> objections in 24 hours.
>>
>> OK, thank you.
>>
>> I haven’t applied for write-after-approval so perhaps you should commit
>> it yourself?
>
> So you just committed to the already closed 4.8 branch.  Please always
> check gcc.gnu.org/ for branch status.

My bad, sorry about that!

Ludo’.

Re: [PATCH][ARM] PR/65711: Don't pass '-dynamic-linker' when '-shared' is used

[Ludovic Courtès]

Ramana Radhakrishnan <ramana.gcc@googlemail.com> skribis:

> On Thu, Apr 23, 2015 at 9:29 AM, Ludovic Courtès <ludo@gnu.org> wrote:
>> As discussed at <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65711>.
>>
>> Patch is for both 4.8 and 4.9 (possibly 5.1 too, I haven’t checked.)
>>
>
> OK for trunk. This is also ok for all release branches if no
> objections in 24 hours.

[...]

>> gcc/
>> 2015-04-23  Ludovic Courtès  <ludo@gnu.org>
>>
>>         PR 65711
>>         * config/arm/linux-elf.h (LINUX_TARGET_LINK_SPEC): Move
>>         '-dynamic-linker' within %{!shared: ...}.

Committed to gcc-4_8-branch, gcc-4_9-branch, gcc-5-branch, and trunk.
Please let me know if there’s anything I missed.

Thanks,
Ludo’.

Re: [PATCH][ARM] PR/65711: Don't pass '-dynamic-linker' when '-shared' is used

[Jakub Jelinek]

On Tue, Jun 23, 2015 at 11:30:25AM +0200, Ludovic Courtès wrote:
> Ramana Radhakrishnan <ramana.gcc@googlemail.com> skribis:
> 
> > On Thu, Apr 23, 2015 at 9:29 AM, Ludovic Courtès <ludo@gnu.org> wrote:
> >> As discussed at <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65711>.
> >>
> >> Patch is for both 4.8 and 4.9 (possibly 5.1 too, I haven’t checked.)
> >>
> >
> > OK for trunk. This is also ok for all release branches if no
> > objections in 24 hours.
> 
> [...]
> 
> >> gcc/
> >> 2015-04-23  Ludovic Courtès  <ludo@gnu.org>
> >>
> >>         PR 65711
> >>         * config/arm/linux-elf.h (LINUX_TARGET_LINK_SPEC): Move
> >>         '-dynamic-linker' within %{!shared: ...}.
> 
> Committed to gcc-4_8-branch, gcc-4_9-branch, gcc-5-branch, and trunk.
> Please let me know if there’s anything I missed.

See richi's mail.  4.8 branch has already been closed, and 4.9 branch
is frozen, so you should have asked for RM permission.
Also, in the ChangeLog entries, one should write it in the form
PR component/bugno,
so
	PR target/65711
in your case.

	Jakub

Re: [PATCH][ARM] PR/65711: Don't pass '-dynamic-linker' when '-shared' is used

[Ludovic Courtès]

Jakub Jelinek <jakub@redhat.com> skribis:

> On Tue, Jun 23, 2015 at 11:30:25AM +0200, Ludovic Courtès wrote:
>> Ramana Radhakrishnan <ramana.gcc@googlemail.com> skribis:
>> 
>> > On Thu, Apr 23, 2015 at 9:29 AM, Ludovic Courtès <ludo@gnu.org> wrote:
>> >> As discussed at <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65711>.
>> >>
>> >> Patch is for both 4.8 and 4.9 (possibly 5.1 too, I haven’t checked.)
>> >>
>> >
>> > OK for trunk. This is also ok for all release branches if no
>> > objections in 24 hours.
>> 
>> [...]
>> 
>> >> gcc/
>> >> 2015-04-23  Ludovic Courtès  <ludo@gnu.org>
>> >>
>> >>         PR 65711
>> >>         * config/arm/linux-elf.h (LINUX_TARGET_LINK_SPEC): Move
>> >>         '-dynamic-linker' within %{!shared: ...}.
>> 
>> Committed to gcc-4_8-branch, gcc-4_9-branch, gcc-5-branch, and trunk.
>> Please let me know if there’s anything I missed.
>
> See richi's mail.  4.8 branch has already been closed, and 4.9 branch
> is frozen, so you should have asked for RM permission.

Noted.  That part of the process was not clear to me, apologies.

> Also, in the ChangeLog entries, one should write it in the form
> PR component/bugno,
> so
> 	PR target/65711
> in your case.

OK.

Thanks,
Ludo’.