From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6934 invoked by alias); 23 Oct 2014 10:42:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 6923 invoked by uid 89); 23 Oct 2014 10:42:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 23 Oct 2014 10:42:25 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9NAgMlh029272 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 23 Oct 2014 06:42:22 -0400 Received: from localhost (ovpn-116-99.ams2.redhat.com [10.36.116.99]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9NAgKne029284 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 23 Oct 2014 06:42:21 -0400 Received: by localhost (Postfix, from userid 1000) id 9E79D412B1; Thu, 23 Oct 2014 12:42:19 +0200 (CEST) From: Dodji Seketeli To: Manuel =?utf-8?B?TMOzcGV6LUliw6HDsWV6?= Cc: "Joseph S. Myers" , Gcc Patch List , Marek Polacek , Paolo Carlini , Jason Merrill , Jonathan Wakely Subject: Re: C/C++ diagnostics guidelines References: X-URL: http://www.redhat.com Date: Thu, 23 Oct 2014 10:58:00 -0000 In-Reply-To: ("Manuel \=\?utf-8\?B\?TMOzcGV6LUliw6HDsWV6Iidz\?\= message of "Fri, 17 Oct 2014 20:39:47 +0200") Message-ID: <87mw8nkqyc.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2014-10/txt/msg02377.txt.bz2 Manuel L=C3=B3pez-Ib=C3=A1=C3=B1ez writes: > On 17 October 2014 20:04, Manuel L=C3=B3pez-Ib=C3=A1=C3=B1ez wrote: >> On 17 October 2014 19:33, Joseph S. Myers wrot= e: >>> On Fri, 17 Oct 2014, Manuel L=C3=B3pez-Ib=C3=A1=C3=B1ez wrote: >>> >>>> Thus, I drafted some guidelines >>>> at:https://gcc.gnu.org/wiki/Better_Diagnostics#guidelines >>>> >>>> Please, could you take a look and comment whether I got it right/wrong? >>> >>> Yes, that looks right to me. >> >> Thanks! >> >> I added guidelines also about locations and warning options. > > I believe there are also some rules about when to use some special > line-map functions that arise when warning about macros like NULL, but > I am not aware of the specifics. It would be useful if someone added > those. > > Dodji, Paolo? Do you know what I'm talking about? Hmmh, I am not sure. Do you have any example of warning about such macros? Cheers, --=20 Dodji