From: Gabriel Dos Reis <gdr@cs.tamu.edu>
To: Jason Merrill <jason@redhat.com>
Cc: gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: C++ PATCH to improve 'aka's on type printing in diagnostics
Date: Mon, 04 Jul 2011 19:54:00 -0000 [thread overview]
Message-ID: <87mxgtes9c.fsf@gauss.cs.tamu.edu> (raw)
In-Reply-To: <4E0DF674.7000307@redhat.com> (Jason Merrill's message of "Fri, 01 Jul 2011 12:31:48 -0400")
Jason Merrill <jason@redhat.com> writes:
| On 06/14/2011 01:38 PM, Jason Merrill wrote:
| > While I was at it, I've also tweaked the compiler to also print the
| > typedef-stripped version of a type when appropriate, which should help
| > with understanding template error messages.
|
| I noticed that this was sometimes printing an aka that was exactly the
| same, which looks a bit goofy. So this patch makes sure that the
| typedef-stripped version actually prints out differently before
| appending the {aka}.
|
| Tested x86_64-pc-linux-gnu. Gaby: I'm not entirely comfortable
| messing directly with the obstack here, but the pp interface doesn't
| seem to support multiple strings at once. Does this approach make
| sense to you, or do you have a better idea?
|
Hi Jason,
Please go ahead with your patch, and open a PR request for a better
interface (assigned to me). The diagnostic machinery should support
what you want to do without people having to deal directly with the
lower-level storage management. Thanks!
-- Gaby
next prev parent reply other threads:[~2011-07-04 19:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 17:46 C++ PATCH for c++/49117 (error message regression on conversion failure) Jason Merrill
2011-06-18 14:20 ` Jakub Jelinek
2011-07-01 18:07 ` C++ PATCH to improve 'aka's on type printing in diagnostics Jason Merrill
2011-07-04 19:54 ` Gabriel Dos Reis [this message]
2011-07-04 21:29 ` Jason Merrill
2011-07-04 21:31 ` Gabriel Dos Reis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mxgtes9c.fsf@gauss.cs.tamu.edu \
--to=gdr@cs.tamu.edu \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).