From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19459 invoked by alias); 4 Jul 2011 19:54:43 -0000 Received: (qmail 19429 invoked by uid 22791); 4 Jul 2011 19:54:42 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mailhost.cs.tamu.edu (HELO smtp.cs.tamu.edu) (128.194.138.107) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 04 Jul 2011 19:54:24 +0000 Received: from gauss.cs.tamu.edu (gauss.cs.tamu.edu [128.194.136.74]) by smtp.cs.tamu.edu (Postfix) with ESMTP id 5D4281904AD; Mon, 4 Jul 2011 14:54:23 -0500 (CDT) Received: by gauss.cs.tamu.edu (Postfix, from userid 1000) id 33E5214C8EE; Mon, 4 Jul 2011 14:54:23 -0500 (CDT) From: Gabriel Dos Reis To: Jason Merrill Cc: gcc-patches List Subject: Re: C++ PATCH to improve 'aka's on type printing in diagnostics In-Reply-To: <4E0DF674.7000307@redhat.com> (Jason Merrill's message of "Fri, 01 Jul 2011 12:31:48 -0400") References: <4DF79CA1.7010001@redhat.com> <4E0DF674.7000307@redhat.com> Date: Mon, 04 Jul 2011 19:54:00 -0000 Message-ID: <87mxgtes9c.fsf@gauss.cs.tamu.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-07/txt/msg00213.txt.bz2 Jason Merrill writes: | On 06/14/2011 01:38 PM, Jason Merrill wrote: | > While I was at it, I've also tweaked the compiler to also print the | > typedef-stripped version of a type when appropriate, which should help | > with understanding template error messages. | | I noticed that this was sometimes printing an aka that was exactly the | same, which looks a bit goofy. So this patch makes sure that the | typedef-stripped version actually prints out differently before | appending the {aka}. | | Tested x86_64-pc-linux-gnu. Gaby: I'm not entirely comfortable | messing directly with the obstack here, but the pp interface doesn't | seem to support multiple strings at once. Does this approach make | sense to you, or do you have a better idea? | Hi Jason, Please go ahead with your patch, and open a PR request for a better interface (assigned to me). The diagnostic machinery should support what you want to do without people having to deal directly with the lower-level storage management. Thanks! -- Gaby