From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 7EB3C3858D33 for ; Mon, 20 Nov 2023 19:33:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7EB3C3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7EB3C3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700508789; cv=none; b=cvxkNDdEO8X5eSBNrt3dFz6SWPoBaM2buI2zdr71p1d9Qq/rEJ4mI8aYXTRywub+tyhBUC5QmSXyQXLRhdD8w9lKJk0Ob/1odUOQfuFtXGjq4OiRqD2o0Hz25Sx4U134j+pLarqwzfJX6m+N2r6EvGc7YoGDxiw2Mr5wsHIZO10= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700508789; c=relaxed/simple; bh=Z75/ZmYiTVLjoWTXgE6Q3P9OqPlzOb2psIpLh8lgNSM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=JIBOrdgFZFsZsTxsqTke34ww6eg/Bs0c/PhveTT0AF9abXtCC9ffZuiK/0PTDXtleCpfXxuENFMMcEl2Ge8apMfbRp8d3kYmRw3pQqMHpxHvGX8nIXy7Tr+xz7rUWw+a9wV8/7eD8rsGjgDTbhTvXR/2XTeUJtxMFi9g4ibukwA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700508785; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IHC9MkpJqPmKBmPw0tSFZtxvG3MdMVLRWTjPF1C9lCo=; b=es8qRJI4Ka+5FrvlspaKL4M0NOLhmUDyuirQwqyoI2HGmGH+4Trs+TQPlMWrj6OfQ6lI3P PbJTWtfF4NSlTJx7pgjT+JA9Kqo6PnAS1X6nmWYNOvEuGlbt8cZiwwbnFs/206VjJgBNNY z62WzXY+lnM35fvKpjrvgvgGyNqt6jE= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-543-7UUQqE6_MtmS1Bxt9Mw9Dg-1; Mon, 20 Nov 2023 14:33:01 -0500 X-MC-Unique: 7UUQqE6_MtmS1Bxt9Mw9Dg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3406E3C0FCA6; Mon, 20 Nov 2023 19:33:01 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.29]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B2974492BE0; Mon, 20 Nov 2023 19:33:00 +0000 (UTC) From: Florian Weimer To: Eric Gallager Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH v3 11/11] c: Add new -Wdeclaration-missing-parameter-type permerror References: <700d70e4a2874645ddb67a8a335131d83b242e69.1700473918.git.fweimer@redhat.com> Date: Mon, 20 Nov 2023 20:32:59 +0100 In-Reply-To: (Eric Gallager's message of "Mon, 20 Nov 2023 14:12:48 -0500") Message-ID: <87o7fokyok.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Eric Gallager: > On Mon, Nov 20, 2023 at 4:58=E2=80=AFAM Florian Weimer wrote: >> >> This used to be a warning, enabled by default, without its own option. > > Right, I meant to ask: why create a new option of > -Wdeclaration-missing-parameter-type instead of reusing the existing > -Wmissing-parameter-type for this? It's documented as: =E2=80=98-Wmissing-parameter-type (C and Objective-C only)=E2=80=99 A function parameter is declared without a type specifier in K&R-style functions: void foo(bar) { } This warning is also enabled by =E2=80=98-Wextra=E2=80=99. What this doesn't say is that this has been subsumed by -Wimplicit-int in C99 and later language modes. Maybe we can tweak things such that -Wmissing-parameter-type controls declarations only in C99 and later language modes, and turn just that into a permerror. But the situation is confusing enough already, which is why I opted for the separate warning. Thanks, Florian