From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id 4F61E38582BD for ; Thu, 31 Aug 2023 13:30:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4F61E38582BD Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-31c479ede21so650624f8f.2 for ; Thu, 31 Aug 2023 06:30:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1693488620; x=1694093420; darn=gcc.gnu.org; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=SkyzBYkZNkyCFA6VtSCkcdooX9ipzajpkherOtWEug0=; b=RoM/Fbd1gZHjRaQdiWDY3g916ymt2yQ78QEyvSrCQHM7pqotyU42gf0b4R6M3a8xNw XxALjNGGGJjd8E2IgrgrZflYcIs/s297H0pvWx70xQLTROlV4YI/9bKSOPWiz+zNzMfI cdSeOfgRx5EyIulhfsnqqZySfEE8BrhMCDQjNOi7SmitWkwmPV0vMnchWLwEWiQZgVJ4 VtiSb6+HC34Mb8QgISiR/uIL1NBMYonsadpQgJNIDFSXRNj31Vx2CoCJGum7lDqaeszM /jwwL+h995Gp0lnrx1y+8ZKiYqWzOetklcs9U3/d3ghENSnuqJIB0x5I2DyNlQ1PdS5n dI8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693488620; x=1694093420; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SkyzBYkZNkyCFA6VtSCkcdooX9ipzajpkherOtWEug0=; b=PamHuyg00+3bHk984Fszvr4xc61t5jUmzeC7IG1oWMFAawSod7pKYQdfDxx6vgyzes PX9DB9n9ZmcrlulViKZrCj454jrlhLWRNmE9Lpv6gV6PGm+rCwYHoKMNi1E5cCFFWcAX N9v2QoGq/IqlAubybvpsUOHiE3cM2UoCU2RtPWXSlcozD16L2uKw2gMuhUQtsRxJuDQI Mt1bQu/hN4F8xcYCJhNqOfl/sqIOnXWtnbNgsWgbbFKrPxGqEBK4Bzo0+yM3gjZ6qa17 08Jw4pJvt1Dq8Z0DFu4lH2F+bEXUtsuYtQcxzyufMXfzKIjuXHX6bc5mv6Slgfd4SfF6 q6Lg== X-Gm-Message-State: AOJu0Yz+1zkRVYSLbOyFxrRIZ9h8CzLspyg+Zzhj3QJOx0O3+Zvi6Wpj iaw6KnemF7WoV4k+Xt0dgmRVsA== X-Google-Smtp-Source: AGHT+IEZMP1IB7NJzaEbvw52shqPK6HcVWNFgsvof7D/FdMf2UmwI6grIiQ9tp8oIEcsR1uai+Dcyw== X-Received: by 2002:adf:f807:0:b0:317:6220:ac13 with SMTP id s7-20020adff807000000b003176220ac13mr4132858wrp.32.1693488620290; Thu, 31 Aug 2023 06:30:20 -0700 (PDT) Received: from poulhies-Precision-5550 ([2001:861:3382:1a90:1ca7:b98f:ad45:1567]) by smtp.gmail.com with ESMTPSA id l7-20020a1c7907000000b003fed8e12d62sm1982040wme.27.2023.08.31.06.30.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Aug 2023 06:30:19 -0700 (PDT) References: <20230825044712.348608-1-yangyujie@loongson.cn> User-agent: mu4e 1.10.1; emacs 28.1 From: Marc =?utf-8?Q?Poulhi=C3=A8s?= To: Yang Yujie Cc: gcc-patches@gcc.gnu.org, charlet@adacore.com, ebotcazou@libertysurf.fr, derodat@adacore.com, xuchenghua@loongson.cn, chenglulu@loongson.cn Subject: Re: [PING][PATCH] LoongArch: initial ada support on linux Date: Thu, 31 Aug 2023 15:09:52 +0200 In-reply-to: <20230825044712.348608-1-yangyujie@loongson.cn> Message-ID: <87o7in49w5.fsf@adacore.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-13.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Yang Yujie writes: Hello Yujie, > gcc/ChangeLog: > > * ada/Makefile.rtl: Add LoongArch support. > * ada/libgnarl/s-linux__loongarch.ads: New. > * ada/libgnat/system-linux-loongarch.ads: New. > * config/loongarch/loongarch.h: mark normalized options > passed from driver to gnat1 as explicit for multilib. > --- > gcc/ada/Makefile.rtl | 49 +++++++ > gcc/ada/libgnarl/s-linux__loongarch.ads | 134 +++++++++++++++++++ > gcc/ada/libgnat/system-linux-loongarch.ads | 145 +++++++++++++++++++++ The Ada part of the patch looks correct, thanks. > gcc/config/loongarch/loongarch.h | 4 +- > 4 files changed, 330 insertions(+), 2 deletions(-) > diff --git a/gcc/config/loongarch/loongarch.h b/gcc/config/loongarch/loongarch.h > index f8167875646..9887a7ac630 100644 > --- a/gcc/config/loongarch/loongarch.h > +++ b/gcc/config/loongarch/loongarch.h > @@ -83,9 +83,9 @@ along with GCC; see the file COPYING3. If not see > /* CC1_SPEC is the set of arguments to pass to the compiler proper. */ > > #undef CC1_SPEC > -#define CC1_SPEC "\ > +#define CC1_SPEC "%{,ada:-gnatea} %{m*} \ > %{G*} \ > -%(subtarget_cc1_spec)" > +%(subtarget_cc1_spec) %{,ada:-gnatez}" > > /* Preprocessor specs. */ This is outside of ada/ (so I don't have a say on it), but I'm curious about why you need to use -gnatea/-gnatez here? Thanks, Marc