From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id 73E933858D20 for ; Fri, 21 Apr 2023 18:24:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 73E933858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-94f910ea993so271547466b.3 for ; Fri, 21 Apr 2023 11:24:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682101459; x=1684693459; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=tnJdlPIvJm8eMsBcTYXkVMU9xmuxppB33LwQCVtZXz8=; b=Sf3YvlHcdurjiQ6m5PwUqUFqyXZTSSXaU4qWUy53w1yPbgkIbZK1dC2ic80PDeTz/E IOvuOxZR02OXsUU41dxhEjNwQCrL/l2gLf9CQfBF6J186YAa8sfpgx85k4WSkNMiYEms rBv40zGudOsVdhNsWueKWPWfsFZiFPaqAF0fBypMZivqg0Qx6h/u8rquoNoDYi4G/B3C ZsY7A/9xs9J/bihbLS7ADN/hRnlM2mckS9ZYyXP9kG+BPN0VsuMLJ/bQLpgtPnKc//Q3 alGB+M44v2t47LDQIxV58m24vqDV5SspaKjHsa+zVEVhAuOQO+mQfM6KlKGJL98VR+bS E2yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682101459; x=1684693459; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=tnJdlPIvJm8eMsBcTYXkVMU9xmuxppB33LwQCVtZXz8=; b=VaWuCO1vKjHyQF7LvOVmy7rmp0/vlKHoRyBLL00apfWZLblF1XfmFDoF1eS6Lonbuj cD+dYABVoGN8m2TIIHGGbZmZirj5WkJTViJOnqTXqBc9rFx8G0Eb/DXMgnKkg8xv+uxq s/Dmt4v5QRDn68+CZCXulbJNhrGBo4O/VTkw6m+CDhd3Ut3xJgcMVn8e0F86MXATPtyP rcoM90+9TGACYzyv/5qK3Z6bfE9t08KR35wdqDihZ8Adw/FVt3LBVbieN5RMRQjgy09E y7sn9xbtaQeTOaCyhrSl9le7r5iRjz8EHk5eAxx5uR4w+VkszNIDFPPViFFM3fRrYhir st0A== X-Gm-Message-State: AAQBX9e9kKU1mId7qUDBxWDJ+3uAe0+NAUxvQBxCqLCoKzqGGDHzdIVm efzov4L0M5H+3fSirzp0vPI= X-Google-Smtp-Source: AKy350bWIibu/AOowSW+wzz+h7Z7rsbCfIezP56Oo5U7yffy/ejPDBXQYV++uOjfFrDgnVPFdf4Heg== X-Received: by 2002:a17:907:6290:b0:94f:395b:df1b with SMTP id nd16-20020a170907629000b0094f395bdf1bmr3555743ejc.21.1682101458733; Fri, 21 Apr 2023 11:24:18 -0700 (PDT) Received: from lancelot ([82.153.103.125]) by smtp.gmail.com with ESMTPSA id s12-20020a170906bc4c00b00947ed087a2csm2353940ejv.154.2023.04.21.11.24.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Apr 2023 11:24:18 -0700 (PDT) Received: from gaius by lancelot with local (Exim 4.94.2) (envelope-from ) id 1ppvQe-007eYy-6N; Fri, 21 Apr 2023 19:24:16 +0100 From: Gaius Mulley To: Arsen =?utf-8?Q?Arsenovi=C4=87?= Cc: gcc-patches@gcc.gnu.org, jakub@redhat.com, rguenther@suse.de Subject: Re: [PATCH] gcc/m2: Drop references to $(P) References: <20230421173804.3513130-1-arsen@aarsen.me> Date: Fri, 21 Apr 2023 19:24:16 +0100 In-Reply-To: <20230421173804.3513130-1-arsen@aarsen.me> ("Arsen =?utf-8?Q?Arsenovi=C4=87=22's?= message of "Fri, 21 Apr 2023 19:38:04 +0200") Message-ID: <87o7nhrt4f.fsf@debian> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Arsen Arsenovi=C4=87 writes: > $(P) seems to have been a workaround for some old, proprietary make > implementations that we no longer support. It was removed in > r0-31149-gb8dad04b688e9c. > > gcc/m2/ChangeLog: > > * Make-lang.in: Remove references to $(P). > * Make-maintainer.in: Ditto. > --- > Hi, > > We spotted that the m2 makefile includes some long-gone compatibility > variable $(P), presumably left over from when m2 was not in the tree > yet. This induced a build failure on our end: > https://bugs.gentoo.org/904714 > > Build-tested on x86_64-pc-linux-gnu. I haven't finished running the > testsuite. I believe this only ever expands to an empty string (if not > set by the env) in the current build system, so in theory, it should be > safe. > > OK for gcc-13 and trunk (with a priority on the former)? > > gcc/m2/Make-lang.in | 4 ++-- > gcc/m2/Make-maintainer.in | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/gcc/m2/Make-lang.in b/gcc/m2/Make-lang.in > index b34db0d9156..d0fa692e5b8 100644 > --- a/gcc/m2/Make-lang.in > +++ b/gcc/m2/Make-lang.in > @@ -514,7 +514,7 @@ GM2_LIBS_BOOT =3D m2/gm2-compiler-boot/gm2.a \ > cc1gm2$(exeext): m2/stage1/cc1gm2$(exeext) $(m2.prev) > cp -p $< $@ >=20=20 > -m2/stage2/cc1gm2$(exeext): m2/stage1/cc1gm2$(exeext) m2/gm2-compiler/m2f= lex.o $(P) \ > +m2/stage2/cc1gm2$(exeext): m2/stage1/cc1gm2$(exeext) m2/gm2-compiler/m2f= lex.o \ > $(GM2_C_OBJS) $(BACKEND) $(LIBDEPS) $(GM2_LI= BS) \ > m2/gm2-gcc/rtegraph.o plugin/m2rte$(soext) > -test -d $(@D) || $(mkinstalldirs) $(@D) > @@ -527,7 +527,7 @@ m2/stage2/cc1gm2$(exeext): m2/stage1/cc1gm2$(exeext) = m2/gm2-compiler/m2flex.o $( > @$(call LINK_PROGRESS,$(INDEX.m2),end) >=20=20 > m2/stage1/cc1gm2$(exeext): gm2$(exeext) m2/gm2-compiler-boot/m2flex.o \ > - $(P) $(GM2_C_OBJS) $(BACKEND) $(LIBDEPS) \ > + $(GM2_C_OBJS) $(BACKEND) $(LIBDEPS) \ > $(GM2_LIBS_BOOT) $(MC_LIBS) \ > m2/gm2-gcc/rtegraph.o plugin/m2rte$(soext) \ > $(m2.prev) > diff --git a/gcc/m2/Make-maintainer.in b/gcc/m2/Make-maintainer.in > index 17bd9a2d37e..a70682673cd 100644 > --- a/gcc/m2/Make-maintainer.in > +++ b/gcc/m2/Make-maintainer.in > @@ -753,7 +753,7 @@ GM2_LIBS_PARANOID =3D m2/gm2-compiler-paranoid/gm2.a \ > gm2.paranoid: m2/m2obj3/cc1gm2$(exeext) gm2.verifyparanoid >=20=20 > m2/m2obj3/cc1gm2$(exeext): m2/m2obj2/cc1gm2$(exeext) m2/gm2-compiler-par= anoid/m2flex.o \ > - $(P) $(GM2_C_OBJS) $(BACKEND) $(LIBDEPS) $(G= M2_LIBS_PARANOID) \ > + $(GM2_C_OBJS) $(BACKEND) $(LIBDEPS) $(GM2_LI= BS_PARANOID) \ > m2/gm2-gcc/rtegraph.o plugin/m2rte$(exeext).= so m2/gm2-libs-boot/M2LINK.o > -test -d m2/m2obj3 || $(mkinstalldirs) m2/m2obj3 > @$(call LINK_PROGRESS,$(INDEX.m2),start) Hi, yes certainly this is fine. lgtm. Thanks for spotting and the patch regards, Gaius