From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id D16C73830FCB for ; Thu, 15 Dec 2022 10:14:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D16C73830FCB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BF2O9ea028931; Thu, 15 Dec 2022 10:14:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=references : from : to : cc : subject : in-reply-to : date : message-id : content-type : mime-version; s=corp-2022-7-12; bh=9sBjH3fr5x3p/9ifRXfQW2GYcruXvK05K1XuSI4IeTo=; b=vUGPlWGOGvCWIChDi6cQaNk/xRNrKNMZuLH4cXxFTOhC4/3Zqh/8+9+P6cF1hKBFA2gP ltLVElIipdIqGYRa968vUKKjPLrBQZugpMnQFTeaXzZT5KvWJ5mNvc8m3oD/pKBKJlui YSIiCYS0zyKa6ugEAmQQl5lO3IG3ruIyGAj/+KqVevsz9zTOBRFyFLu6auPf7wv5nKfq MC97OfutIX4XD3mc+ptyRomPwfpP44u5DRnePFX+s41ETkbgA7G3l246vqeIQdcdVJhp o06baSQlGFz4ItxL17sZSGQW7M5/WVwJKpFS3x4Pivn6+c0CQ/8l60LypcGqgx8e7RXE 0A== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3meyervpdf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 Dec 2022 10:14:02 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2BF9pbvF004019; Thu, 15 Dec 2022 10:14:02 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2174.outbound.protection.outlook.com [104.47.59.174]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3meyexeyn9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 Dec 2022 10:14:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aEGZmIkGyja6bG0mWgcyjriZoTaN1HnAzgARcHHGEkWmpe0JNJoWeWtkqmJ/cebQkKwREwXNZ5ft/R7luE+GJ6GG+KVCRIO29Q5wziOk7G+W3cO7K7B2uXlB6TNi+tmjwYT6VHJGna/qEMwR29znVKobsgDW8DmwQIOA2mdazH87SOSvfJSYCDTT48aRP4tf7ggmMY/9p9iTIz3NpChrz+D/wkmCYvWpgyBNuTf6YySloMMxsL4BlH3nx4GVEipdrCCqSxglvCXoQwocXTxfaGCQqqtZAG78hbcMXteXGdA3+bPQwniP8ziu1RJ00sDBQMc/Vs9JSktzn1BJwIUuAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9sBjH3fr5x3p/9ifRXfQW2GYcruXvK05K1XuSI4IeTo=; b=k1bQ0RNsDjmKACMIsHWExyrsBUcdYBIz7FXWKQ+j5N58fI+/Yq1NUfpvxvDLo90tjcvMpdCvDSQbSRzTbodqQi5AAYx4FYsRE57ET/KwfLcg77d6B/NgnNvHfn7bgDjw5/V+XHBPOLCWBnDGKexQLXbztDgqwoJH1vx/p8uiWldI2iLRKKF0nXlK3e5s71wiIK/cI96gyRYNy/edHJyuQTuvsAa2P/H8tHqugZlHGZW2rcPeddHfs5SoR6L8XJlbuEz/pdR6/o9fO6SuIlkHJdbgjRV0X3mGirtXYnm9NebzLsnxu662RXgge5571Oi5x+CA4lVPW5CSQuzVpAQocA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9sBjH3fr5x3p/9ifRXfQW2GYcruXvK05K1XuSI4IeTo=; b=cCNOP3DzTbhOBdjTSxQHCW+x4+/gKFSzBgwB6ck6NsvDGbo6adbL9JulcR6q2FUxXXrGHta0sUFxmXSXBBRzvY1W0jPqdvfQLsH+y84bH9WQaL8bvZaSRtV7GOY4iCuqQ8p5ZhZ/PmNkdU3rUqgvdw+Un1ngT7S1r7ZDKz7YfGY= Received: from BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) by DS7PR10MB4896.namprd10.prod.outlook.com (2603:10b6:5:3a0::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.12; Thu, 15 Dec 2022 10:14:00 +0000 Received: from BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::8681:5931:e558:2638]) by BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::8681:5931:e558:2638%7]) with mapi id 15.20.5880.019; Thu, 15 Dec 2022 10:14:00 +0000 References: <20221202175225.2780-1-cupertino.miranda@oracle.com> <20221202175225.2780-2-cupertino.miranda@oracle.com> <878rjj5jug.fsf@oracle.com> User-agent: mu4e 1.4.15; emacs 28.1 From: Cupertino Miranda To: Jeff Law Cc: gcc-patches@gcc.gnu.org, jose.marchesi@oracle.com Subject: Re: [PATCH 1/2] select .rodata for const volatile variables. In-reply-to: <878rjj5jug.fsf@oracle.com> Date: Thu, 15 Dec 2022 10:13:55 +0000 Message-ID: <87o7s52cv0.fsf@oracle.com> Content-Type: text/plain X-ClientProxiedBy: LO4P265CA0074.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2bd::13) To BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN6PR1001MB2340:EE_|DS7PR10MB4896:EE_ X-MS-Office365-Filtering-Correlation-Id: a5dd59ee-31c2-4dd1-ae46-08dade851578 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ORB6JMI1LaII0CSf/Lt8aua7UpkAthF35M2TWN1G7fkWA9xaM39gucbTTFhOmZDn7LOsgHG0uBPRdeSpQE4zd2/vkaI6j1vnTpQyZKuoaSz9awPgUOwpV20vVMPL2N3O/2JZOIEOKJPzRSy9Qf7V/tWPm/fr5OVct2JdQHUeg0jNqgqn+D744xAyoPEDzSdAq041Q431ntGHduEAAtyF88X1afqhHfGEEa3DaWSbbrmUTiUrXHBNSe+2kXgTWwxUEqFxs3IXMYJWAveHbzH1al2PncnJsv39nlZaTET0J859AzVRNhIaYnk/CizaSNk2F9iVrHLFaV89kFIsqSxSjDRW6VA7t0QeHqY7aio+rf+JRNsLaTloFNcbypEvLCdDJjiON+Flc/Lh0qqibpD0JfjsoABX4REDfBcbnoLQQ6hfbmGKWfZNepEJ3jLzTsE8t0jG7SyTqzuluvPDmDqoUzSdkZEsFwIaq7zrLLXa2pfwQZuPdkTgEEH2Cr758EHg+9bJz3ZVwT/tH7hw0JDAMRWeAqOFgHYxLmmv1j+q+9gM14/n3lbH4Ywnpav946TGbT+BVkB+jO5fGbyk7YUr7S2tJcQ/BumoY1vnOMlVRnGGS05auH8qvVrIFa7Dk4Jnzm1BoidgFH7JQtp6pXub/FkCA5P20hJ2Uu/djPDp0gN7SoIUqCJaQh7W28nkWWIrSG0T1aAH3IFmQKHsRyI+Q1zOQFgT7ROkklVLVKhb+rUUhnHgYi6mqK8x+NUltFTa X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR1001MB2340.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(396003)(136003)(366004)(39860400002)(346002)(451199015)(36756003)(316002)(6916009)(2906002)(478600001)(83380400001)(6486002)(966005)(86362001)(6506007)(6666004)(107886003)(2616005)(6512007)(186003)(53546011)(8936002)(38100700002)(44832011)(66476007)(66556008)(8676002)(66946007)(4326008)(41300700001)(5660300002)(142923001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZycAfUlPlSFbRMa5II6kFi+cumAUuY4rRbnAJThX6ZXU5Z7Kgoo/xpK4k008?= =?us-ascii?Q?WEJlerTUWRMzyU4jhgg3B0VENPq3OC38+oYoFhK4oX9+zHTSHeVcU1oKs08v?= =?us-ascii?Q?XnG/VhWLqhSzw/es5zQVm7StKut+duOfdaSnm6G7un/sa73pLOPt/5rrzIma?= =?us-ascii?Q?4OHWP9r677XupPY9LpksXVAkoGMX66uL0LgepNBK3ZfIom9D9/SK+ChuZVkq?= =?us-ascii?Q?YUKlinIGx6MAjsZtNiUVzQBVpfeZzJeE8FpnXpZNNP3kINsnxDmSUi8uPVFN?= =?us-ascii?Q?N6TjSJ1iSLdxM82TkwNYfwL2YU1509Eqt7Afkhxl0gpvV9Kc6i2nxuqM6TO4?= =?us-ascii?Q?6iYeNNuJQRpcK2xdxldKgrDbFDVTCRtj5Sn23j0KOIk1rM+xSP0m4MhKE3Jw?= =?us-ascii?Q?MjPOlGycLoySUeQXJdkj9gmKQxtzo6u+Gla7DpeeDN4ZU+aOyMQUbjmcig5b?= =?us-ascii?Q?sjJz2E10tPWjXbvVZfp1jt5Yn4sBERDCKQHhsYpIaOnQfwzozVb/eIbRd78w?= =?us-ascii?Q?90q0Yl75aLLpZS/wZVg0WN8/8T+Y+N8DF1zzX45pYQNGSD8zKzexbVc3Q8cg?= =?us-ascii?Q?Uq4G9CCMsjtzUzc0f8OuGD5N3FVZQMQYzWFGE63eRtc8V7wiyDD9W45ALQdU?= =?us-ascii?Q?HsxOhoQSm3fUYsYp8MPU82EfZ45G78NHdlir/nTrDWEZxQVO4fndQUhlHM5W?= =?us-ascii?Q?J/x3/jkdTF6shiL1NlWYEzKA16SwFoi6N0rhLF0lhVObl5iQr2I83J/AFvVH?= =?us-ascii?Q?zQKrCT9Xwz3T5QTRy3u6HN65Ko6by2ipk+d56up8UXJZifeDK55HrmU5YVHW?= =?us-ascii?Q?poQgzsV9980oS0ypxuHG6O5FKzQLIUNuMmt0QPejkX5Sm9+OBWxiLH0t4IGa?= =?us-ascii?Q?dAbC3LKoo4oRI/rZ71duAn2bR3HpmbIr2Ue8nb87Q40CQL0GoBqjNTjzd8q9?= =?us-ascii?Q?ZttjAe3zFKv/EPdnVnbJWBTEfXF+PSUaFQhRxFj8pYKFtJ1h4n3zIJp0x9aG?= =?us-ascii?Q?evZ5TuDtj/T9OMm66uR/86F1EPYEGV470A1ChPHfCfHKPh4WX13dN+62GqON?= =?us-ascii?Q?GSWhFcTI1ZNjVEWMxC/7/rUs+yhnIDm3OS35Dk3uMUH/7r0/52PdpC7MjLEQ?= =?us-ascii?Q?SZedP2TE7Z3unbukE03YeadkRNMaSqPgooVbbr0nl1yAIyOMm5j4wTMTkN31?= =?us-ascii?Q?OqvEI15P8vPqtzOZgkm5kuGKQ4ZhPfVJBEXIAW7b0pupvobnYnle7/Avw1PT?= =?us-ascii?Q?wZ8CcK+qioQ5wVqCl/DAb80v3tdKNu/+rFaTrGCRWvtxAUBQPmOa/AT6Zs13?= =?us-ascii?Q?qUQLnv8aBvm0fLdJUyZqWBVChrXdgHWNW1rhnFjOWhnPxiwO2LtIQOL+aNkq?= =?us-ascii?Q?kkLicOVJoDyltXFdoLdtQPoTFgopUYNGDbVqisQoQudgbuh+8lXGhUGzmk9z?= =?us-ascii?Q?rIkSiO2V0ZmL3V2Jc308KxTTZr1HWkKshw66k3nbsu+zvya+ToFFFrbdRlRu?= =?us-ascii?Q?teJZFKfGgscsmtQT6ayEoeIzdFpcxkT6iANsDc91wAH6bf0sl4jqqIGHoNj9?= =?us-ascii?Q?IPRuv30v14HINYwVSaL5xJvVMRnZNoH8dBSjuUyAKeovrSR+HHVejqX/laJZ?= =?us-ascii?Q?xPNM5FRrzZoshQ4MYSJUsBc=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: a5dd59ee-31c2-4dd1-ae46-08dade851578 X-MS-Exchange-CrossTenant-AuthSource: BN6PR1001MB2340.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2022 10:14:00.4218 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9uLPibmAzFEP28Q9CKFMws5fVeZuVl9qb1kRYpH7ZltbnPzJ9Xf1L5HZIKLKnV10fYKY5ExCFXgEz87eQeA21y9cPDXl5YDHqOflwbQFBio= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB4896 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-15_05,2022-12-14_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2212150080 X-Proofpoint-ORIG-GUID: OxWt7uCsBgRGafq4_dtG2dAk4P6aCAt7 X-Proofpoint-GUID: OxWt7uCsBgRGafq4_dtG2dAk4P6aCAt7 X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: gentle ping Cupertino Miranda writes: > Hi Jeff, > > First of all thanks for your quick review. > Apologies for the delay replying, the message got lost in my inbox. > >> On 12/2/22 10:52, Cupertino Miranda via Gcc-patches wrote: >>> Changed target code to select .rodata section for 'const volatile' >>> defined variables. >>> This change is in the context of the bugzilla #170181. >>> gcc/ChangeLog: >>> v850.c(v850_select_section): Changed function. >> I'm not sure this is safe/correct. ISTM that you need to look at the underlying >> TREE_TYPE to check for const-volatile rather than TREE_SIDE_EFFECTS. > > I believe this was asked by Jose when he first sent the generic patches. > Please notice my change is influenced by his original patch that does > the same and was approved. > > https://gcc.gnu.org/pipermail/gcc-patches/2022-August/599348.html > https://gcc.gnu.org/pipermail/gcc-patches/2022-September/602374.html > >> >> Of secondary importance is the ChangeLog. Just saying "Changed function" >> provides no real information. Something like this would be better: >> >> * config/v850/v850.c (v850_select_section): Put const volatile >> objects into read-only sections. >> >> >> Jeff >> >> >> >> >>> --- >>> gcc/config/v850/v850.cc | 1 - >>> 1 file changed, 1 deletion(-) >>> diff --git a/gcc/config/v850/v850.cc b/gcc/config/v850/v850.cc >>> index c7d432990ab..e66893fede4 100644 >>> --- a/gcc/config/v850/v850.cc >>> +++ b/gcc/config/v850/v850.cc >>> @@ -2865,7 +2865,6 @@ v850_select_section (tree exp, >>> { >>> int is_const; >>> if (!TREE_READONLY (exp) >>> - || TREE_SIDE_EFFECTS (exp) >>> || !DECL_INITIAL (exp) >>> || (DECL_INITIAL (exp) != error_mark_node >>> && !TREE_CONSTANT (DECL_INITIAL (exp))))