From: Richard Sandiford <rdsandiford@googlemail.com>
To: Mike Stump <mikestump@comcast.net>
Cc: gcc-patches Patches <gcc-patches@gcc.gnu.org>
Subject: Re: remove wrong code in immed_double_const
Date: Sat, 17 Mar 2012 07:37:00 -0000 [thread overview]
Message-ID: <87obrvd6fh.fsf@talisman.home> (raw)
In-Reply-To: <5FF5A724-3FE1-4E97-8124-542A0B8259FE@comcast.net> (Mike Stump's message of "Fri, 16 Mar 2012 14:54:06 -0700")
Mike Stump <mikestump@comcast.net> writes:
> This removes some wrong code.
>
> Ok?
>
> Index: gcc/emit-rtl.c
> ===================================================================
> --- gcc/emit-rtl.c (revision 184563)
> +++ gcc/emit-rtl.c (working copy)
> @@ -540,8 +540,6 @@ immed_double_const (HOST_WIDE_INT i0, HO
>
> if (GET_MODE_BITSIZE (mode) <= HOST_BITS_PER_WIDE_INT)
> return gen_int_mode (i0, mode);
> -
> - gcc_assert (GET_MODE_BITSIZE (mode) == 2 * HOST_BITS_PER_WIDE_INT);
> }
>
> /* If this integer fits in one word, return a CONST_INT. */
Is this because you have an integer mode between HOST_BITS_PER_WIDE_INT and
2 * HOST_BITS_PER_WIDE_INT? (I.e. a partial one?) If so, I can see an
argument for changing the "==" to "<=", although we'd need to think
carefully about what CONST_DOUBLE means in that case. (Endianness, etc.)
Or is this because you have an integer mode wider than
2*OST_BITS_PER_WIDE_INT? We currently only support constant integer
widths <= 2*HOST_BITS_PER_WIDE_INT, and the assert is correctly
triggering if we try to build a wider constant. Obviously it'd be
nice if we supported arbitrary widths, e.g. by replacing CONST_INT and
CONST_DOUBLE with a single n-HOST_WIDE_INT rtx (and immed_double_const
with some kind of nary builder, etc.). It won't be easy though.
Removing the assert seems like papering over the problem.
FWIW, here's another case where this came up:
http://gcc.gnu.org/ml/gcc-patches/2011-03/msg01220.html
Richard
next prev parent reply other threads:[~2012-03-17 7:37 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 21:54 Mike Stump
2012-03-16 22:04 ` Steven Bosscher
2012-03-17 1:03 ` Mike Stump
2012-03-17 7:37 ` Richard Sandiford [this message]
2012-03-18 0:29 ` Mike Stump
2012-03-18 10:16 ` Richard Sandiford
2012-03-18 16:35 ` Mike Stump
2012-03-19 21:44 ` Richard Sandiford
2012-03-19 23:31 ` Mike Stump
2012-03-20 10:32 ` Richard Guenther
2012-03-20 10:50 ` Richard Sandiford
2012-03-20 11:38 ` Richard Guenther
2012-03-20 12:27 ` Richard Sandiford
2012-03-20 12:47 ` Richard Guenther
2012-03-20 13:55 ` Michael Matz
2012-03-20 20:44 ` Mike Stump
2012-03-21 13:47 ` Michael Matz
2012-03-21 17:01 ` Mike Stump
2012-03-22 13:16 ` Michael Matz
2012-03-22 18:37 ` Mike Stump
2012-03-20 19:41 ` Mike Stump
2012-03-21 1:01 ` Mike Stump
2012-03-21 13:17 ` Richard Sandiford
2012-03-21 21:36 ` Mike Stump
2012-03-22 10:16 ` Richard Sandiford
2012-03-22 10:25 ` Richard Sandiford
2012-03-22 20:28 ` Mike Stump
2012-03-23 10:02 ` Richard Sandiford
2012-03-26 19:14 ` Mike Stump
2012-03-26 20:04 ` Richard Sandiford
2012-03-26 23:57 ` Mike Stump
2012-04-04 21:07 ` Mike Stump
2012-03-22 14:12 ` Michael Matz
2012-03-22 18:55 ` Mike Stump
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87obrvd6fh.fsf@talisman.home \
--to=rdsandiford@googlemail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mikestump@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).