From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 2B6903861863 for ; Thu, 15 Feb 2024 15:57:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2B6903861863 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2B6903861863 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708012644; cv=none; b=YmywR8ZDK2nKmkVzg0aj5jHE+yG6ogupDX8E7a+ZVIErHO6g2hws9zUQJZ+b+3SFP/RJzxyg2Q8bu4ScdCmnDzoZ1hbGUpV+eWVBDC+WwWJ9j9KHpZfT9Pxu5f3wuywOqYniIVEB/4eZ52i3rnkSd5m6yFWu+9E/7ZUGZsx9gt8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708012644; c=relaxed/simple; bh=BybCVPtHOZr0HyPHoEwL30FEr9ET06YphwO6fogztUw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=G0GrNsgpc+BioNoY9YVe4CpwGNeWRC3E+K+y+5msYP8lkPlnKem5olOoS14wwc8JmTcYPsj3kl9hAV2OT53uNNS3HVMoAKjNs9bggbESwAvEIHd4rQBYcUmzYGvZb6lP7ZalY6FaursnmlbtrinoI9OH2bspaB/B56zPPaTfEXE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708012642; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bF0O72FGgHOIBRn03N6hgAEoOg1XhqnTbg2eCupdpMI=; b=boOF40Jlz1GQW5AFsul0KW2Pf6fI4ix2akTWidR1dNUZ3aNl3S+id6Nc3vFT8iap/Fhu29 FMRdSLcf6hyVjEJUm3CGr6KTco/xZI/N+2OB6yKg2CBwdO6vATE5toSer89SxVsnc5JZUS 0VzWZrTEAmQZZUdJ9OzGL3e5knXCtrg= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-533-fJL0YDHWM2ab0-ZcqGyr5g-1; Thu, 15 Feb 2024 10:57:21 -0500 X-MC-Unique: fJL0YDHWM2ab0-ZcqGyr5g-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4758C28EC110 for ; Thu, 15 Feb 2024 15:57:21 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.50]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9BC052166B32; Thu, 15 Feb 2024 15:57:20 +0000 (UTC) From: Florian Weimer To: Jonathan Wakely Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Notes on the warnings-as-errors change in GCC 14 References: <87v876ssxg.fsf@oldenburg.str.redhat.com> Date: Thu, 15 Feb 2024 16:57:19 +0100 In-Reply-To: (Jonathan Wakely's message of "Fri, 2 Feb 2024 18:08:01 +0000") Message-ID: <87plwxaffk.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Jonathan Wakely: >>+

To fix the remaining int-conversions issues, add casts >>+to an appropriate pointer or integer type. On GNU systems, the >>+standard (but generally optional) types > > I know what you mean here, but I'm not sure the parenthesis adds > clarity for anybody who doesn't already know that those types are > optional for conformance. I think they're supported for all targets > that GCC supports, so maybe just omit the parenthesis. Fair enough, I've droped the parentheses. Thank you for your other suggestions as well, I have applied them. Florian