From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by sourceware.org (Postfix) with ESMTPS id 500403858C5F for ; Mon, 20 Nov 2023 08:46:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 500403858C5F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 500403858C5F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::334 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700469995; cv=none; b=jhGhnH/1GktVba09j61XOPY0uQUYUHA/EmPKSOGDw7p2zFRhzox32R30QCxyiFqG0Cm/a0Q49TneHw0jtlUv2iYTAoDFrkFMPK2HL53gMkkA+YG7G2Burza+l4XPPGXCgm/QKeRlwv/lURJvVdL+cr5yAeoBbF+Q0cBSnnC9cnQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700469995; c=relaxed/simple; bh=3Dd12n83747yQ1qCUaZiN7W1rhKG1IIdCG5X5dfVIw8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Ut/+9JkCiu6XXldwQKDYUc2JAz+LM9a1g1hDOxK2DeoVmLLkNdF2GafCbLadI0oe8stlVpoB8jgFOJ92MlA6GwrfuA1bILp6FPVdhkKlAP3N8E3+Rt9hsdft30wej2TWHD23fi4jIpD4GApX4L7F2LEXJ9pf5TvEQjV/2V4OWU8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-4079ed65582so12380495e9.1 for ; Mon, 20 Nov 2023 00:46:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1700469992; x=1701074792; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=w0p+7FnGiME5IOhm0kD/AMGWCmH1q26dw6jY8DN7PKY=; b=CqwLP+4S2n7J0OB9Ujkvrz9WlhDG4nEzTTZrAn4yezkaIWxasK4L9Q5wrYLqyWxBzO UZWC6uIofgzWkEp+6qvcQbEwRwziwrgOz0Sx+fz11OWeuUqeNinBF9rlkl9hk9Bt6CuO H12ZfnHArwZ1EK3LRm4U8epm2a7R/EnpR27G3bvnW66lUVnFvk5KqxdqE+T4YzsJ0ntV kAqcetF9Es6iXN7qVhPBytkRDtYIpvdfOeyYQs2LgoEwaNAh2QLqW4bjdM4S7p9shR7X /zQbRruySxaHav1QTfn9ugWk7f1fyfI0vOUAFRkrcDNVwjlfbIq42y0JTQjOBn8kARX8 iYPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700469992; x=1701074792; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=w0p+7FnGiME5IOhm0kD/AMGWCmH1q26dw6jY8DN7PKY=; b=GoYdVZ0tk5rekqGur1R5xJ31HCp7sMx950CZWpEZg9qoGrxQAZtEK8xir3S40BaH6p QLQA7EeY3SxDnTlBZDxV4nuW3zZDCDfrgfOTuybxb7GiWO7A/sFBNtmH1xn/psDhdqb3 YwkfHaR1RM7wxDM7moIZIBBEhFu/jLmRaU6EpV9qnY0pAPEQMXFiwv6+fJ5qSR4bR1QW CysrxE2d49rec5X4DnQyiFYEOi/fx7RVXP3YKn0tsWCwIViCyRXYLGC3wjFaVBDGtC4W F8PL9rHKjROrN6Jb4Hm68NNUEaOt8drWW2qz7E9R0iCyO3rNPsCLrfNxY7OGHeFPTAg7 GJjw== X-Gm-Message-State: AOJu0YxQK16oG9wzTc4BD+Rv53TBs5Tjii3gp0fm2lwQQMPzd3+mUha6 nUy4P1Zf/bV7AIrwP0+aMepHIQ== X-Google-Smtp-Source: AGHT+IFOyp9MiMUrAOO9IwrxgJN3CUYppgLAc4OYn3E6S9XGFU6QyROuFOeLeFSLHTmigCwAVdeYOw== X-Received: by 2002:a05:600c:3d9a:b0:3fe:4cbc:c345 with SMTP id bi26-20020a05600c3d9a00b003fe4cbcc345mr5275004wmb.41.1700469991531; Mon, 20 Nov 2023 00:46:31 -0800 (PST) Received: from poulhies-Precision-5550 (lmontsouris-659-1-24-67.w81-250.abo.wanadoo.fr. [81.250.175.67]) by smtp.gmail.com with ESMTPSA id n27-20020a05600c3b9b00b00405959469afsm12983385wms.3.2023.11.20.00.46.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 00:46:31 -0800 (PST) References: <88dc78af-82a3-9a9f-4b8e-461c41d296cc@e124511.cambridge.arm.com> <10532e77-2eb3-5043-0b71-faf415c5a1af@e124511.cambridge.arm.com> <87wmug7ixm.fsf@adacore.com> <183331d9-519b-ea2f-d491-b4f4941a8122@e124511.cambridge.arm.com> User-agent: mu4e 1.10.1; emacs 28.1 From: Marc =?utf-8?Q?Poulhi=C3=A8s?= To: Andrew Carlotti Cc: gcc-patches@gcc.gnu.org, ebotcazou@libertysurf.fr, rguenther@suse.de, richard.sandiford@arm.com, richard.earnshaw@arm.com Subject: Re: [PATCH v2 3/5] ada: Improve attribute exclusion handling Date: Mon, 20 Nov 2023 09:26:08 +0100 In-reply-to: <183331d9-519b-ea2f-d491-b4f4941a8122@e124511.cambridge.arm.com> Message-ID: <87pm047qxl.fsf@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Andrew Carlotti writes: > On Fri, Nov 17, 2023 at 11:45:16AM +0100, Marc Poulhi=C3=AF=C2=BF=C2=BDs = wrote: >> >> Hello, >> >> > I haven't manged to test the Ada frontend, but this patch (and the fol= lowing >> >> I don't have an aarch64 setup to test, but I may be able to help with the >> issue preventing you from testing. Can you elaborate what is the problem? >> >> Marc > > I only really got as far as trying to configure a build environemnt, which > failed with 'configure: error: GNAT is required to build ada'. I have no= prior > Ada experience, and I couldn't work out how to get any relevant test code= to > compile on Compiler Explorer. I therefore decided it wasn't worth me spe= nding > more effort trying to test from Ada a small change to some code that is > effectively front-end independent, but just happens to be added to a limi= ted > subset of front ends. > > It's probably sufficient to simply test that the Ada changes can be built= for > any target, since I'd be surprised if I've managed to copy this code from= C++ > in a way that breaks functionality without obviously breaking the build. Hello, I've tested your changes. The compiler builds correctly and there's no regression (x86_64-linux) + I've also executed some extra tests. > gcc/ada/ChangeLog: > * gcc-interface/utils.cc (attr_noinline_exclusions): New. > (attr_always_inline_exclusions): Ditto. > (attr_target_exclusions): Ditto. > (attr_target_clones_exclusions): Ditto. > (gnat_internal_attribute_table): Add new exclusion lists. > (handle_noinline_attribute): Remove custom exclusion handling. > (handle_target_attribute): Ditto. > (handle_target_clones_attribute): Ditto. Ok. Marc