From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 9950D3858D33 for ; Thu, 9 Nov 2023 09:33:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9950D3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9950D3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699522434; cv=none; b=PGcr0fIeTTXMdIcFxjxUb+7X4zMDuvMxhaLtn9MSXXYCERNGtsZqL8FSskVk/T3g/mcQXM1YTIP+NdhkANJ72ouDRklZ43H5zLQ+PLfFJRbFBV2Msl93IoB90X2TPdhRdWK5PhlxoUUK0lPQ0o0EncgQT5x31mnNK0dEQ7OoePA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699522434; c=relaxed/simple; bh=aVMAyRZ04g+OPi/8Iy1WkcQLQUYOzHXVFJkzDOq3kN4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=x8dPjxlNaiY0Du1IUlksrMQkmWEltQ4wBBemI2FArBY2gqySe5+Wt88LDSFMb92G/BwO9S/8dvzh5akrbLYdjpBjVyGwsY4lfs34q7dkbFZ6p6GleqZWj7SN+CIH+3y3cxYEzPnUpTYYG79kdW6BpchIdF7ugYoLOlqwvWNJJeY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699522424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3azp/TbYnmdgw23kVfQZdlhWa9SMIfrKuahO+MIPxeo=; b=Km+x7lx61dFphOJkiAlp02FLd5p4gQlrJK03QrXyn83edfy+2ovcBFj5C0Fj/8SP3J/zxx AnV8drVciOoSxpZcgWBqmzrXasvC/Nnc/RX4xFPHQt5A9+jvCX+gA7EzTYLFlBL7DjV462 DYt9t93CYyXOq0910rsa8n9Xc3gKt3g= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-262-3YV5wHEgPVOQdbuRJv2UYA-1; Thu, 09 Nov 2023 04:33:42 -0500 X-MC-Unique: 3YV5wHEgPVOQdbuRJv2UYA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E993C811E88 for ; Thu, 9 Nov 2023 09:33:41 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4C8691C060AE; Thu, 9 Nov 2023 09:33:41 +0000 (UTC) From: Florian Weimer To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] i386: Fix C99 compatibility issues in the x86-64 AVX ABI test suite References: <875y2c8fca.fsf@oldenburg.str.redhat.com> Date: Thu, 09 Nov 2023 10:33:40 +0100 In-Reply-To: (Jakub Jelinek's message of "Wed, 8 Nov 2023 15:58:19 +0100") Message-ID: <87pm0j6zkb.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=-=-= Content-Type: text/plain * Jakub Jelinek: > On Wed, Nov 08, 2023 at 03:55:17PM +0100, Florian Weimer wrote: >> * gcc.target/x86_64/abi/avx/avx-check.h (main): Call >> __builtin_printf instead of printf. >> * gcc.target/x86_64/abi/avx/test_passing_m256.c >> (fun_check_passing_m256_8_values): Add missing void return >> type. >> * gcc.target/x86_64/abi/avx512f/avx512f-check.h (main): Call >> __builtin_printf instead of printf. >> * gcc.target/x86_64/abi/avx512f/test_passing_m512.c >> (fun_check_passing_m512_8_values): Add missing void return >> type. > > LGTM. I should have scrolled down further, there are more fixes required along the same lines. Still okay? Thanks, Florian --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-i386-Fix-C99-compatibility-issues-in-the-x86-64-AVX-.patch >From 3a6df3281a525ae6113f50d7b38b09fcd803801e Mon Sep 17 00:00:00 2001 Message-ID: <3a6df3281a525ae6113f50d7b38b09fcd803801e.1699522355.git.fweimer@redhat.com> From: Florian Weimer Date: Wed, 8 Nov 2023 15:14:40 +0100 Subject: [PATCH] i386: Fix C99 compatibility issues in the x86-64 AVX ABI test suite Content-type: text/plain To: gcc-patches@gcc.gnu.org gcc/testsuite/ * gcc.target/x86_64/abi/avx/avx-check.h (main): Call __builtin_printf instead of printf. * gcc.target/x86_64/abi/avx/test_passing_m256.c (fun_check_passing_m256_8_values): Add missing void return type. * gcc.target/x86_64/abi/avx512f/avx512f-check.h (main): Call __builtin_printf instead of printf. * gcc.target/x86_64/abi/avx512f/test_passing_m512.c (fun_check_passing_m512_8_values): Add missing void return type. * gcc.target/x86_64/abi/bf16/bf16-check.h (main): Call __builtin_printf instead of printf. * gcc.target/x86_64/abi/bf16/m256bf16/bf16-ymm-check.h (main): Likewise. * gcc.target/x86_64/abi/bf16/m256bf16/test_passing_m256.c (fun_check_passing_m256bf16_8_values): Add missing void return type. * gcc.target/x86_64/abi/bf16/m512bf16/bf16-zmm-check.h (main): Call __builtin_printf instead of printf. * gcc.target/x86_64/abi/bf16/m512bf16/test_passing_m512.c (fun_check_passing_m512bf16_8_values): Add missign void return type. --- gcc/testsuite/gcc.target/x86_64/abi/avx/avx-check.h | 4 ++-- gcc/testsuite/gcc.target/x86_64/abi/avx/test_passing_m256.c | 1 + gcc/testsuite/gcc.target/x86_64/abi/avx512f/avx512f-check.h | 6 +++--- .../gcc.target/x86_64/abi/avx512f/test_passing_m512.c | 1 + gcc/testsuite/gcc.target/x86_64/abi/bf16/bf16-check.h | 4 ++-- .../gcc.target/x86_64/abi/bf16/m256bf16/bf16-ymm-check.h | 4 ++-- .../gcc.target/x86_64/abi/bf16/m256bf16/test_passing_m256.c | 1 + .../gcc.target/x86_64/abi/bf16/m512bf16/bf16-zmm-check.h | 4 ++-- .../gcc.target/x86_64/abi/bf16/m512bf16/test_passing_m512.c | 1 + 9 files changed, 15 insertions(+), 11 deletions(-) diff --git a/gcc/testsuite/gcc.target/x86_64/abi/avx/avx-check.h b/gcc/testsuite/gcc.target/x86_64/abi/avx/avx-check.h index e66a27e9afd..a04d0777637 100644 --- a/gcc/testsuite/gcc.target/x86_64/abi/avx/avx-check.h +++ b/gcc/testsuite/gcc.target/x86_64/abi/avx/avx-check.h @@ -16,12 +16,12 @@ main () { avx_test (); #ifdef DEBUG - printf ("PASSED\n"); + __builtin_printf ("PASSED\n"); #endif } #ifdef DEBUG else - printf ("SKIPPED\n"); + __builtin_printf ("SKIPPED\n"); #endif return 0; diff --git a/gcc/testsuite/gcc.target/x86_64/abi/avx/test_passing_m256.c b/gcc/testsuite/gcc.target/x86_64/abi/avx/test_passing_m256.c index ffc3ec36bf7..f739670431b 100644 --- a/gcc/testsuite/gcc.target/x86_64/abi/avx/test_passing_m256.c +++ b/gcc/testsuite/gcc.target/x86_64/abi/avx/test_passing_m256.c @@ -24,6 +24,7 @@ int failed = 0; assert (memcmp (&X1, &X2, sizeof (T)) == 0); \ } while (0) +void fun_check_passing_m256_8_values (__m256 i0 ATTRIBUTE_UNUSED, __m256 i1 ATTRIBUTE_UNUSED, __m256 i2 ATTRIBUTE_UNUSED, __m256 i3 ATTRIBUTE_UNUSED, __m256 i4 ATTRIBUTE_UNUSED, __m256 i5 ATTRIBUTE_UNUSED, __m256 i6 ATTRIBUTE_UNUSED, __m256 i7 ATTRIBUTE_UNUSED) { /* Check argument values. */ diff --git a/gcc/testsuite/gcc.target/x86_64/abi/avx512f/avx512f-check.h b/gcc/testsuite/gcc.target/x86_64/abi/avx512f/avx512f-check.h index 25ce544c4a3..00a7578d2b5 100644 --- a/gcc/testsuite/gcc.target/x86_64/abi/avx512f/avx512f-check.h +++ b/gcc/testsuite/gcc.target/x86_64/abi/avx512f/avx512f-check.h @@ -24,17 +24,17 @@ main () { avx512f_test (); #ifdef DEBUG - printf ("PASSED\n"); + __builtin_printf ("PASSED\n"); #endif } #ifdef DEBUG else - printf ("SKIPPED\n"); + __builtin_printf ("SKIPPED\n"); #endif } #ifdef DEBUG else - printf ("SKIPPED\n"); + __builtin_printf ("SKIPPED\n"); #endif return 0; diff --git a/gcc/testsuite/gcc.target/x86_64/abi/avx512f/test_passing_m512.c b/gcc/testsuite/gcc.target/x86_64/abi/avx512f/test_passing_m512.c index ead9c6797e1..1c88a55fb4b 100644 --- a/gcc/testsuite/gcc.target/x86_64/abi/avx512f/test_passing_m512.c +++ b/gcc/testsuite/gcc.target/x86_64/abi/avx512f/test_passing_m512.c @@ -24,6 +24,7 @@ int failed = 0; assert (memcmp (&X1, &X2, sizeof (T)) == 0); \ } while (0) +void fun_check_passing_m512_8_values (__m512 i0 ATTRIBUTE_UNUSED, __m512 i1 ATTRIBUTE_UNUSED, __m512 i2 ATTRIBUTE_UNUSED, __m512 i3 ATTRIBUTE_UNUSED, __m512 i4 ATTRIBUTE_UNUSED, __m512 i5 ATTRIBUTE_UNUSED, __m512 i6 ATTRIBUTE_UNUSED, __m512 i7 ATTRIBUTE_UNUSED) { /* Check argument values. */ diff --git a/gcc/testsuite/gcc.target/x86_64/abi/bf16/bf16-check.h b/gcc/testsuite/gcc.target/x86_64/abi/bf16/bf16-check.h index 25448fc6863..5db94a26c08 100644 --- a/gcc/testsuite/gcc.target/x86_64/abi/bf16/bf16-check.h +++ b/gcc/testsuite/gcc.target/x86_64/abi/bf16/bf16-check.h @@ -11,13 +11,13 @@ main () { do_test (); #ifdef DEBUG - printf ("PASSED\n"); + __builtin_printf ("PASSED\n"); #endif return 0; } #ifdef DEBUG - printf ("SKIPPED\n"); + __builtin_printf ("SKIPPED\n"); #endif return 0; diff --git a/gcc/testsuite/gcc.target/x86_64/abi/bf16/m256bf16/bf16-ymm-check.h b/gcc/testsuite/gcc.target/x86_64/abi/bf16/m256bf16/bf16-ymm-check.h index 479ebc3ec3f..81564f02e7a 100644 --- a/gcc/testsuite/gcc.target/x86_64/abi/bf16/m256bf16/bf16-ymm-check.h +++ b/gcc/testsuite/gcc.target/x86_64/abi/bf16/m256bf16/bf16-ymm-check.h @@ -11,13 +11,13 @@ main () { do_test (); #ifdef DEBUG - printf ("PASSED\n"); + __builtin_printf ("PASSED\n"); #endif return 0; } #ifdef DEBUG - printf ("SKIPPED\n"); + __builtin_printf ("SKIPPED\n"); #endif return 0; diff --git a/gcc/testsuite/gcc.target/x86_64/abi/bf16/m256bf16/test_passing_m256.c b/gcc/testsuite/gcc.target/x86_64/abi/bf16/m256bf16/test_passing_m256.c index 3fb2d7d20f8..34e97332272 100644 --- a/gcc/testsuite/gcc.target/x86_64/abi/bf16/m256bf16/test_passing_m256.c +++ b/gcc/testsuite/gcc.target/x86_64/abi/bf16/m256bf16/test_passing_m256.c @@ -25,6 +25,7 @@ int failed = 0; assert (memcmp (&X1, &X2, sizeof (T)) == 0); \ } while (0) +void fun_check_passing_m256bf16_8_values (__m256bf16 i0 ATTRIBUTE_UNUSED, __m256bf16 i1 ATTRIBUTE_UNUSED, __m256bf16 i2 ATTRIBUTE_UNUSED, diff --git a/gcc/testsuite/gcc.target/x86_64/abi/bf16/m512bf16/bf16-zmm-check.h b/gcc/testsuite/gcc.target/x86_64/abi/bf16/m512bf16/bf16-zmm-check.h index 9cd39b878dd..b3e13829535 100644 --- a/gcc/testsuite/gcc.target/x86_64/abi/bf16/m512bf16/bf16-zmm-check.h +++ b/gcc/testsuite/gcc.target/x86_64/abi/bf16/m512bf16/bf16-zmm-check.h @@ -11,13 +11,13 @@ main () { do_test (); #ifdef DEBUG - printf ("PASSED\n"); + __builtin_printf ("PASSED\n"); #endif return 0; } #ifdef DEBUG - printf ("SKIPPED\n"); + __builtin_printf ("SKIPPED\n"); #endif return 0; diff --git a/gcc/testsuite/gcc.target/x86_64/abi/bf16/m512bf16/test_passing_m512.c b/gcc/testsuite/gcc.target/x86_64/abi/bf16/m512bf16/test_passing_m512.c index 1c5c407efee..b06b90a7478 100644 --- a/gcc/testsuite/gcc.target/x86_64/abi/bf16/m512bf16/test_passing_m512.c +++ b/gcc/testsuite/gcc.target/x86_64/abi/bf16/m512bf16/test_passing_m512.c @@ -25,6 +25,7 @@ int failed = 0; assert (memcmp (&X1, &X2, sizeof (T)) == 0); \ } while (0) +void fun_check_passing_m512bf16_8_values (__m512bf16 i0 ATTRIBUTE_UNUSED, __m512bf16 i1 ATTRIBUTE_UNUSED, __m512bf16 i2 ATTRIBUTE_UNUSED, -- 2.41.0 --=-=-=--