From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id F14373858D32 for ; Mon, 2 Jan 2023 10:42:54 +0000 (GMT) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3021lPtt013890; Mon, 2 Jan 2023 10:42:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=references : from : to : cc : subject : in-reply-to : date : message-id : content-type : mime-version; s=corp-2022-7-12; bh=Yp+DpY4LT8WmSvEdf0eMP9MY8HQVWER4km6k5r8xTY4=; b=aV0fKN8rOlfL5kPs6Lx9nfLOCn3EmMW4+Nmao4XV0XjGAjdQPbVlwV7HwE9Mufh5rurz trUdYT21b3JQLNcbX67PNAtVmBug6xz8L4X+yiFoTtnq3/f3M/R8CLOziq8biUlx5kBm 0fuoukyCqUnCYq8V5FI2vdlbMUSgOWReSIBE5obTw1KtD3605IbGRtgR7PPUf+pPFYL4 Y8sz1T7UCDm6mc1vOdIqVYUb9gXuk3xnvlW0x8QulA6PJsIfA3PZimM5ydjSYP5VWjBF syq+XmDCxM/SDIkyioPHaal2ZCE3sF8UMwm1tnjhN6FLR/jG1hU+5g4eH68EI6H1Y8vb VA== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3mtbv2t74q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 02 Jan 2023 10:42:54 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 3028uKgD033596; Mon, 2 Jan 2023 10:42:53 GMT Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam04lp2176.outbound.protection.outlook.com [104.47.73.176]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3mtbh3mev3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 02 Jan 2023 10:42:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LYrNj+P+XDZANQoJLQT6/KTq7J5YLe4GJQ359PBsODNT7K0+k1uz07z4VK9Xpd9bVW5fUuF+6BpT+GYPrhGFcLfJlRgH+outHcxMocLQS1vTPbcc0majfxsaLNVQ8U17gD+VwuSyYIJydHDmfKH1SU5fqv2tWrCuDkisnfu8Q6c5kBYO+oKfYErLy7YEHRXwafVDfYfij4OYLuL1r4b0KAbW/QUDZgKtEUqbd20iHbtBtFs3WxFVahFOj7h8UHenMv+Jomqy3TJlgH9J2uO25n3lBBCzshH3YFuHl2cZ+NNiJbmx5AcO6UZwoEnHaKJsqP6ozfPGobCBzfP0YCF2NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Yp+DpY4LT8WmSvEdf0eMP9MY8HQVWER4km6k5r8xTY4=; b=CtgpW17K8abtaHmRHAk1bVVqOW4GZ4VbFZaWRXxLPyCG6jMwCYVOWDN/8CLPbrwiJt/GmIgV3sLxyj2qgta0EeA22h9vxgHvv9lokR2aQ4phxO5wbiwYKIJENElKzZLDSlPPiR/grvf1Uffh62Kq3lJ5NgjJf6aJqlc8AjUA0SRXdkYuXPANTAvGcPzYTONCqujSmEDKuTasfytoDnQ08j8scuRtioRl3mDSWVZSiZL50ryYMjfFnuTh8ldyUN3GO+cjZ59bUro+5S/Em9V3V64vFfmQx5UkE0P9SQkvwIrCuU3nNzzCCg5l1doIrErhW26fr6flqvG9Hkpd55XF4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yp+DpY4LT8WmSvEdf0eMP9MY8HQVWER4km6k5r8xTY4=; b=UeBPKKB2PdCyuy6tQLW2b83ZaHGfsFc5qt+9snIJJAeoSU3QvPTHi6v6G9+4imY2j4TGl285tZ5ukjTTeVOfMdm3BBlQt3CDulC7/XK19LU5dK7MhQeXF36wiEpqKX+jZTPANNRR2ZEM3NKpZwlZ5iEr7Csro19RAi4kISpgPgg= Received: from BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) by DS7PR10MB5949.namprd10.prod.outlook.com (2603:10b6:8:86::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Mon, 2 Jan 2023 10:42:51 +0000 Received: from BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::8681:5931:e558:2638]) by BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::8681:5931:e558:2638%7]) with mapi id 15.20.5944.019; Mon, 2 Jan 2023 10:42:50 +0000 References: <20221202175225.2780-1-cupertino.miranda@oracle.com> <20221202175225.2780-2-cupertino.miranda@oracle.com> <878rjj5jug.fsf@oracle.com> <87o7s52cv0.fsf@oracle.com> <87zgbfz75a.fsf@oracle.com> User-agent: mu4e 1.4.15; emacs 28.1 From: Cupertino Miranda To: Cupertino Miranda Cc: Jeff Law , jose.marchesi@oracle.com, gcc-patches@gcc.gnu.org Subject: Re: [PING] Re: [PATCH 1/2] select .rodata for const volatile variables. In-reply-to: <87zgbfz75a.fsf@oracle.com> Date: Mon, 02 Jan 2023 10:42:45 +0000 Message-ID: <87pmbxnroa.fsf@oracle.com> Content-Type: text/plain X-ClientProxiedBy: LO4P123CA0054.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:152::23) To BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN6PR1001MB2340:EE_|DS7PR10MB5949:EE_ X-MS-Office365-Filtering-Correlation-Id: 955eeaab-a2ad-42e9-a5a2-08daecae1886 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: V1uZgoy+jK281ix10JZyede9/mAoirB5sCk7/qfNo3fpN27BIKDBJBKsOvpB1N3CVGnFrffM/E9iGA0yko8RN6KV5crevA97IKpc2O4DFGrWTyYXuf/zt5LYE/D0Zthc8upwy6OY4s5mf5pCThWRP5CJOsMFJr66LWCgbfSD40fEgFavKQ8T9jgxJfhNfM0tf6+A2UWFR27MOVAkLfYpQ0e2fEoPJ4CQ9WGS0piSpxgd1Zd0GmOiHWsJH3JhfdRLhHwZHKpbuo9ZXqyrtNErKKzgG+v6LxWm/SuLixYEGd0YbmBgapTCkKI2iCh2fyv69G4KAfRHakE0W327eIqf9JpXGHBkEBgRtxjCwljFxP4UVKe2VuCcChNv0C6QdfWJoF5wLrBaCMAtEK1D5KH0oyHgLQnl+GB+/FoU1GfDvA4l4eib/PEdcV1BDZXNOhP5mia6cN3oTjgFhN4dzorDPsoQ+H8SERa+LFGz+QBPQL0mQwypEj/VESBrN6YYytqCD6sH4V2y94z0sxAsuBFt02TxM3R+/dqqbKeSzBgaCJvBsBt93hKxwbA9vdjaOlEn+CU0ucozL4luJv2twqLIhQatFcY+FMdXp2DD85I7iwYxShMGKEDtGfKduu4VBoJY08HTYztXdSKMWu5Z+fyZ4MKOjpvyNM2urqhmw7LpqJR7kuI8HcimraO1QbGbw6Kj2my+6uu8cXVs6LQGnEAaagKgzpI/+nM9YL1xYAUNllDmt5Xa5Pw3YmYHp6MTQLXiw7TJUoeONngTSf+fvsarYiX+z3ez/UPKbE0r2ncO5to= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR1001MB2340.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(376002)(136003)(396003)(366004)(39860400002)(451199015)(186003)(6512007)(83380400001)(2616005)(44832011)(86362001)(36756003)(38100700002)(66556008)(316002)(2906002)(37006003)(6862004)(4326008)(66946007)(41300700001)(8936002)(5660300002)(8676002)(66476007)(478600001)(6666004)(6486002)(53546011)(6200100001)(6506007)(966005)(22166006)(142923001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?thax0ptwEznw+KWD23Aj7qDnkwc4YIrXcy7O2hqNKZ4aQsPui5VQIZVytvo0?= =?us-ascii?Q?G3AS3pX7uixKj5gXaSlVvJWaA/zixAM0og8r3IiefOX3/AbaPjKS6PGuG3Ub?= =?us-ascii?Q?VIvqzfNtZFgxT+u3YO8nQBwZFtc2n0Jz6R9OIhkGOlg69cfZBPS29Sg4PX2M?= =?us-ascii?Q?BYL4S2T37qck8EtjVg8Vl0a9njcIaQa3/XNBP9ofpaJBPr+cS4ka6ZFEQEt0?= =?us-ascii?Q?U9C42eixIAKeyJBv+YbcEOb+gc05z9iUS9gYqWDGYYqCYbc6MKBq+/qLMdwT?= =?us-ascii?Q?kiBucbQGbAHkZqThykkAr4frl7y5NUFH00hJKZ8MV+G/Bu9Ki3wmJldFxsEh?= =?us-ascii?Q?U0Lo2/3X/cJnRXF8P64dnB5m23eA7xnaqXr6DwvzmEMsX695zFmDIY289fUi?= =?us-ascii?Q?2PKJPWblVP5Nrw8r7nLHgeDhmIeIjxHYOqfBFLH51SXOuzUcsNz6doJYb74m?= =?us-ascii?Q?fDW0jgWUyGwWxQx2IrgEtFpRZl9/h/74DEknttfmPxvKlLYRpl5a8w2Qzr6j?= =?us-ascii?Q?zy8g7BZ1o8QWZLWIOk+1Izzj9SGYhC7iuFUWuPGq6b+IBjOXssupKO39VCw2?= =?us-ascii?Q?PG82nGT2PqWDxCOLxvu7MHQEFgwTcjXNiL+TNfIWmbOzSPTgwqJkYfSWxCfw?= =?us-ascii?Q?ffX7FDvPUqaVjElCx8ql97qOyXusRv4Iqe+hTXxP4Mkb34m7oGsS07YQZDi0?= =?us-ascii?Q?YKc8n5CDi1f44DR8ZemLJuRzmme0MusD0JiVpLTX0mI29rhP9GKEX81QPH5y?= =?us-ascii?Q?q9LBdWhWLfCiMU3KfVOSem2iknLdkucR3J3xEiImAjMRoxm0OrZ/4bBk/DBT?= =?us-ascii?Q?c8vyfQoh6Hr8G3whfvzH4VavUAVskw7XnDKjB3dQr9TJztUr1m35leLa3XiO?= =?us-ascii?Q?MMTmsnVKCEKbQzkffxAjoygIH6NqfbCwx+y2PORkEDj7OKBwIFNiOONetUEg?= =?us-ascii?Q?7RvWwkDHDmh8uRPDQUXeRFAz2u7Tk4dQHsAlrVS73a5W4JFSuoU0p5d+u20/?= =?us-ascii?Q?NgrlvYLIZ8Qn9r5ZnLDyBsFZUjv77jJhKrC5yweM5/fymUWRvCn98zdpu/LQ?= =?us-ascii?Q?bfug+blsD7GgyOcyi4zPnF05184NpyHkKT493Ix3cD+RIJGC4cgrRp77OEf1?= =?us-ascii?Q?PbaZAencX2IxdMMQbwyj3rtzQNPg5lYvB69+KZ+qq4GGjVgpdFZIN+M17JkD?= =?us-ascii?Q?smXJgZ3ixyfkOdWpeiQ+PHV84f57wXlP6q9TDF80SwuhtV7luz07D4NXW/se?= =?us-ascii?Q?E1+6LVX+X8a06N1VooveP5SYBR1c/GLs4T8XvUu6FmIY/NRNUoRJQA3eCHrK?= =?us-ascii?Q?99iWovsawNZPaVsKT3+PzuTu2lMICSDd5lgklnRq8YI0LExMvIXTsOWyp2Ln?= =?us-ascii?Q?d8B3Lin3bPf84yytbRXxku8KJmwdomFcdZcjrrrp6FQCKxtD7Itdy6Qh9Qd3?= =?us-ascii?Q?RrSfCHY/lG7Zy4JkaHHwDW+OfYffAFvrxb0DxziY4da56aF6O3ZKVatPrztH?= =?us-ascii?Q?3x29ON0k9ADqeacbZD6N2IR0DqpA3BD4wAkUJtBog22oK8Tqj/XcXPcQgEJz?= =?us-ascii?Q?AxxN2gU0Aj0Mn22gImpiT/O3OYmHrnQ/JbTAiByZKh5ifhvSeWXuaOy74y9K?= =?us-ascii?Q?0PTnvrPjvLVMS4pS9xQnjaQ=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 955eeaab-a2ad-42e9-a5a2-08daecae1886 X-MS-Exchange-CrossTenant-AuthSource: BN6PR1001MB2340.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jan 2023 10:42:50.8475 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bEVqGjg4I21aBTCU8kkAv3utG0zZ39VRSSA97mbLBsVhuChfq4mgms1jl9aynlaC6swTIVYa87tO3ZgPqneOjZMvojd+7FhS8N4L3md05pw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5949 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-02_06,2022-12-30_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0 mlxscore=0 phishscore=0 adultscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301020097 X-Proofpoint-GUID: iryJhtUc83chlx4Ma-BZTFKQ5MUwjqHm X-Proofpoint-ORIG-GUID: iryJhtUc83chlx4Ma-BZTFKQ5MUwjqHm X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: PING PING Cupertino Miranda writes: > Cupertino Miranda via Gcc-patches writes: > >> gentle ping >> >> Cupertino Miranda writes: >> >>> Hi Jeff, >>> >>> First of all thanks for your quick review. >>> Apologies for the delay replying, the message got lost in my inbox. >>> >>>> On 12/2/22 10:52, Cupertino Miranda via Gcc-patches wrote: >>>>> Changed target code to select .rodata section for 'const volatile' >>>>> defined variables. >>>>> This change is in the context of the bugzilla #170181. >>>>> gcc/ChangeLog: >>>>> v850.c(v850_select_section): Changed function. >>>> I'm not sure this is safe/correct. ISTM that you need to look at the underlying >>>> TREE_TYPE to check for const-volatile rather than TREE_SIDE_EFFECTS. >>> >>> I believe this was asked by Jose when he first sent the generic patches. >>> Please notice my change is influenced by his original patch that does >>> the same and was approved. >>> >>> https://gcc.gnu.org/pipermail/gcc-patches/2022-August/599348.html >>> https://gcc.gnu.org/pipermail/gcc-patches/2022-September/602374.html >>> >>>> >>>> Of secondary importance is the ChangeLog. Just saying "Changed function" >>>> provides no real information. Something like this would be better: >>>> >>>> * config/v850/v850.c (v850_select_section): Put const volatile >>>> objects into read-only sections. >>>> >>>> >>>> Jeff >>>> >>>> >>>> >>>> >>>>> --- >>>>> gcc/config/v850/v850.cc | 1 - >>>>> 1 file changed, 1 deletion(-) >>>>> diff --git a/gcc/config/v850/v850.cc b/gcc/config/v850/v850.cc >>>>> index c7d432990ab..e66893fede4 100644 >>>>> --- a/gcc/config/v850/v850.cc >>>>> +++ b/gcc/config/v850/v850.cc >>>>> @@ -2865,7 +2865,6 @@ v850_select_section (tree exp, >>>>> { >>>>> int is_const; >>>>> if (!TREE_READONLY (exp) >>>>> - || TREE_SIDE_EFFECTS (exp) >>>>> || !DECL_INITIAL (exp) >>>>> || (DECL_INITIAL (exp) != error_mark_node >>>>> && !TREE_CONSTANT (DECL_INITIAL (exp))))