From: Florian Weimer <fweimer@redhat.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] c: Propagate erroneous types to declaration specifiers [PR107805]
Date: Thu, 24 Nov 2022 11:01:40 +0100 [thread overview]
Message-ID: <87pmdc658b.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <5350a633-56bb-cb4e-5e93-e6dce4b92a1@codesourcery.com> (Joseph Myers's message of "Tue, 22 Nov 2022 23:05:36 +0000")
* Joseph Myers:
> On Tue, 22 Nov 2022, Florian Weimer via Gcc-patches wrote:
>
>> Without this change, finish_declspecs cannot tell that whether there
>> was an erroneous type specified, or no type at all. This may result
>> in additional diagnostics for implicit ints, or missing diagnostics
>> for multiple types.
>>
>> PR c/107805
>>
>> gcc/c/
>> * c-decl.cc (declspecs_add_type): Propagate error_mark_bode
>> from type to specs.
>>
>> gcc/testsuite/
>> * gcc.dg/pr107805-1.c: New test.
>> * gcc.dg/pr107805-1.c: Likewise.
>
> OK.
Thanks. Permission to backport this to GCC 12 after a week or two?
Florian
next prev parent reply other threads:[~2022-11-24 10:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 12:21 Florian Weimer
2022-11-22 23:05 ` Joseph Myers
2022-11-24 10:01 ` Florian Weimer [this message]
2022-11-24 10:28 ` Jakub Jelinek
2022-11-24 10:53 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmdc658b.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).