Hi! On 2022-05-03T15:46:43+0200, Richard Biener wrote: > On Tue, May 3, 2022 at 2:29 PM Thomas Schwinge wrote: >> On 2022-05-03T12:53:50+0200, Richard Biener wrote: >> > On Tue, May 3, 2022 at 10:16 AM Thomas Schwinge wrote: >> >> On 2022-05-03T09:17:52+0200, Richard Biener wrote: >> >> > On Mon, May 2, 2022 at 4:01 PM Thomas Schwinge wrote: >> >> > +#if 0 >> >> > gcc_unreachable (); >> >> > +#else >> >> > + /* ..., but due to bugs (PR100400), we may actually come here. >> >> > + Reliably catch this, regardless of checking level. */ >> >> > + abort (); >> >> > +#endif >> >> > >> >> > this doesn't look correct. If you want a reliable diagnostic here please [...] >> >> > call internal_error () manually (the IL verifiers do this). >> >> >> >> Hmm, I feel I'm going in circles... ;-) >> >> I first had this as 'internal_error', but then saw the following source >> >> code comment, 'gcc/diagnostic.cc': >> >> >> >> /* An internal consistency check has failed. We make no attempt to >> >> continue. Note that unless there is debugging value to be had from >> >> a more specific message, or some other good reason, you should use >> >> abort () instead of calling this function directly. */ >> >> void >> >> internal_error (const char *gmsgid, ...) >> >> { >> >> >> >> Here, there's no "debugging value to be had from a more specific >> >> message", and I couldn't think of "some other good reason", so decided to >> >> "use abort () instead of calling this function directly". >> > >> > I think that is misguided. >> >> So that I know which one to fix/reconsider: does your "that" refer to the >> 'gcc/diagnostic.cc:internal_error' source code comment cited above, or my >> interpretation of it? > > The comment to "use abort ()". Does the attached "Advise to call 'internal_error' instead of 'abort' or 'fancy_abort'" capture what you had in mind? (This is, obviously, not updating any of the many 'abort' or even a few 'fancy_abort' calls that we currently have.) Grüße Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955