Re: [PATCH] fix ICE in generic_overlap (PR 84526)

[Richard Sandiford <richard.sandiford@googlemail.com>]

Martin Sebor <msebor@gmail.com> writes:
> +  /* Convert the poly_int64 offset to to offset_int.  The offset
> +     should be constant but be prepared for it not to be just in
> +     case.  */

This comment seems redundant and could easily get out of date once
ACLE support is added.

> +  offset_int cstoff;
> +  if (bytepos.is_constant (&cstoff))
>      {

> -      base = get_base_address (TREE_OPERAND (expr, 0));
> -      return;
> +      offrange[0] += cstoff;
> +      offrange[1] += cstoff;

Although this looks right, there's no actual need for cstoff to be
offset_int here, and I think the original HOST_WIDE_INT was more
efficient.

I realise you reuse the cstoff variable later with wi::to_offset,
but it doesn't seem necessary to use the same variable, since it's
logically a separate value.

Either way's fine, just thought I'd mention it :-)

Thanks,
Richard