From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84142 invoked by alias); 9 Oct 2015 15:07:25 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 84129 invoked by uid 89); 9 Oct 2015 15:07:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (146.101.78.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Oct 2015 15:07:22 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-9-7UhSkKLRTSCZzEolLys4WQ-1; Fri, 09 Oct 2015 16:07:17 +0100 Received: from localhost ([10.1.2.79]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 9 Oct 2015 16:07:16 +0100 From: Richard Sandiford To: Christophe Lyon Mail-Followup-To: Christophe Lyon ,"gcc-patches\@gcc.gnu.org" , richard.sandiford@arm.com Cc: "gcc-patches\@gcc.gnu.org" Subject: Re: Move sqrt and cbrt simplifications to match.pd References: <87k2r1bb0p.fsf@e105548-lin.cambridge.arm.com> <87twq19u6s.fsf@e105548-lin.cambridge.arm.com> Date: Fri, 09 Oct 2015 15:07:00 -0000 In-Reply-To: (Christophe Lyon's message of "Fri, 9 Oct 2015 15:35:44 +0100") Message-ID: <87pp0o9j2z.fsf@e105548-lin.cambridge.arm.com> User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-MC-Unique: 7UhSkKLRTSCZzEolLys4WQ-1 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2015-10/txt/msg00989.txt.bz2 Christophe Lyon writes: > On 8 October 2015 at 18:55, Richard Sandiford = wrote: >> Marc Glisse writes: >>> On Mon, 5 Oct 2015, Richard Sandiford wrote: >>> >>>> + /* cbrt(sqrt(x)) -> pow(x,1/6). */ >>>> + (simplify >>>> + (sqrts (cbrts @0)) >>>> + (pows @0 { build_real_truncate (type, dconst<1, 6> ()); })) >>>> + /* sqrt(cbrt(x)) -> pow(x,1/6). */ >>>> + (simplify >>>> + (cbrts (sqrts @0)) >>>> + (pows @0 { build_real_truncate (type, dconst<1, 6> ()); })) >>> >>> I think you swapped the comments (not that it matters). >> >> Thanks, fixed in the committed version. >> >> Richard >> > Hi Richard, > > Since you committed this patch, I've noticed that gcc.dg/builtins-10.c fa= ils > on arm-none-linux-gnueabi targets (as opposed to arm-none-linux-gnueabihf= ). > > gcc.log shows: > /cchfHDHc.o: In function `test': > builtins-10.c:(.text+0x60): undefined reference to `link_error' > collect2: error: ld returned 1 exit status Looks like this is the same fold_strip_sign_ops problem that I was seeing with some WIP follow-on patches. We don't fold pow(abs(x), 4) to pow(x, 4). Hope to have a fix soon. Thanks, Richard