From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21557 invoked by alias); 4 Oct 2014 10:32:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 21545 invoked by uid 89); 4 Oct 2014 10:32:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wg0-f43.google.com Received: from mail-wg0-f43.google.com (HELO mail-wg0-f43.google.com) (74.125.82.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 04 Oct 2014 10:32:25 +0000 Received: by mail-wg0-f43.google.com with SMTP id m15so3205787wgh.26 for ; Sat, 04 Oct 2014 03:32:22 -0700 (PDT) X-Received: by 10.194.3.42 with SMTP id 10mr14279521wjz.98.1412418742220; Sat, 04 Oct 2014 03:32:22 -0700 (PDT) Received: from localhost ([95.144.14.224]) by mx.google.com with ESMTPSA id n5sm4631748wix.0.2014.10.04.03.32.21 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 Oct 2014 03:32:21 -0700 (PDT) From: Richard Sandiford To: Jakub Jelinek Mail-Followup-To: Jakub Jelinek ,Segher Boessenkool , Andrew MacLeod , Bernd Schmidt , gcc-patches , richard.sandiford@arm.com, rdsandiford@googlemail.com Cc: Segher Boessenkool , Andrew MacLeod , Bernd Schmidt , gcc-patches , richard.sandiford@arm.com Subject: Re: parallel check output changes? References: <541AD880.7080703@redhat.com> <541AF451.3070406@redhat.com> <541B1710.8060809@codesourcery.com> <20140918173609.GM17454@tucnak.redhat.com> <20140918184455.GB28595@gate.crashing.org> <20140919093723.GA26414@gate.crashing.org> <87iokel5c0.fsf@e105548-lin.cambridge.arm.com> <5422DB41.1090800@redhat.com> <20141002164739.GA25260@gate.crashing.org> <871tqqnz4k.fsf@googlemail.com> <20141002175950.GJ1986@tucnak.redhat.com> Date: Sat, 04 Oct 2014 10:32:00 -0000 In-Reply-To: <20141002175950.GJ1986@tucnak.redhat.com> (Jakub Jelinek's message of "Thu, 2 Oct 2014 19:59:50 +0200") Message-ID: <87ppe8m8gb.fsf@googlemail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-10/txt/msg00370.txt.bz2 Jakub Jelinek writes: >> make the result of combining separate .sum files the same as the .sum >> file you'd get for -j1. As Jakub said upthread, that's a lost cause >> with the new approach to parallel testing, but I think the comment was >> valid while matching -j1 was still a goal. > > I'm sorry for invalidating those assumptions. Indeed, before my recent > changes, all tests for the same testcase name were run serially by the same > job. If we wanted to preserve that property, we could e.g. store the > results of gcc_parallel_test_run_p in some tcl array with testcase as the > key, and after the > if { $gcc_runtest_parallelize_enable == 0 } { > return 1 > } > test add a test if we've been asked about a particular testcase already, > just return what we've returned before. Perhaps accompany that with > lowering the granularity (e.g. from 10 to 5). That sounds like it'd help if we have any lingering cases where the text after the PASS: etc. isn't unique, since otherwise it's probably unpredictable which one comes first in the combined summary (as it was when the test order was still keyed only off filename). OTOH I suppose we should just fix those tests so that the name is unique. Also, now that even partial RUNTESTFLAGS-based testuite runs can be fully parallelised (very nice, thanks), what -j1 did is probably no longer relevant anyway. Thanks, Richard