From: Nick Clifton <nickc@redhat.com>
To: janis_johnson@mentor.com
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [testsuite] replace gcc.target/arm/ftest-*.c with compile-only tests
Date: Wed, 16 Jan 2013 13:57:00 -0000 [thread overview]
Message-ID: <87pq1544l1.fsf@redhat.com> (raw)
Hi Janis,
> The gcc.target/arm/ftest-*.c tests check various macros that are set for
> ARM targets by setting flags based on preprocessor directives that check
> those macros. The tests are skipped if the current test platform
> doesn't support executing programs for the architecture for which flags
> are being checked. There are several problems with these tests:
I like most of this patch. The only part I am unhappy with is the new
dg-skip-if statements to skip the test when -march or -mthumb is
specified as part of the overall command line. I think that the
current dg-require-effective-target statements are enough. Can you
provide an example of a case where they do not work ?
Cheers
Nick
next reply other threads:[~2013-01-16 13:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 13:57 Nick Clifton [this message]
2013-01-16 17:58 ` Janis Johnson
2013-01-17 15:06 ` nick clifton
-- strict thread matches above, loose matches on Subject: below --
2012-12-21 19:03 Janis Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pq1544l1.fsf@redhat.com \
--to=nickc@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=janis_johnson@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).