From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12397 invoked by alias); 30 Sep 2012 09:02:00 -0000 Received: (qmail 12387 invoked by uid 22791); 30 Sep 2012 09:01:59 -0000 X-SWARE-Spam-Status: No, hits=-4.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_ZJ X-Spam-Check-By: sourceware.org Received: from mail-we0-f175.google.com (HELO mail-we0-f175.google.com) (74.125.82.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 30 Sep 2012 09:01:53 +0000 Received: by weyt44 with SMTP id t44so2577335wey.20 for ; Sun, 30 Sep 2012 02:01:52 -0700 (PDT) Received: by 10.180.8.161 with SMTP id s1mr8738005wia.0.1348995712614; Sun, 30 Sep 2012 02:01:52 -0700 (PDT) Received: from localhost ([2.26.188.227]) by mx.google.com with ESMTPS id ct3sm9628371wib.5.2012.09.30.02.01.50 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 30 Sep 2012 02:01:51 -0700 (PDT) From: Richard Sandiford To: Uros Bizjak Mail-Followup-To: Uros Bizjak ,Jakub Jelinek , gcc-patches@gcc.gnu.org, Eric Botcazou , rdsandiford@googlemail.com Cc: Jakub Jelinek , gcc-patches@gcc.gnu.org, Eric Botcazou Subject: Re: [PATCH v2, rtl-optimization]: Fix PR54457, [x32] Fail to combine 64bit index + constant References: <877grgu0yt.fsf@talisman.home> <3730255.NiV98gQJ1a@polaris> <20120927182008.GZ1787@tucnak.redhat.com> Date: Sun, 30 Sep 2012 11:40:00 -0000 In-Reply-To: (Uros Bizjak's message of "Fri, 28 Sep 2012 17:32:08 +0200") Message-ID: <87pq53sx2q.fsf@talisman.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-09/txt/msg01971.txt.bz2 Uros Bizjak writes: > On Thu, Sep 27, 2012 at 8:20 PM, Jakub Jelinek wrote: >> On Thu, Sep 27, 2012 at 08:04:58PM +0200, Uros Bizjak wrote: >>> After some off-line discussion with Richard, attached is v2 of the patch. >>> >>> 2012-09-27 Uros Bizjak >>> >>> PR rtl-optimization/54457 >>> * simplify-rtx.c (simplify_subreg): >>> Simplify (subreg:SI (op:DI ((x:DI) (y:DI)), 0) >>> to (op:SI (subreg:SI (x:DI) 0) (subreg:SI (x:DI) 0)). >> >> Is that a good idea even for WORD_REGISTER_OPERATIONS targets? > > I have bootstrapped and regtested [1] the patch on > alphaev68-pc-linux-gnu, a WORD_REGISTER_OPERATIONS target, and there > were no additional failures. Thanks. Given Jakub's question/concern, I'd really prefer a third opinion rather than approving it myself, but... OK if no-one objects within 24hrs. Richard