From: Andi Kleen <andi@firstfloor.org>
To: Richard Guenther <richard.guenther@gmail.com>
Cc: gcc-patches@gcc.gnu.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/2] Fix -fno-lto (PR lto/46905)
Date: Thu, 16 Dec 2010 13:30:00 -0000 [thread overview]
Message-ID: <87pqt1hn1e.fsf@basil.nowhere.org> (raw)
In-Reply-To: <AANLkTim85WdOAGw121Pt4QiPNkrQ5jXwrwBj1za5J78C@mail.gmail.com> (Richard Guenther's message of "Thu, 16 Dec 2010 14:17:05 +0100")
Richard Guenther <richard.guenther@gmail.com> writes:
> On Thu, Dec 16, 2010 at 1:41 PM, Andi Kleen <andi@firstfloor.org> wrote:
>> From: Andi Kleen <ak@linux.intel.com>
>>
>> This fixes PR lto/46905.
>>
>> It's sometimes convenient in large Makefiles to globally enable LTO
>> in CFLAGS, but disable it again for specific files. The simplest
>> way to do that is appending -fno-lto, but that didn't work.
>> Add explicit code to handle this case.
>>
>> Passes bootstrap and full test on x86_64-linux. Ok?
>
> Do you really need the common.opt and opts.c hunks?
Yes. The previous state without them didn't work.
I also tried to do it without opts.c, but setting an 0 initialization
value for the -fno-lto entry, but that didn't work either.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2010-12-16 13:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 13:25 Andi Kleen
2010-12-16 13:26 ` [PATCH 2/2] Improve reporting of section conflict errors Andi Kleen
2010-12-16 13:32 ` Richard Guenther
2010-12-16 15:39 ` Andi Kleen
2010-12-16 15:46 ` Richard Guenther
2010-12-16 15:53 ` Andi Kleen
2010-12-16 16:56 ` Joseph S. Myers
2010-12-16 17:24 ` Andi Kleen
2010-12-16 20:37 ` H.J. Lu
2010-12-16 14:01 ` Nathan Froyd
2010-12-16 13:29 ` [PATCH 1/2] Fix -fno-lto (PR lto/46905) Richard Guenther
2010-12-16 13:30 ` Andi Kleen [this message]
2010-12-16 13:45 ` Richard Guenther
2010-12-16 16:09 ` Jan Hubicka
2010-12-16 16:44 ` Joseph S. Myers
2010-12-16 18:14 ` Andi Kleen
2010-12-18 20:44 ` Richard Guenther
2010-12-20 5:05 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pqt1hn1e.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=ak@linux.intel.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).