From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20999 invoked by alias); 16 Dec 2010 13:20:41 -0000 Received: (qmail 20896 invoked by uid 22791); 16 Dec 2010 13:20:40 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from one.firstfloor.org (HELO one.firstfloor.org) (213.235.205.2) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 16 Dec 2010 13:20:36 +0000 Received: from basil.firstfloor.org (p5B3C96B7.dip0.t-ipconnect.de [91.60.150.183]) by one.firstfloor.org (Postfix) with ESMTP id C4A5C1A98052; Thu, 16 Dec 2010 14:20:33 +0100 (CET) Received: by basil.firstfloor.org (Postfix, from userid 1000) id D83CBB27C4; Thu, 16 Dec 2010 14:20:30 +0100 (CET) From: Andi Kleen To: Richard Guenther Cc: gcc-patches@gcc.gnu.org, Andi Kleen Subject: Re: [PATCH 1/2] Fix -fno-lto (PR lto/46905) References: <1292503308-11258-1-git-send-email-andi@firstfloor.org> Date: Thu, 16 Dec 2010 13:30:00 -0000 In-Reply-To: (Richard Guenther's message of "Thu, 16 Dec 2010 14:17:05 +0100") Message-ID: <87pqt1hn1e.fsf@basil.nowhere.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-12/txt/msg01303.txt.bz2 Richard Guenther writes: > On Thu, Dec 16, 2010 at 1:41 PM, Andi Kleen wrote: >> From: Andi Kleen >> >> This fixes PR lto/46905. >> >> It's sometimes convenient in large Makefiles to globally enable LTO >> in CFLAGS, but disable it again for specific files. The simplest >> way to do that is appending -fno-lto, but that didn't work. >> Add explicit code to handle this case. >> >> Passes bootstrap and full test on x86_64-linux. Ok? > > Do you really need the common.opt and opts.c hunks? Yes. The previous state without them didn't work. I also tried to do it without opts.c, but setting an 0 initialization value for the -fno-lto entry, but that didn't work either. -Andi -- ak@linux.intel.com -- Speaking for myself only.