From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 5582B385B83E for ; Fri, 28 Oct 2022 09:00:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5582B385B83E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.95,220,1661846400"; d="scan'208";a="85730039" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 28 Oct 2022 01:00:31 -0800 IronPort-SDR: DYqVgCfivtA7XFhNv1NJxsQU8IIvSf6Qnjv6oRnTrsRaIx5kaiPy0VPdvH6wk4eIMCL+PfFJoD +98yvCtZaeJFOqikIQp7jLrYlBM4545Z+nJs1N7xaMBPdkxfCyum0wL1reALKjRyIv1UMNLZZs kX9JVBp7pZSiWRQ7/caH9ZaEDe/c7H9oNk3jNUE8b9xuq59KAoMB7gT6sFbB29VPYaH33N5hPx yRrTEnChvUsS8PilJmV+rgyd8pOpVZ3JULOCuXU2HortW/FtGNaYnym3OMnyBOBxWbJcjlFOCz FNg= From: Thomas Schwinge To: Andrew Stubbs CC: Subject: RE: [committed 6/6] amdgcn: vector testsuite tweaks In-Reply-To: References: <87a65g5r0t.fsf@euler.schwinge.homeip.net> User-Agent: Notmuch/0.29.1+93~g67ed7df (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Fri, 28 Oct 2022 11:00:23 +0200 Message-ID: <87r0ysb9w8.fsf@dem-tschwing-1.ger.mentorg.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Andrew! On 2022-10-28T10:38:11+0200, "Stubbs, Andrew" wr= ote: >> -----Original Message----- >> Looking into commit r13-3225-gbd9a05594d227cde79a67dc715bd9d82e9c464e9 >> "amdgcn: vector testsuite tweaks" for a moment, I also did wonder about >> the following changes, because for 'vect_multiple_sizes' (for example, >> x86_64-pc-linux-gnu) that seems to lose more specific testing; >> previously: 'scan-tree-dump-times' exactly once, now: 'scan-tree-dump' >> any number of times. But I've no clue about that myself, so just >> mentioning this, in case somebody else has an opinion. ;-) > > When vect_multiple_sizes is true the number of times the pattern appears = will be greater that normal. Most likely the pattern will appear once for = each vector size. In the case of GCN, a pattern that normally appears 4 ti= mes now appears 24 times. > > The alternative would be to have a whole set of patterns for each configu= ration of each target that can have the multiple sizes. That or change the= implementation of 'scan-tree-dump-times' to support expressions of some ki= nd, but even then the expressions would get hairy. I guess my confusion is why this then hasn't already previously be FAILing for example for x86_64-pc-linux-gnu, which also is 'vect_multiple_sizes'? Anyway: "I've no clue about that myself". Gr=C3=BC=C3=9Fe Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955