From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 8FE69385842B for ; Tue, 12 Jul 2022 15:13:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8FE69385842B Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26CEwwoD014899 for ; Tue, 12 Jul 2022 15:13:21 GMT Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3h71rfy5sr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 12 Jul 2022 15:13:21 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 26CFAleu015741 for ; Tue, 12 Jul 2022 15:13:17 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2100.outbound.protection.outlook.com [104.47.55.100]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3h7043eafg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 12 Jul 2022 15:13:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MaGBX0i1JtjK9W5feaSW+oxC9Pi3kKJECzVLWmpvEdFHYi48+7DU9lEJ60r9KDpxqVwoq7jA9eSY3fcOEf7eVcIVmn93uSuHiOaKZZPnquSJ3fWMWguyCjigITuTCsxLdT3Guwzk/3ukL9eOQ674OmMU+5M4bJ8vfNCpEbYtYmO0mUcqDZsspnMfF6L2ljWxVJOcvMFAHJmpKGdYmBI9x6tmTenZMicxbsDwVnhNKbroEhXgZFmnOKIjGwb4hsFIysKmNp+9ElgXm4/KYr0UzvW2rseLRzenejCLgWMyG8V2AAxBA2rzbuqq678vw/LYFo2opA6qJuDf81dg0QSKjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/ry+faXMVQDcUA+ldqOUfayBmDYFWNciDdc1ZGo0ss4=; b=A3TMnYcnBz67oW7Gn8OCKpZr57o9kmQzfbXkY7HfXqwFHADH9J4nelVtlo2pTTHtvYEwaNWjq2UWgCFj4xbANQeTzG3zg+K/EoMpBanyGtXiSv4NYT7RX3KhiCK56P5Em3ZIoamLxp3KinXihj/u4/q8XcacxJuKTrP5FaxM1xhEiASnb47ibKXz6ynU+po6c0KGC2KpJTe57tKEERrJSDLIU+boD9WM0wzCoGaincYGM5ixM20KB2i4MZKLc5sKoBtE98GGkBNFSUiBTZaaFIQ4IOJtsw/ZihxB/gggm19xE+kQ7Jernr61UJMlJJsOa+YiXK/7bxi181JveABNng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by MN2PR10MB4382.namprd10.prod.outlook.com (2603:10b6:208:1d7::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Tue, 12 Jul 2022 15:13:14 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::b5ee:262a:b151:2fdd]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::b5ee:262a:b151:2fdd%4]) with mapi id 15.20.5417.026; Tue, 12 Jul 2022 15:13:14 +0000 From: "Jose E. Marchesi" To: Indu Bhagat Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] btf: emit linkage information in BTF_KIND_FUNC entries References: <877d4ncv9c.fsf@oracle.com> Date: Tue, 12 Jul 2022 17:12:33 +0200 In-Reply-To: (Indu Bhagat's message of "Mon, 11 Jul 2022 13:37:20 -0700") Message-ID: <87r12q2wm6.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO2P265CA0349.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::25) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 18f45175-2e01-4ff4-5e08-08da64190ae2 X-MS-TrafficTypeDiagnostic: MN2PR10MB4382:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UF1js2T95Y4Ju0UwUwzILDJ52MX7VMJ2wxg6A7MoxhLcm+Ve5PytOnCSQ6v1JPEKdtMi2Uc3R8sq2+TYLmQMhqJSbk409elrttn2CfMfYxm/H4/l3pggdRrXVp8/lfBxTbhS3uMFg5Npf54nfZTo2kouEL0S5T3KY/C6ZUsr2AKEoO2k/Fh5Nt+XrvgC0EKt5GrW4ZQuogAGmrWv9t3G0Osao2d0PcWVwfqdoud7gY6QopJPbXxwo+xk39b9fPRNe82oQl2GfLK6uIfFpuhbymxduZVxlDwNBmVhqhOUL4SRdiOFaiDAoQgEKc69aH0pwSnF1orSYb+RjRnA+5x3Tk1GnALibxyLDn3ssCXsk2batEB4Q7aajW5JrP92NfyIaBD50phWG+f62wHk8Gze/m6pWH05iGCmmSPFRmwPPOuIf9QTcC47QmXTnkbmX4Qh5WjVbSTJz/WfIKBYIhxwpcr50z6m8nDlyDzPOKS2bxMEkjZGDff9t9TF/yWWM5rlaVsDFM646IsX3NcDSW6h2CatVhoT6FtDrqlgIr3A23vIQ9yfhbYtdv1WpadVZJoGTF3lhmtw5E8kIrRWgOL6zopWRMAwswnp6EAKavETB8yWYonjiU9Wm7VNcXz3rIe8bEH7NSdB9HVKA5b1WMGRWzC7H3c64NKg6V3k+FnbV+V5UHH/y1glh12KP7Vw4zVn4uJtGwYpQ7LMLwhSI+gmLdqYnfM1fyOd4QASNaMDfVoMQrNZSsvodgKNvrm1XnGzCgHI5icGyvuQsMPTNByUVRihUk/PigIODTSJdNWLuq6KrsKAebGHj7kl0C0JRfKxp+5wXHyCS6GY7p5kmBbpzA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR10MB2888.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(376002)(346002)(39860400002)(396003)(136003)(366004)(6862004)(8936002)(2906002)(316002)(6636002)(4326008)(86362001)(83380400001)(37006003)(66556008)(66476007)(66946007)(8676002)(5660300002)(6506007)(186003)(38350700002)(26005)(36756003)(6512007)(2616005)(52116002)(6486002)(38100700002)(966005)(478600001)(6666004)(41300700001)(53546011); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eVYrVEtKTlNraUs0Ukp6anpuWGZYL3RtY1ZMV2Jycy9hdjZEaHAyMGMrQ2Rt?= =?utf-8?B?b25BVng2ZVVsUnFNOVZtQ3cxU1gwVzhDTGJqc0RCZ1NIOHBvdkdCcGpIb1kw?= =?utf-8?B?Z1NvbXV5UCs0eC9FQmxZTFhkWHg1eElSUlRDTElXcjNiMDJtL2NTbi8xd2h1?= =?utf-8?B?UGV5eTh1b0ZYWVgrcmdKSFlVWmpFNVZmWFRiYjNEL2g4TVNhMEIwUG5scit5?= =?utf-8?B?ZGR5bS9hajI2cmlHOTczZ3YvNHJWY2YvbllPenVvdVpTQkhDci9KY01vVFVx?= =?utf-8?B?cWlNejhlalJnNXFWVWVTVWRXRzdNN0JMUFMzVVBPc1pXMkJTa2Y2ekxRZ24w?= =?utf-8?B?M3B5c2RjM3d1MlA5c1UzZXhsekg3alRDNnE2MC9NTG53STVIQ09Hc3pDcVQ5?= =?utf-8?B?WUYxcmc3YUE1ZnNHOHQ0cUhQZUQzeDlNQW53ait1RHFCZnFreEh4ekxsdm9w?= =?utf-8?B?YU5ucHRvNUQ0VWJoTzluOVkxRTV5TjBrZVdOcnJYUWRLa0FsazdCaWs5aGl0?= =?utf-8?B?QVgvTTlseit5ZDJ5UTZER0dteGMzMkVQbU5YdDR5a1hKSzRKSmdWOFJqOTNJ?= =?utf-8?B?YlUwSm93czJncjJkdnBGVExCVzZvbFBHQUNnb3JLbWdjdmh3QURUSDZGRDhz?= =?utf-8?B?NndkOWM5RkxOZEpINFBqY3QxbWN0SkN0U3E4N3dqczFCTGNXd1lYM0xWazJo?= =?utf-8?B?U0I1dXVwQWFMRWUzMldML1B2M1pyZ0cvRjJKTHgxUkJ3Q0xaN25RVWlaSUVa?= =?utf-8?B?WnVFeHpzRktNajl2NHovWjBmeXRXcERDb2Z1aExRdWJQV0NYNzYrVHZvL1FI?= =?utf-8?B?VlR2bThjelAvZklOQWFFanJkTEw1UVNmQUF0VVg0cHB5S3gwemIwRVZMZTND?= =?utf-8?B?dVFqVzh0OG9YMnBjTmhuMjAwWTZyeGdUQ1RkRUNQUTRNSWNUVk02aERxajdr?= =?utf-8?B?Ri9GdjFrRzA1b21SeU1MNEdtVFFXd1hKNjFCMzJkOGowM0Rta3RtZWVQd25j?= =?utf-8?B?ZlhsMnFkYVFRRm4yWXhtQ3RmUGgyMVNQM3ROSVhlT1VkaExTTVdGVEJYb0Zu?= =?utf-8?B?QktKR3U0OVp2VXBtbzRWYkZnYW9IdWJHTmsvRHprZklqbExHZm5tM3Z6bTNu?= =?utf-8?B?WVI0K01iM2Q3a2RYbDB5Z3grem9yRGtHZ1B6K2cyZmZXTmFhMTZxTy91QWhX?= =?utf-8?B?bS84UnROUkdqa09GSDVrK2pRdEY5MjFMc2Rnd2VGYlFmQ1loZkJVZmxVYnVX?= =?utf-8?B?bC9PaWlubFFZVGFXZTNmL1ExNWR1QUV1OG5GQ3Z1Wm9TNnRsUi9EMER2anhO?= =?utf-8?B?ZDgrbWROeExkWTJpQnZUcjgwTzlpWWRVVlI0UmhibVByNHRSelRnQWhxWTBN?= =?utf-8?B?WlRSV01NVFgrMGhxRUtBNFJhYk1nM2dDYjVNRXFiYUw5QU1qTWhoRkhnb2Qz?= =?utf-8?B?SXZnM21PUVJ5eTVXaUJENE1JNGVTQUlXN1JuQjZYNjRwNmpiZi9zcmhsRmVr?= =?utf-8?B?R0dDRFN5ZktNcmhDMEN3QStYL2dzbUdRMHc5My9CT0dNdStManVUNytHK3Az?= =?utf-8?B?S0JiTnQva0NqT1JzVU01WjVQaWZJNU1zdFVKSTJma1VMWUl3czJ3NUEvT3BL?= =?utf-8?B?Y1MwL1NuTlFTTDRjVFBNY2JXL09obmJLbmhGRG5QV2puM1hicGVKMVlVVUNZ?= =?utf-8?B?YVRvSTRHV0xHWW1rU0NqOTI5SEVoMTN3WENHVnNCVGxoS3lVM1MwdVgvOTUw?= =?utf-8?B?a0lCQXcxS0hIZGEyZWJ5eTYrSkxobmd1N0lMR1BMUzVzd2VpeVJBVzJIYWt3?= =?utf-8?B?V0FRR0hra21zM1JrY1FtSGtHZmVxKytHTWR4dzlXa1VSVmtrRzNVTjVVOGJr?= =?utf-8?B?Yy9XdW40OU9MOU9ycUdiNG5MMFFiVzdaeTcvaVdIUVQxaFE5dDZOZ1JVaG9S?= =?utf-8?B?WUU3YzhuTGFxaGhqYkxDSEh0SkVpTnQxUHhBekNscnkyRHVaaTh2VzUveks4?= =?utf-8?B?c0JCaEdUZDU2VHRCNW9QNkdjSHh0VU1vTjdRK2plcE4zTGZDNlh2NHJpNjZ1?= =?utf-8?B?WXVoUlhZUmNrMWhMOWhmakRaaUdJZVJsR25vL2dsNG1DZUgvODc3ZnlLNGsr?= =?utf-8?B?WitEYmpEVDlESWpXQmFoVEIwZWYycmdDZ1k0bEt6dTZmQmQ5RVlWV1psVWZB?= =?utf-8?B?c0E9PQ==?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 18f45175-2e01-4ff4-5e08-08da64190ae2 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 15:13:14.7320 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0i5ARm1iZM56l0Tsg2cIBaz+hfaAWbpfCd+RI8sxko0XSU11ElITy0IYwMt500BUZqwuysd6jitOOquu9glwSadAEwo899ctHy7QrXayOiM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4382 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517, 18.0.883 definitions=2022-07-12_08:2022-07-12, 2022-07-12 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999 mlxscore=0 suspectscore=0 phishscore=0 spamscore=0 malwarescore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207120060 X-Proofpoint-GUID: a7_8CWzwkYqONmqoBnVUALTy7A3nM-sl X-Proofpoint-ORIG-GUID: a7_8CWzwkYqONmqoBnVUALTy7A3nM-sl X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jul 2022 15:13:24 -0000 > On 7/8/22 11:30 AM, Jose E. Marchesi via Gcc-patches wrote: >>=20 >> The kernel bpftool expects BTF_KIND_FUNC entries in BTF to include an >> annotation reflecting the linkage of functions (static, global). For >> whatever reason they (ab)use the `vlen' field of the BTF_KIND_FUNC entry >> instead of adding a variable-part to the record like it is done with >> other entry kinds. >>=20 > > For BTF Variables, we have the linkage information in the output > section as "btv_linkage". =C2=A0To propagate that information from DWARF = to > BTF, we have the dvd_visibility in struct ctf_dvdef (in ctfc.h). Now > that the linkage information is needed for the BTF_KIND_FUNC entries, > what do you think about - adding something like dtd_visibility to > ctf_dtdef. > > Updating the BTF format documentation will be useful > https://www.kernel.org/doc/Documentation/bpf/btf.rst. Let's see what > can be done for that... > > Also, adding some testcases with the current patch will be great. > > I have created PR debug/106263 "BTF_KIND_FUNC type does not encode > linkage" to track this. Sending V2 with the requested changes.