From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from depni-mx.sinp.msu.ru (depni-mx.sinp.msu.ru [213.131.7.21]) by sourceware.org (Postfix) with ESMTP id 2B6773858414 for ; Mon, 6 Sep 2021 13:01:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2B6773858414 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=depni.sinp.msu.ru Authentication-Results: sourceware.org; spf=none smtp.mailfrom=depni.sinp.msu.ru Received: from spider (unknown [176.195.59.180]) by depni-mx.sinp.msu.ru (Postfix) with ESMTPSA id 455111BF4E5; Mon, 6 Sep 2021 16:01:29 +0300 (MSK) From: Serge Belyshev To: Jakub Jelinek Cc: GCC Patches , Iain Sandoe , Richard Biener Subject: Re: [PATCH v3] gcc_update: use human readable name for revision string in gcc/REVISION References: <20210716072941.GC2380545@tucnak> <20210716093608.GF2380545@tucnak> <8735se1r4b.fsf_-_@depni.sinp.msu.ru> <20210719110915.GP2380545@tucnak> <87eebuzgw3.fsf_-_@depni.sinp.msu.ru> <87v93eghk1.fsf@depni.sinp.msu.ru> <20210906095402.GR920497@tucnak> Date: Mon, 06 Sep 2021 16:01:15 +0300 In-Reply-To: <20210906095402.GR920497@tucnak> (Jakub Jelinek's message of "Mon, 6 Sep 2021 11:54:02 +0200") Message-ID: <87r1e1hn8k.fsf@depni.sinp.msu.ru> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=1.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KAM_LINKBAIT, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Sep 2021 13:01:19 -0000 Jakub Jelinek writes: > On Mon, Sep 06, 2021 at 12:49:18PM +0300, Serge Belyshev wrote: > * gcc_update: derive human readable name for HEAD using git describe > > After : start with upper case, ^^^ Derive > > like "git gcc-descr" with short commit hash. Drop "revision" from gcc/REVISION. > > Too long line. > > Otherwise LGTM. Thanks! Changed and committed as r12-3370-g78b34cd8a80.