[PATCH, MIPS] Call SYMBOL_REF_LONG_CALL_P on SYMBOL_REFs only

[PATCH, MIPS] Call SYMBOL_REF_LONG_CALL_P on SYMBOL_REFs only

[Adam Nemet]

While chasing a different bug I enabled rtl-checking and found this.
We use SYMBOL_REF_FLAGS on a CONST node.  One testcase where
rtl-checking asserts is gcc.c-torture/compile/20010107-1.c -O1 on
mipsisa64-elf.

Now we get identical regression testresults for --enable-checking and
--enable-checking=assert,misc,gc,rtlflag,runtime,tree,rtl on
mipsisa64-elf.

OK for trunk?  I haven't checked but by looking at the code the same
problem seems to exist on 4.2 and 4.1 as well.  OK there too?

Adam

	* config/mips/predicates.md (const_call_insn_operand): Invoke
	SYMBOL_REF_LONG_CALL_P only on SYMBOL_REFs.

Index: predicates.md
===================================================================
--- predicates.md	(revision 127318)
+++ predicates.md	(working copy)
@@ -115,7 +115,7 @@ (define_predicate "const_call_insn_opera
       /* If -mlong-calls or if this function has an explicit long_call
 	 attribute, we must use register addressing.  The
 	 SYMBOL_FLAG_LONG_CALL bit is set by mips_encode_section_info.  */
-      return !SYMBOL_REF_LONG_CALL_P (op);
+      return !(GET_CODE (op) == SYMBOL_REF && SYMBOL_REF_LONG_CALL_P (op));
 
     case SYMBOL_GOT_DISP:
       /* Without explicit relocs, there is no special syntax for

Re: [PATCH, MIPS] Call SYMBOL_REF_LONG_CALL_P on SYMBOL_REFs only

[Richard Sandiford]

Adam Nemet <anemet@caviumnetworks.com> writes:
> OK for trunk?  I haven't checked but by looking at the code the same
> problem seems to exist on 4.2 and 4.1 as well.  OK there too?

OK everywhere, thanks.  Let's assume that long_call attributes don't
apply to cases where an offset is applied to a "long_call" symbol.

Richard