From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id E7A553858D1E for ; Fri, 17 Nov 2023 12:37:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E7A553858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E7A553858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=68.232.141.98 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700224624; cv=none; b=lsMVSHMnVAr0O7j6Z4Jykn6XHoHfM6n3KZxWVOJh5sTvb0ABzy++fPArmNX8271Nc27ZVzWzxe8KgyUcRIuzjLPV8o9SiDDD91ZEIz8DRbA9A2Gmh81BRfdRV+WOUkIg6YKawh3jZ4Sgg8tPZPojuCSLa4xd6fmpOcqUaKQLp1E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700224624; c=relaxed/simple; bh=NcJ0mQ4/lHymEPpnH7WIOUdemHSXIo/mFvA2UuiorSA=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=H33Ya3VNzdiLF9QgcJBFyjMCy90TOKhwBcdM/Qog7mXcXFXlBTfih1SBmhPIA4dL4sBp6q79Saf1eBOLgIrGyEcFwA/pxStXr46P3ZB7Fj9cxTpqWndcG8CTDYSYVZIlvJqnmZcb3toVzNy7aEdgV72CJ4kwzEcevpHxtcbwc0E= ARC-Authentication-Results: i=1; server2.sourceware.org X-CSE-ConnectionGUID: 838pyhnuSQGAl9il71bx6A== X-CSE-MsgGUID: Io5uSiAeTtyJ1xwNjNm0Qw== X-IronPort-AV: E=Sophos;i="6.04,206,1695715200"; d="scan'208";a="25789472" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 17 Nov 2023 04:37:01 -0800 IronPort-SDR: GELQhRcLSzBDQ6pJ7tgMfl4OVBpY5p9gK/Egt1rFBftpCqLLUPog9/dcShI9HSxjwWEkfi+Xdm XRNRshVjSnN2CQzxnn7pzkv/ahdkLqMruPPsr4giaxhA2tHylSZvvROpL/vGGlI215YjgtLxWb sigOEhlDtkxBldBhqzC+jowdankxToOIy3pZk4f0YzVO5EnVYjQRSKr4DqMbwiJjVS9qfdVj86 eCiYp2Uw5O+9QyKmG1MGN6M+lYeO5uPbf6n0WC4XOMCKuSM3hph80x9QpdaMpOmcqrN6lIvsmk /f8= From: Thomas Schwinge To: FX Coudert , Iain Sandoe CC: Rainer Orth , Subject: Re: gfortran.dg/dg.exp debug messages pollute test output In-Reply-To: References: User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/28.2 (x86_64-pc-linux-gnu) Date: Fri, 17 Nov 2023 13:36:54 +0100 Message-ID: <87sf54sgih.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-11.mgc.mentorg.com (139.181.222.11) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi! On 2023-11-15T11:29:20+0100, FX Coudert wrote: >>> it's unclear if those messages can just be removed (they are pretty >>> cryptic as is) or at least changed to use verbose instead of puts. >>> Please fix. > > I don=E2=80=99t see value in this output, so I think it=E2=80=99s best to= remove the puts calls entirely. ACK, I'd noticed that, too. > Attached patch does that. > --- a/gcc/testsuite/gfortran.dg/coarray/caf.exp > +++ b/gcc/testsuite/gfortran.dg/coarray/caf.exp > @@ -81,7 +81,6 @@ if [check_effective_target_libatomic_available] { > } > } > set t [get_multilibs] > - puts "maybe al $maybe_atomic_lib ml $t" > } I suppose 'set t [...]' can be let go, too? > --- a/gcc/testsuite/gfortran.dg/dg.exp > +++ b/gcc/testsuite/gfortran.dg/dg.exp > @@ -68,7 +68,6 @@ if [check_effective_target_libatomic_available] { > set maybe_atomic_lib "" > } > set t [get_multilibs] > - puts "dg set al $maybe_atomic_lib ml $t" > } Likewise. Gr=C3=BC=C3=9Fe Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955