From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2087.outbound.protection.outlook.com [40.107.8.87]) by sourceware.org (Postfix) with ESMTPS id 972283858D37 for ; Thu, 25 May 2023 20:26:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 972283858D37 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=siemens.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cAHLbcItZcKU7p3WnDK6UzZ3wZdmvJnb5WQ/A6SFJ2uBHUh7wDgGnUVxD2+ce2UI3OpLnKBzOOprAY4kk5erYgXY14zTqa2uf7nmn0aSr+WZ0eyV9swWZETbv3qc6ynh87DjobVsRbYFZT20ALSz3KnADDSuZSCKluzINlmHl3JTWXXmJ+qQO/Qn1T2jEyOZeb2SZUPLjQOfJLZGFyC4lgPiiWlAXZBKIdj0dhRAqdYuss+AUhDWYqUuc9+F7hHaW+RiSbm1G7ih4rsEBC9wAFDKijZuo3JK1pgLl5mxqNPgh6H05PilBhLHYU7wi8IxnZR4/zQA23ugDVTDA9kt6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/k0V6xleO+5psVgFaWSfm2SNKqpSMS/yoUAZWSVFQmo=; b=gW2jHiifwFXiDEHdu2ReW3x3u5DKvottBofyXm5eDnu/VZiXzAJ3wIf+gpXFEo+LALDiQSX7hADQ3llvd4Xn5w+nKmI7qamkaByIRkbrGmYIbuofNRM4AJL38efAU1JMrA6LohM94WyxwxgoFMu5kHoGp01lnKZYDyqbx9WlPTVgx3c6xkiKHPkApywCC32MS2OFG4eoTROtJP1uRNgmQnICFqeo0np6lOB8fa9YR7gGGcUNyAwUpqKBXOFqtIgTEJJCPRGUv9MEEWgp0Ow8VZ4ejVg0Fk0pRDC24s7bwtR9X3IAwZyf8b1gWzhb+k7YnTjU/q1hXvl3brzpHyQ/Bg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/k0V6xleO+5psVgFaWSfm2SNKqpSMS/yoUAZWSVFQmo=; b=bHjgr7Sx+JMpXvX+X9UYLMZArQcj13fUeUZoDV1wxq3ldHrfqi0VnZjbR50UQy/JosnoQ9oyIKC352IGOXJQQdXO2lMsyUYKRqPQWmnTNNJbCRjT+XQoxDOOTvz1wz1yRULIenMooaraVkpl9pT5hbZzaYl4B9RxaKGGCpcpTfcoogColbLQlNHqydSjloAW2EN+nzJDSQoYgOh+z4NbRfv/v0SsU65xxjzIq6AjRQg/zBl2jCwR6mAB9srDQyamWFBTbMqIQeCXjwoiKYbmXAHXs5E35W7y3eemHA5XAxp9pW5GUi1wZ0aqv2s5AIZnCvTBVQN1UoOL3UWsZ7gM9g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from DU0PR10MB5583.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:31b::22) by AM7PR10MB3303.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:108::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.16; Thu, 25 May 2023 20:26:52 +0000 Received: from DU0PR10MB5583.EURPRD10.PROD.OUTLOOK.COM ([fe80::ed0:d9f:8d5d:5e22]) by DU0PR10MB5583.EURPRD10.PROD.OUTLOOK.COM ([fe80::ed0:d9f:8d5d:5e22%3]) with mapi id 15.20.6411.032; Thu, 25 May 2023 20:26:52 +0000 From: Thomas Schwinge To: Vineet Gupta , Kito Cheng Cc: gcc-patches@gcc.gnu.org, kito.cheng@gmail.com, patrick@rivosinc.com, jlaw@ventanamicro.com, "Maciej W . Rozycki" , Palmer Dabbelt Subject: Re: [PATCH] RISC-V: Add missing torture-init and torture-finish for rvv.exp In-Reply-To: <5070d049-f3ee-e175-4bad-21cd2528e42b@rivosinc.com> References: <20230522064138.74056-1-kito.cheng@sifive.com> <87jzwxsc3b.fsf@dem-tschwing-1.ger.mentorg.com> <5070d049-f3ee-e175-4bad-21cd2528e42b@rivosinc.com> User-Agent: Notmuch/0.29.1+93~g67ed7df (https://notmuchmail.org) Emacs/27.1 (x86_64-pc-linux-gnu) Date: Thu, 25 May 2023 22:26:49 +0200 Message-ID: <87sfbkqhrq.fsf@dem-tschwing-1.ger.mentorg.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR3P281CA0117.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::8) To DU0PR10MB5583.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:31b::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR10MB5583:EE_|AM7PR10MB3303:EE_ X-MS-Office365-Filtering-Correlation-Id: 5fb2c7fd-0c48-4941-d387-08db5d5e5fcf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4fY56Lw5BBLI38kXKP6bzMVnsXKKU/jx2qpjwGAqVXwO/ejXnllX1MZYEjFP9ji3lyRvRUc7e5yG8WcwPbUhxauRz6500cJ6DMbFN3Sk84xtyeWDYnF6UP9DZAWQqGLQsLoo6cxG0lfncnuaT7WW3ccMn1/zoEmk8wyPtxwtznv6kk00JY4ovmlB34uGy8K4z02lM6zZTLx8sqrzutm97aPAtvqLaoXt7mIcz5IVGbynl3gZ/1uh+ur4I0p++HWI62+tgSc78H+8jsTKKSjzxLxP3IBELXQkZQO56qg/txB/fQKfEYNzdKg0P7eQaY9L9xH8dtGU1jDcJrDBYf8NwSpoRmDFFJCq8KY0VF48x1ISqAIi476OImy38lqKwM1mIl6ruOd+OdE7bSraqcGZswTTjEBxX2UKFDU0NPN1N6yDX118bi76r9Be9+Nf8aJzR2T4TpfWfdRBEt8kEZbSTBK6FOMwA7+UYdhYeGwQ8o7r50zbW+s7DAuxozEe5/QaOaAeEjZYIl7OtGCmtwq1c6rqZ3AlE3MD0htE9ww2nOo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR10MB5583.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(136003)(366004)(396003)(346002)(39860400002)(451199021)(83380400001)(2906002)(186003)(86362001)(38100700002)(82960400001)(84970400001)(8676002)(41300700001)(6486002)(5660300002)(478600001)(54906003)(110136005)(66946007)(316002)(4326008)(66476007)(66556008)(8936002)(6666004)(6506007)(6512007)(9686003)(53546011)(26005)(44832011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y1ZCMnpzc2tGYWNwR0NFMG5abklRUGNud2luWm45cEs3TDRoNXJ5aXMyMHJp?= =?utf-8?B?YTJoekxJcXBMR0tKd05wN25WTnBZSzR4dENJdEU4T2xVQVpHUTFqcUtBeTRD?= =?utf-8?B?bkQxUEQ1Mk9FajMwU2UyaGVqdjY1dy9IN3l6blpnYWowUGNjTzh6cUtvRXYw?= =?utf-8?B?VlNyMEZjcFdkNFZzMWE5NVlXU09BdHVuTHRIbHNzNnRIMUNyQklwVTUwSy80?= =?utf-8?B?b1QwYW1aVit4elRVbEtJcjI3YmZHS2dZNGpocFVSajlQbHZaeGZEQUZsRGl1?= =?utf-8?B?OVRKY3B6RStDaEZDVngvcTB5clVRZTNTeWZRaTNPWUVDQzJWMjRRN3JYaWZG?= =?utf-8?B?ZmkvUFJCcGMyTzFPUWNaV001VThaVWZrTExNOTRtdCt0YmJQZU1Fa21oSnZL?= =?utf-8?B?UTZxOUVCQm1MSGdWSjBVR0wrVmVEZFF6MVlYSldsVFlrQ2dyVFVFT1pJaFV1?= =?utf-8?B?cWY0RVQyQlEwVSsyMXlKc0EyUmFQZmhaNzFXV1RLeVZnZE5JVTVyajNCcmpn?= =?utf-8?B?bUEvSmxLQldoTDFkV09oUDEzSmh1akZ4dzlFWVpGMmR0MXNSQUFOalBqMUdx?= =?utf-8?B?aUtwM2YyMUFrRGxQeXozVHZ3V3dwQVRRMXc4bVFQaEJtZHhQTSs1WWRzS1d2?= =?utf-8?B?U1ZVOWIxUWpZVDA0UDlHZFFVbjROUmhLb2FlMmZQM2NENldZb050VDhUWDJx?= =?utf-8?B?ZDlNVXFlU2MzVVdvNGJDUzBveGd4OUd3ZGg2TjBwYWNUUTVoK3Y2SDlzYVVv?= =?utf-8?B?REo5TVN6NHErdnJJZyt1RnNUZ2ZkbXF6RVRPaUtrWXUrUmN1d1loNWY5YWpV?= =?utf-8?B?YjM5L2tlL3dCZ0NONjA5OVRlbktxcUgzQVN1U3FGUTZsNitBZmtqNG5RYk91?= =?utf-8?B?dGxwaXNJWjV5aEZvVW5XNkhkQlZjZUFiUjB4Ykd2ZDBrYk1lcElHeEFleHZV?= =?utf-8?B?TFZGYXhsYW5yYjcrRWpncnFtVlhUNHpKNWxtRW1QVWluZjRWQjZaTHpXNVY0?= =?utf-8?B?NTRCTmxBTHdRbjFYRjdWMmtIbS9pUXVEcTVYQzQ5NWZDVmJFUFB5NEg5ajN5?= =?utf-8?B?NUtUMW5qZHJWT2pVbGQ2MG80Q0lmNHM4ay9JT1FDaGdZN1RFRXcycjA2VC9O?= =?utf-8?B?cklJN3pwNHBzV3JTUVFibXYxSXI1ZlhydVlzS21nVGhiTHp3SG5wbmlnRXNK?= =?utf-8?B?eFEyUGZTd0ZCT3gxQVVOaXR2bnV5cmtLNVlpZWVnVURvV3ZOYldRK3dZNXg5?= =?utf-8?B?dnN1SXNVRUpUd0xEMm1UckJIWWl0cDN4aGxQbVo0dDdRbGdrRTh4Ny9nU2dX?= =?utf-8?B?WHlFWWt0NjZzUGNxeVB5Nm41MFlhUFc1ZlhoT3hLeW1mM3M2eGc2bzJQT2h1?= =?utf-8?B?U1MrUExDOGkxOUhPZkJGMEFIcmtpTlBtaVB6U0daQmtYUFpuL1hDMzN3VzZL?= =?utf-8?B?RzljT2lwUzU5amRoOGlTT3BwajdYTkZnOHR3Y0lUUTNsanUvU1RkbHVOVXBP?= =?utf-8?B?cjJ2dUY1OERQT3o3R204bit6L3FtUUhSNzdsNVFpUFlDWUtuYzN2VW94eXVZ?= =?utf-8?B?SVVwQVNLdStpVGxxS0dVSkxEMUlkZ3RtY0ZLVjNOUlBzS2ZTRzR2bVYxL21w?= =?utf-8?B?MzdjK2pUb2JIMmZ3cXRWbjEwbTNaVlVCZ0VsS3ZVNjZWeVl6djMwUlVYS05O?= =?utf-8?B?ZFhhRXlzKzVLbFZiblZrcjVaMlBKcXZLMTNlWmtGcGlyUkt2NGFKZWJNRzlS?= =?utf-8?B?Y1dlb1VLZTIwNHNwSXpDMEkyOVFDdHdoSk42UjAyOWRtY1ZHWWhXZERucHVB?= =?utf-8?B?Q1B0Ym9SekZ0NjJ1UW9MaVZjUTU5aStuc3d0Znl0VC9IUFVJNmx3eVp2YndI?= =?utf-8?B?cDNRTFcwUkhZVkxTdGFlS3p0YXRaUGtncU9tTjIyUHBob1VIZTBrYkczNGxh?= =?utf-8?B?VWhEVFd3TW1MOW1YTXFyRzFUa3h1b0h1dS9Hb1NIWHlWV2ZPM3h6Vk5OOUt4?= =?utf-8?B?YnVqWmJJK2Q1REhncTJ5WjJXaWIrWnZla0pScVpUYlBTZlNCT25rMm5wMDNF?= =?utf-8?B?MEh2MFRTdnhlN2RLZjBJNzU1SHBlalFZZnNpNTZaOGFDdFduTkFnallXbzA1?= =?utf-8?B?dkU2c3VFT3JqYVZkVXlnYXdzWlR4NWRza3RkeDc5TFZweHFUTE1DZDN2Wkk5?= =?utf-8?B?RFE9PQ==?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5fb2c7fd-0c48-4941-d387-08db5d5e5fcf X-MS-Exchange-CrossTenant-AuthSource: DU0PR10MB5583.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2023 20:26:52.0806 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4Urhresz8k70NiTYitUTjVGK2ldZ9v15IyctxvpB8FqvMPat+lITk77T3RoSlGmLUd6P9Bfwonl5Q81GVu6cbn30JKj5LBe/ZQRWqkm9US4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR10MB3303 X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00,BODY_8BITS,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,GIT_PATCH_0,KAM_SHORT,LIKELY_SPAM_BODY,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi! On 2023-05-24T15:13:19-0700, Vineet Gupta wrote: > On 5/24/23 13:34, Thomas Schwinge wrote: >> Yeah, at this point I'm not sure whether my recent changes really are >> related/relevant here. >> >>> Apparently in addition to Kito's patch below, If I comment out the >>> additional torture options, failures go down drastically. >> Meaning that *all* those ERRORs disappear? > > No but they reduced significantly. Anyhow I think the issue should be=20 > simple enough for someone familiar with how the tcl stuff works... I'm here to help -- but you'll have to help me to help you, please. >>> diff --git a/gcc/testsuite/gcc.target/riscv/riscv.exp >>> b/gcc/testsuite/gcc.target/riscv/riscv.exp >>> >>> -lappend ADDITIONAL_TORTURE_OPTIONS {-Og -g} {-Oz} >>> +#lappend ADDITIONAL_TORTURE_OPTIONS {-Og -g} {-Oz} >>> >>> @Thomas, do you have some thoughts on how to fix riscv.exp properly in >>> light of recent changes to exp files. >> I'm trying to understand this, but so far don't. Can I please see a >> complete 'gcc.log' file where the ERRORs are visible? > So we are at bleeding edge gcc from today > =C2=A0=C2=A0=C2=A0=C2=A0 2023-05-24 ec2e86274427 Fortran: reject bad DIM= argument of SIZE=20 > intrinsic in simplification [PR104350] > > With an additional fix from Kito along the lines of.. > > diff --git a/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp=20 > b/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp > > =C2=A0dg-init > +torture-init > > =C2=A0# All done. > +torture-finish > =C2=A0dg-finish That shouldn't be necessary here? > I'm pasting a snippet of gcc.log. Issue is indeed triggered by rvv.exp=20 > which needs some love. I'd intentionally asked to "see a complete 'gcc.log' file where the ERRORs are visible". On 2023-05-24T16:12:20-0700, Vineet Gupta wrote: > On 5/24/23 15:13, Vineet Gupta wrote: >> >> PASS: gcc.target/riscv/zmmul-2.c=C2=A0=C2=A0 -O2 -flto -fuse-linker-plug= in=20 >> -fno-fat-lto-objects=C2=A0 (test for excess errors) >> PASS: gcc.target/riscv/zmmul-2.c=C2=A0=C2=A0 -O2 -flto -fuse-linker-plug= in=20 >> -fno-fat-lto-objects=C2=A0=C2=A0 scan-assembler-times mul\t 1 >> PASS: gcc.target/riscv/zmmul-2.c=C2=A0=C2=A0 -O2 -flto -fuse-linker-plug= in=20 >> -fno-fat-lto-objects=C2=A0=C2=A0 scan-assembler-not div\t >> PASS: gcc.target/riscv/zmmul-2.c=C2=A0=C2=A0 -O2 -flto -fuse-linker-plug= in=20 >> -fno-fat-lto-objects=C2=A0=C2=A0 scan-assembler-not rem\t >> testcase=20 >> /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/ris= cv/riscv.exp=20 >> completed in 60 seconds >> Running=20 >> /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/ris= cv/rvv/rvv.exp=20 >> ... >> ERROR: tcl error sourcing=20 >> /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/ris= cv/rvv/rvv.exp. >> ERROR: tcl error code NONE >> ERROR: torture-init: torture_without_loops is not empty as expected I'd seen this before, in your earlier emails. > Never mind. Looks like I found the issue - with just trial and error and= =20 > no idea of how this stuff works. Instead of "magic", let's please try to properly work this out. > The torture-{init,finish} needs to be in riscv.exp not rvv.exp > Running full tests now. I still don't understand this. My current theory would be that some other '*.exp' file runs 'torture-init' and then prematurely ends without 'torture-finish', and thus the torture testing state bleeds into the next '*.exp' file(s). I'd hoped that I could pinpoint that via "a complete 'gcc.log' file where the ERRORs are visible". Gr=C3=BC=C3=9Fe Thomas