From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 33C0E3858D28 for ; Mon, 30 Jan 2023 15:27:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 33C0E3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.97,258,1669104000"; d="scan'208";a="95193079" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa4.mentor.iphmx.com with ESMTP; 30 Jan 2023 07:27:49 -0800 IronPort-SDR: QDbfnx9h6eN7XHxiXxuntMX3vE+5feCzzlrl0FXRJDAMy+kozk7t1QwBx0gnlNPKRRqDb0MstX BR3IoJUiP0ud5QvXK805cxriIoBEysOQCyrTgQ+xtPmaeNxxmilRet6xVnA1z9I6ZM+O2kjT7K qIEROK+S28oMh+vqTNFFuBql43I4+vuuYDNVTDJe/t3u+pWoLZx8wqjmuh7SNVlQTc97hmJQfX tnXDklePQOlUdPO51QmtLBnVTOX5suQw3EOdF2dJlnhLe4WSrKy1FmcJtQoRj/1Qn64x1PeN7J ooY= From: Thomas Schwinge To: Rainer Orth CC: , Gaius Mulley , Iain Sandoe , Iain Sandoe Subject: Re: [COMMITTED] testsuite: Restore TORTURE_OPTIONS in gm2/warnings/returntype/fail/warnings-returntype-fail.exp In-Reply-To: References: User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/28.2 (x86_64-pc-linux-gnu) Date: Mon, 30 Jan 2023 16:27:38 +0100 Message-ID: <87sffsjb4l.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi! On 2023-01-30T14:24:43+0100, Rainer Orth wrot= e: > Between 20230126 and 20230127, 1100+ gm2 tests started to FAIL for the > non-default multilib, e.g. > > FAIL: gm2/calling-c/datatypes/unbounded/run/pass/m.mod compilation, {addi= tional_flags=3D -O0 -g -Werror=3Dreturn-type } timeout=3D10 > UNRESOLVED: gm2/calling-c/datatypes/unbounded/run/pass/m.mod execution, {= additional_flags=3D -O0 -g -Werror=3Dreturn-type } timeout=3D10 > FAIL: gm2/case/pass/testcase1.mod, -O0 -g -Werror=3Dreturn-type > [...] > cc1gm2: warning: '-Werror=3D' argument '-Werror=3Dreturn-type' is not val= id for Modula-2 > > I'm seeing this on all of Solaris/x86, Solaris/SPARC, and Linux/x86_64. ACK. > I could trace this to > gm2/warnings/returntype/fail/warnings-returntype-fail.exp not properly > restoring TORTURE_OPTIONS. > > Tested on i386-pc-solaris2.11 and sparc-sun-solaris2.11. Installed on > trunk. ACK, thanks. And note that this is independent of (or: complements) Iain's commit r13-5473-gfe4608efc15b881ac908a3f90d7322736495ae72 "Modula-2: Claim Wreturn-type in lang.opt", , which remains necessary for: 'gm2/warnings/returntype/pass/Termbase.mod', 'gm2/warnings/returntype/pass/goodreturn.mod', 'gm2/warnings/returntype/pass/keypressedsimple.mod'. Gr=C3=BC=C3=9Fe Thomas > 2023-01-30 Rainer Orth > > gcc/testsuite: > * gm2/warnings/returntype/fail/warnings-returntype-fail.exp: Save, > restore TORTURE_OPTIONS. > > diff --git a/gcc/testsuite/gm2/warnings/returntype/fail/warnings-returnty= pe-fail.exp b/gcc/testsuite/gm2/warnings/returntype/fail/warnings-returntyp= e-fail.exp > --- a/gcc/testsuite/gm2/warnings/returntype/fail/warnings-returntype-fail= .exp > +++ b/gcc/testsuite/gm2/warnings/returntype/fail/warnings-returntype-fail= .exp > @@ -28,6 +28,8 @@ load_lib gm2-torture.exp > gm2_init_pim "${srcdir}/gm2/warnings/returntype/fail" > > global TORTURE_OPTIONS > + > +set old_options $TORTURE_OPTIONS > set TORTURE_OPTIONS { { -O0 -g -Werror=3Dreturn-type } } > > foreach testcase [lsort [glob -nocomplain $srcdir/$subdir/*.mod]] { > @@ -38,3 +40,5 @@ foreach testcase [lsort [glob -nocomplai > > gm2-torture-fail $testcase > } > + > +set TORTURE_OPTIONS $old_options ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955