From: "Jose E. Marchesi" <jose.marchesi@oracle.com>
To: David Faust <david.faust@oracle.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] bpf: correct bpf_print_operand for floats [PR108293]
Date: Tue, 10 Jan 2023 10:59:13 +0100 [thread overview]
Message-ID: <87sfgi1zim.fsf@oracle.com> (raw)
In-Reply-To: <20230109224045.13453-1-david.faust@oracle.com> (David Faust's message of "Mon, 9 Jan 2023 14:40:45 -0800")
Hi David.
Thanks for the patch.
> diff --git a/gcc/config/bpf/bpf.cc b/gcc/config/bpf/bpf.cc
> index 2aeaeaf309b..9dde3944e9c 100644
> --- a/gcc/config/bpf/bpf.cc
> +++ b/gcc/config/bpf/bpf.cc
> @@ -880,13 +880,20 @@ bpf_print_operand (FILE *file, rtx op, int code ATTRIBUTE_UNUSED)
> output_address (GET_MODE (op), XEXP (op, 0));
> break;
> case CONST_DOUBLE:
> - if (CONST_DOUBLE_HIGH (op))
> - fprintf (file, HOST_WIDE_INT_PRINT_DOUBLE_HEX,
> - CONST_DOUBLE_HIGH (op), CONST_DOUBLE_LOW (op));
> - else if (CONST_DOUBLE_LOW (op) < 0)
> - fprintf (file, HOST_WIDE_INT_PRINT_HEX, CONST_DOUBLE_LOW (op));
> - else
> - fprintf (file, HOST_WIDE_INT_PRINT_DEC, CONST_DOUBLE_LOW (op));
> + long vals[2];
> + real_to_target (vals, CONST_DOUBLE_REAL_VALUE (op), GET_MODE (op));
> + vals[0] &= 0xffffffff;
> + vals[1] &= 0xffffffff;
> + if (GET_MODE (op) == SFmode)
> + fprintf (file, "0x%08lx", vals[0]);
> + else if (GET_MODE (op) == DFmode)
> + {
> + /* Note: real_to_target puts vals in target word order. */
> + if (WORDS_BIG_ENDIAN)
> + fprintf (file, "0x%08lx%08lx", vals[0], vals[1]);
> + else
> + fprintf (file, "0x%08lx%08lx", vals[1], vals[0]);
> + }
> break;
> default:
> output_addr_const (file, op);
Do we want a gcc_unreachable in case the mode of `op' is not SFmode nor
DFmode?
> diff --git a/gcc/testsuite/gcc.target/bpf/double-1.c b/gcc/testsuite/gcc.target/bpf/double-1.c
> new file mode 100644
> index 00000000000..200f1bd18f8
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/bpf/double-1.c
> @@ -0,0 +1,12 @@
> +/* { dg-do compile } */
> +/* { dg-options "-mlittle-endian" } */
> +
> +double f;
> +double a() { f = 1.0; return 1.0; }
> +double b() { f = 2.0; return 2.0; }
> +double c() { f = 2.0; return 3.0; }
> +double d() { f = 3.0; return 3.0; }
> +
> +/* { dg-final { scan-assembler-times "lddw\t%r.,0x3ff0000000000000" 2 } } */
> +/* { dg-final { scan-assembler-times "lddw\t%r.,0x4000000000000000" 3 } } */
> +/* { dg-final { scan-assembler-times "lddw\t%r.,0x4008000000000000" 3 } } */
> diff --git a/gcc/testsuite/gcc.target/bpf/double-2.c b/gcc/testsuite/gcc.target/bpf/double-2.c
> new file mode 100644
> index 00000000000..d04ddd0c575
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/bpf/double-2.c
> @@ -0,0 +1,12 @@
> +/* { dg-do compile } */
> +/* { dg-options "-mbig-endian" } */
> +
> +double f;
> +double a() { f = 1.0; return 1.0; }
> +double b() { f = 2.0; return 2.0; }
> +double c() { f = 2.0; return 3.0; }
> +double d() { f = 3.0; return 3.0; }
> +
> +/* { dg-final { scan-assembler-times "lddw\t%r.,0x3ff0000000000000" 2 } } */
> +/* { dg-final { scan-assembler-times "lddw\t%r.,0x4000000000000000" 3 } } */
> +/* { dg-final { scan-assembler-times "lddw\t%r.,0x4008000000000000" 3 } } */
> diff --git a/gcc/testsuite/gcc.target/bpf/float-1.c b/gcc/testsuite/gcc.target/bpf/float-1.c
> new file mode 100644
> index 00000000000..05ed7bb651d
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/bpf/float-1.c
> @@ -0,0 +1,12 @@
> +/* { dg-do compile } */
> +/* { dg-options "-mlittle-endian" } */
> +
> +float f;
> +float a() { f = 1.0; return 1.0; }
> +float b() { f = 2.0; return 2.0; }
> +float c() { f = 2.0; return 3.0; }
> +float d() { f = 3.0; return 3.0; }
> +
> +/* { dg-final { scan-assembler-times "lddw\t%r.,0x3f800000" 2 } } */
> +/* { dg-final { scan-assembler-times "lddw\t%r.,0x40000000" 3 } } */
> +/* { dg-final { scan-assembler-times "lddw\t%r.,0x40400000" 3 } } */
next prev parent reply other threads:[~2023-01-10 9:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 22:40 David Faust
2023-01-10 9:59 ` Jose E. Marchesi [this message]
2023-01-10 19:12 ` [PATCH v2] " David Faust
2023-01-10 23:57 ` Jose E. Marchesi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfgi1zim.fsf@oracle.com \
--to=jose.marchesi@oracle.com \
--cc=david.faust@oracle.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).