From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by sourceware.org (Postfix) with ESMTPS id D575F3851883 for ; Mon, 21 Nov 2022 17:42:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D575F3851883 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-x436.google.com with SMTP id s5so3756156wru.1 for ; Mon, 21 Nov 2022 09:42:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=n14vy+BfC1AVyrDiDkjU+6o689YlhVv9ZA5c2aqpvas=; b=DA5jOio1IHz+KzoSnbYJfLLXfPhsIBB93gP3PhSOIMop4c0G161EO5ndwrkfK87UI2 0fN3nhWrsoSjDWnAk6LAcDrFLfOmeDkpl6aSxAg3M1Aggi3sw12jrm18u/m5iSElgasI KVO5mMo0x5w7/GjZ9Bbqm3tAOFAlZeXNc8tq9ODHTTSLjzhpRvBnoqsNGb83ZWYgB016 1py2m5MvNX++hENE4dud4b8RtP+9OjdF4byruM2wlAVuhrT3Id3+XnTmGeUfXi32akRu abkg4JsGyZnR33OVHU9eBIpXLa/WzHUJvyfY0IZTQh2WRazJcoyrcNY+h2yDSk0UfD/U YGOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=n14vy+BfC1AVyrDiDkjU+6o689YlhVv9ZA5c2aqpvas=; b=Ie+H+/I2ZmM+9dh3X+MdkvltHlHfVAT34t4JOv+sXTZTPDWsI2nWkgKoeRGUsBiEjh vqy4MSFJR7FPiDuBANMjMHjFd6TR9q+wY9sbKBiWYAY1WlEeGhCyte1HGHfJP5OPgNIY 2e/quaKghkyc14zuCucDtHA15D2skjq+TdONf5Gcsg/z+n6qOwBi6Un2tXEQCT9EDPZK rceRBFgJR368sS5TiuUIj++UcbYRMD/fch1pk5VTJtXOL1Cmbumo8OBwBRBuKCjSXwW5 +hAsfbHM2bvrJiztthx15TRvKeZM1/BhI6rSebbt46+K9unkkyvjOJhrwYCb2Jx/vW+n LP1w== X-Gm-Message-State: ANoB5pnp2qpc4H9Wwxk9Y+03pCZpiEwhqiZr6Tes9dRNMgsSqQXseko+ dNk4gwTnrG8Aiip81h+qMvR6OMbZMtk= X-Google-Smtp-Source: AA0mqf6j1hp8l8UHKMczCxHupJZEwaN9mY8pwpfJerL1a3YoCro4wDa5w9I3lrHr5jLrdi9yIEKekw== X-Received: by 2002:a5d:550e:0:b0:241:8103:769e with SMTP id b14-20020a5d550e000000b002418103769emr1732180wrv.240.1669052551490; Mon, 21 Nov 2022 09:42:31 -0800 (PST) Received: from lancelot ([195.147.220.46]) by smtp.gmail.com with ESMTPSA id r5-20020a5d6945000000b00241bfce14e9sm10078572wrw.107.2022.11.21.09.42.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 09:42:31 -0800 (PST) Received: from gaius by lancelot with local (Exim 4.94.2) (envelope-from ) id 1oxAoQ-004w2F-2i; Mon, 21 Nov 2022 17:42:30 +0000 From: Gaius Mulley To: Richard Biener Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] 3/19 modula2 front end: gm2 driver files. References: Date: Mon, 21 Nov 2022 17:42:29 +0000 In-Reply-To: (Richard Biener's message of "Fri, 18 Nov 2022 11:21:49 +0100") Message-ID: <87sficxkze.fsf@debian> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Richard Biener writes: [snip] > It feels like most of the above would usually be handled via lang specific > specs rather than open-coded in the driver? Is there a specific reason you > opted for explicit handling here? The last time submitting the patches I perhaps went overboard using lang-specs - and so tried to adopt the style from C++/fortran this time around. I'm happy to utilize lang-specs to reduce the driver code though. > Otherwise the patch looks generally OK, the string builds using strcat & friends > looks like it neither takes advantage of how obstacks can be used there nor > that we're now C++ and could use std::string - but that's a matter of taste and > no objection. ok thanks! regards, Gaius