From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24843 invoked by alias); 18 Dec 2019 17:13:59 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 24832 invoked by uid 89); 18 Dec 2019 17:13:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-19.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy=werent, weren't X-HELO: esa1.mentor.iphmx.com Received: from esa1.mentor.iphmx.com (HELO esa1.mentor.iphmx.com) (68.232.129.153) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Dec 2019 17:13:58 +0000 IronPort-SDR: ah8DSwGOjrChy66Ibpf0vlJOrQTF2RvtyA2p4YGKzyaKMF9oNWWkT9f3BDRZ/NulzFI6eSfj9G qWdXAwOJNfO3AwCrKionUmMY4Ye6AdHGc/WMx8OjYJPJDGdz5IJHNz4SwI3ezhBfJBrNM6+dxv EM1oE2qfeuWyurIpdhM2bHPigaPiRfE+f5YMZLFhFMRlL+yFxZveDysmFz0WBBOmetq6x0DIIW xiUogxgo054dOUaR22WRLpDEs9DuLStT8sRd5BjomCgqnHgPb0wf1eDR4uykBZrqlvAmGV2FIp XIw= Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa1.mentor.iphmx.com with ESMTP; 18 Dec 2019 09:13:56 -0800 IronPort-SDR: 0aDVgFEBgol8LLEWTDxPaD6GaVHngNw0iU1hoxF5WV+UV2ae1ddudvVC6RcL8OMikeXc8tqjy5 rzZmpox4DOyDjLbGmrNvXfHalUr+uBVXTABQzBcJK4Qp2xDVOzoQteGZLkYKRDsD1eUhbzsVj/ gmirdWcSyk6xXK/RPhopzIT4F/3VQCKy5juFnKczbTOinANRC1drG1WgptYksATIXxapwW/b4+ qPst2U6hoNQ1I5iY3DkQW7gjJ/FLe80wvFl+yIw/iUWnLHBu5o9DsZmMyqq56kDuFTM/suOTty yxI= From: Thomas Schwinge To: Jakub Jelinek , CC: Martin Jambor , Alexander Monakov Subject: Re: [RFC PATCH] Coalesce host to device transfers in libgomp In-Reply-To: <20171025113850.GR14653@tucnak> References: <20171024095527.GJ14653@tucnak> <20171025113850.GR14653@tucnak> User-Agent: Notmuch/0.29.1+93~g67ed7df (https://notmuchmail.org) Emacs/26.1 (x86_64-pc-linux-gnu) Date: Wed, 18 Dec 2019 17:15:00 -0000 Message-ID: <87sglhwo8j.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-Path: tschwing@mentor.com X-SW-Source: 2019-12/txt/msg01337.txt.bz2 --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 845 Hi! On 2017-10-25T13:38:50+0200, Jakub Jelinek wrote: > --- libgomp/target.c.jj 2017-10-24 12:07:03.763759657 +0200 > +++ libgomp/target.c 2017-10-25 13:17:31.608975390 +0200 > +/* Return true for mapping kinds which need to copy data from the > + host to device for regions that weren't previously mapped. */ > + > +static inline bool > +gomp_to_device_kind_p (int kind) > +{ > + switch (kind) > + { > + case GOMP_MAP_ALLOC: > + case GOMP_MAP_FROM: > + case GOMP_MAP_FORCE_ALLOC: > + case GOMP_MAP_ALWAYS_FROM: > + return false; > + default: > + return true; > + } > +} Poor 'GOMP_MAP_FORCE_FROM'... ;'-| See attached "[OpenACC] In 'libgomp/target.c:gomp_to_device_kind_p', handle 'GOMP_MAP_FORCE_FROM' like 'GOMP_MAP_FROM'"; committed to trunk in r279533. Gr=C3=BC=C3=9Fe Thomas --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-OpenACC-In-libgomp-target.c-gomp_to_device_kin.trunk.patch Content-Transfer-Encoding: quoted-printable Content-length: 1407 =46rom 74bb6382e2be4c478e2f58daa3cdf1c42b6c2480 Mon Sep 17 00:00:00 2001 From: tschwinge Date: Wed, 18 Dec 2019 17:01:22 +0000 Subject: [PATCH] [OpenACC] In 'libgomp/target.c:gomp_to_device_kind_p', han= dle 'GOMP_MAP_FORCE_FROM' like 'GOMP_MAP_FROM' Fix oversight from r254194 "Coalesce host to device transfers in libgomp". libgomp/ * target.c (gomp_to_device_kind_p): Handle 'GOMP_MAP_FORCE_FROM' like 'GOMP_MAP_FROM'. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@279533 138bc75d-0d04-0410-9= 61f-82ee72b054a4 --- libgomp/ChangeLog | 3 +++ libgomp/target.c | 1 + 2 files changed, 4 insertions(+) diff --git a/libgomp/ChangeLog b/libgomp/ChangeLog index 871a1537c77..472519c7e3e 100644 --- a/libgomp/ChangeLog +++ b/libgomp/ChangeLog @@ -1,5 +1,8 @@ 2019-12-18 Thomas Schwinge =20 + * target.c (gomp_to_device_kind_p): Handle 'GOMP_MAP_FORCE_FROM' + like 'GOMP_MAP_FROM'. + PR libgomp/92726 PR libgomp/92970 PR libgomp/92984 diff --git a/libgomp/target.c b/libgomp/target.c index 41cf6a3d7d2..a3cdb34bd51 100644 --- a/libgomp/target.c +++ b/libgomp/target.c @@ -279,6 +279,7 @@ gomp_to_device_kind_p (int kind) case GOMP_MAP_ALLOC: case GOMP_MAP_FROM: case GOMP_MAP_FORCE_ALLOC: + case GOMP_MAP_FORCE_FROM: case GOMP_MAP_ALWAYS_FROM: return false; default: --=20 2.17.1 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" Content-length: 658 -----BEGIN PGP SIGNATURE----- iQGzBAEBCgAdFiEEU9WEfWKGQazCmycCAKI7+41Q4XkFAl36XkwACgkQAKI7+41Q 4Xna5Av+Nq9bAzbYzZ7Vf2z6SE2zQcRgzV3ROTKv+kxgCkqc9bVKhc9l36bKDcCe TBy+ceqLNOcsKcisBciFMpgx0IpJ1DsNT0NQNhl4xXXvp05My4HAHQan6Zc4ZMBx IMtoGigXtrs0YOj1SJjsIYQztiy7ytq1rp8JFts6R7N+9Gfe4mK5CNcPVV/ohYeJ EJ0u0I6xwNMXpmPqqrXG2mrx3WJDqRtr5IhtbmvsONbUJKcD5+Cm8cF2XPF+36bo MuO3VX1r353uvIMQyaWGsza/krP/DVpn/xEwgSHBzqYeYB6v/4UUxsVqWBzAHcEP Q1TKqaD+0+rRXcY6kfslsDp5b8POyNRjCJvKZzEhjHiL1uDFDQwziv0ouzo0qKU9 1D10drkORxyjV7+4R/xEgFkm2p767HpR0K9IsQgAa2ZrvmZhyF5xjKZvB47QIP7b Hh8Ub89+2Ba4F98IOwNPuYGkEgTZr2Ke7ydsyaVkyEmHhIXdMlbV3TH9ni4V7X9F erxTpGND =9PvU -----END PGP SIGNATURE----- --==-=-=--