From: Thomas Schwinge <thomas@codesourcery.com>
To: Tom de Vries <Tom_deVries@mentor.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [committed, nvptx] Add nvptx_override_options_after_change
Date: Tue, 08 Aug 2017 08:46:00 -0000 [thread overview]
Message-ID: <87shh230t1.fsf@euler.schwinge.homeip.net> (raw)
In-Reply-To: <65b84334-0d77-2507-fb65-f94c87ce8d1c@mentor.com>
Hi Tom!
On Fri, 21 Jul 2017 11:49:11 +0200, Tom de Vries <Tom_deVries@mentor.com> wrote:
> this patch adds nvptx_override_options_after_change, containing a
> workaround for PR81430.
> --- a/gcc/config/nvptx/nvptx.c
> +++ b/gcc/config/nvptx/nvptx.c
> @@ -207,6 +207,17 @@ nvptx_option_override (void)
> target_flags |= MASK_SOFT_STACK | MASK_UNIFORM_SIMT;
> }
>
> +/* Implement TARGET_OVERRIDE_OPTIONS_AFTER_CHANGE. */
> +
> +static void
> +nvptx_override_options_after_change (void)
> +{
> + /* This is a workaround for PR81430 - nvptx acceleration compilation broken
> + because of running pass_partition_blocks. This should be dealt with in the
> + common code, not in the target. */
> + flag_reorder_blocks_and_partition = 0;
> +}
Should this be reverted now that r250852 "Apply finish_options on
DECL_FUNCTION_SPECIFIC_OPTIMIZATION for ACCEL_COMPILER" has been
committed? (I'm confirming this works fine, thanks.)
Grüße
Thomas
next prev parent reply other threads:[~2017-08-08 8:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 9:22 [PATCH, PR81430] Use finalize_options in lto1 Tom de Vries
2017-07-20 10:10 ` Richard Biener
2017-07-20 15:35 ` Tom de Vries
2017-07-21 9:41 ` Richard Biener
2017-07-21 13:40 ` Tom de Vries
2017-07-25 11:24 ` Richard Biener
2017-07-21 9:49 ` [committed, nvptx] Add nvptx_override_options_after_change Tom de Vries
2017-08-08 8:46 ` Thomas Schwinge [this message]
2017-08-08 8:58 ` Tom de Vries
2017-08-11 16:46 ` Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shh230t1.fsf@euler.schwinge.homeip.net \
--to=thomas@codesourcery.com \
--cc=Tom_deVries@mentor.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).