From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42253 invoked by alias); 9 Dec 2015 16:25:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 42222 invoked by uid 89); 9 Dec 2015 16:25:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Dec 2015 16:25:33 +0000 Received: from svr-orw-fem-05.mgc.mentorg.com ([147.34.97.43]) by relay1.mentorg.com with esmtp id 1a6hYX-0000o8-4B from Thomas_Schwinge@mentor.com ; Wed, 09 Dec 2015 08:25:29 -0800 Received: from tftp-cs (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.3.224.2; Wed, 9 Dec 2015 08:25:28 -0800 Received: by tftp-cs (Postfix, from userid 49978) id 430E9C232B; Wed, 9 Dec 2015 08:25:28 -0800 (PST) From: Thomas Schwinge To: Jakub Jelinek , GCC Patches Subject: Splitting up gcc/omp-low.c? (was: [hsa 5/10] OpenMP lowering/expansion changes (gridification)) In-Reply-To: <20151209131930.GS5675@tucnak.redhat.com> References: <20151207111758.GA24234@virgil.suse.cz> <20151207112243.GF24234@virgil.suse.cz> <20151209131930.GS5675@tucnak.redhat.com> User-Agent: Notmuch/0.9-125-g4686d11 (http://notmuchmail.org) Emacs/24.5.1 (i586-pc-linux-gnu) Date: Wed, 09 Dec 2015 16:25:00 -0000 Message-ID: <87si3b4mk3.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-SW-Source: 2015-12/txt/msg01023.txt.bz2 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 1237 Hi! I've been meaning to suggest this for some time already: On Wed, 9 Dec 2015 14:19:30 +0100, Jakub Jelinek wrote: > As for omp-low.c changes, the file is already large enough that it would = be > nice if it is easy to find out what routines are for gridification purpos= es > only, use some special prefix (grid_*, ompgrid_*, ...) for all such > functions? In addition to that, how about we split up gcc/omp-low.c into several files? Would it make sense (I have not yet looked in detail) to do so along the borders of the several passes defined therein? Or, can you tell already that there would be too many cross-references between the several files to make this infeasible? I'd suggest to do this shortly before GCC 6 is released, so that backports from trunk to gcc-6-branch will be easy. (I assume we don't have to care for gcc-5-branch backports too much any longer.) $ wc -l gcc/*.c | sort -r -n | head 879881 total 25770 gcc/dwarf2out.c 19834 gcc/omp-low.c 14419 gcc/fold-const.c 14357 gcc/combine.c 14003 gcc/tree.c 11622 gcc/expr.c 11610 gcc/gimplify.c 10417 gcc/tree-vrp.c 10328 gcc/var-tracking.c Gr=C3=BC=C3=9Fe Thomas --=-=-= Content-Type: application/pgp-signature; name="signature.asc" Content-length: 472 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJWaFXNAAoJEK3/DN1sMFFtBxcH/3EkJkyMgruOYpB693LkYZbb slSrAORGnqt0Ied5jyKCXWdi/CHXix3Cpj5AranI/srg3r/s2z36XaK3xRNIS1Z6 tBriP3BE2UTrOwb5+UmPv6ybzTR87TKeOxIVtNBmTfhogjAvJMVCen8YAFxKgNPC +l81JKgiIrit/t5m54CcgWQgAXtOqInAsxKxAgx6XE10184CZXjNQs6GUJ6wMTAw U6PdQ+BQ+kh8kOOSKnuVNpPEcRIBkd3xqxd5gVSuOG2ek/K4dCm4LUP/Cz+aeWC+ 64MfW/eOknSsKEdBX2LJIsH8HfFsiP1sqAkD2ZN01FeSacJ+XjgJdRFQSK/4Do0= =lEAT -----END PGP SIGNATURE----- --=-=-=--