From: Richard Sandiford <rdsandiford@googlemail.com>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: gcc-patches@gcc.gnu.org, "H.J. Lu" <hjl.tools@gmail.com>
Subject: Re: [x86] Fix gcc.c-torture/compile/20080806-1.c failures
Date: Mon, 05 Nov 2012 18:56:00 -0000 [thread overview]
Message-ID: <87sj8ndgl0.fsf@talisman.home> (raw)
In-Reply-To: <CAFULd4YQ_-EhWUeVShPOw_6FBE7ossiM6bzc81ZGjySqL6K7KA@mail.gmail.com> (Uros Bizjak's message of "Mon, 5 Nov 2012 10:01:38 +0100")
Uros Bizjak <ubizjak@gmail.com> writes:
> On Mon, Nov 5, 2012 at 9:30 AM, Richard Sandiford
> <rdsandiford@googlemail.com> wrote:
>> gcc/
>> PR target/55204
>> * config/i386/i386.c (ix86_address_subreg_operand): Remove stack
>> pointer check.
>> (print_reg): Use true_regnum rather than REGNO.
>> (ix86_print_operand_address): Remove SUBREG handling.
>
> The patch is OK for mainline and 4.7, if it passes H.J.'s tests with
> -maddress-mode={short,long} on x32.
>
>> + unsigned int regno = true_regnum (x);
>
> I'd rather see the declaration at the beginning of the function.
OK, thanks, applied to both with that change.
Richard
next prev parent reply other threads:[~2012-11-05 18:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 8:30 Richard Sandiford
2012-11-05 9:01 ` Uros Bizjak
2012-11-05 10:21 ` H.J. Lu
2012-11-05 12:54 ` H.J. Lu
2012-11-05 18:56 ` Richard Sandiford [this message]
2012-11-05 23:34 ` H.J. Lu
2012-11-05 23:57 ` H.J. Lu
2012-11-06 7:38 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sj8ndgl0.fsf@talisman.home \
--to=rdsandiford@googlemail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).