From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id DF3C53858C2A for ; Thu, 7 Dec 2023 01:37:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DF3C53858C2A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DF3C53858C2A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701913055; cv=none; b=F+OWHAlClOSg5nqxQlTV8ckODtyv2DRWv8sDbDAT3kp0vkWQphgieBPx6Ru9ryo3NQW48jRVa288vexT1YWIXFj2ethMmyPQNJQ4WQ8rV2331QdbjsV3EYJyImacihlHkbYfCInxTomEKmzaD2kEDgUTOKemddOGrHvmiREFln8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701913055; c=relaxed/simple; bh=mhZMOz8LpLVnnTKeNtq1YrtnQaEUWmVV083+qgm+Sj4=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=H5UnAMIC8EeiOFnHE1L4nzBVdvckmZGLV0CMgNMKEMqcYE3e0DSSRDBVtUa1PjLEU+oCKDEdk5vHcSxAVKxMH4ekAKeHMTXOR4zlz7Q+52rOYbZpDiqnbhY8MGVdWr7aU5el2Qi1B/WDIgg7QqdapRboOTk/B0zBEWknhc67Yls= ARC-Authentication-Results: i=1; server2.sourceware.org References: <20231206022931.33437-1-yangyujie@loongson.cn> <871qbzcyy4.fsf@oldenburg.str.redhat.com> User-agent: mu4e 1.10.8; emacs 30.0.50 From: Sam James To: Yang Yujie Cc: Jeff Law , Florian Weimer , ro@cebitec.uni-bielefeld.de, mikestump@comcast.net, gcc-patches@gcc.gnu.org Subject: Re: [PATCH] testsuite: Adjust for the new permerror -Wincompatible-pointer-types Date: Thu, 07 Dec 2023 01:35:23 +0000 Organization: Gentoo In-reply-to: Message-ID: <87ttouhjxl.fsf@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,KAM_SHORT,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Yang Yujie writes: > On Wed, Dec 06, 2023 at 10:45:22AM -0700, Jeff Law wrote: >> >> >> On 12/6/23 05:12, Florian Weimer wrote: >> > * Yang Yujie: >> > >> > > From: Yang Yujie >> > > Subject: [PATCH] testsuite: Adjust for the new permerror >> > > -Wincompatible-pointer-types >> > > To: gcc-patches@gcc.gnu.org >> > > Cc: ro@CeBiTec.Uni-Bielefeld.DE, mikestump@comcast.net, fweimer@redhat.com, >> > > Yang Yujie >> > > Date: Wed, 6 Dec 2023 10:29:31 +0800 (9 hours, 42 minutes, 7 seconds ago) >> > > Message-ID: <20231206022931.33437-1-yangyujie@loongson.cn> >> > > >> > > r14-6037 turned -Wincompatible-pointer-types into a permerror, >> > > which causes the following tests to fail. >> > > >> > > gcc/testsuite/ChangeLog: >> > > >> > > * gcc.dg/fixed-point/composite-type.c: replace dg-warning with dg-error. >> > > --- >> > > .../gcc.dg/fixed-point/composite-type.c | 64 +++++++++---------- >> > > 1 file changed, 32 insertions(+), 32 deletions(-) >> > >> > Looks reasonable to me, but I can't approve it. >> We might want to fix that from a policy standpoint :-) >> >> Regardless, this is OK for the trunk. Thanks Yang for taking care of it. I >> don't see you in the maintainers file, so I'll go ahead and push it >> momentarily. >> >> jeff > > Thanks for the review! > > With this patch, I also noticed a few errors in building unpatched older > software like expect-5.45.4, perl-5.28.3 and bash-5.0. Will this also be > the case when GCC 14 gets released? > Old versions of software will need to be patched or built with -fpermissive. We are working on fixing supported versions of software and sending patches upstream - please do join in if you're able, as the more help the better. It is normal for software to need porting to newer compilers. For example, https://gcc.gnu.org/gcc-10/porting_to.html (-fcommon). > Thanks, > Yujie thanks, sam